5.0m1-5.0.42m18

CCBYSA Frank Bennett <https://twitter.com/fgbjr>_


Merge changes from upstream

commit:14e067d
author:Frank Bennett
date:2018-03-31 09:40 (JST)

Update translators

commit:e97f938
author:Frank Bennett
date:2018-03-31 09:32 (JST)

Avoid error on first use of widget

commit:ca64692
author:Frank Bennett
date:2018-03-30 18:58 (JST)

Reopen targeted collection on window open if closed at save time (macOS)

commit:37e850c
author:Dan Stillman
date:2018-03-30 14:55 (JST)

Fix attachment save failure on macOS with window closed

commit:5a08d22
author:Dan Stillman
date:2018-03-30 14:47 (JST)

Use hiddenDOMWindow if no other window


Update citeproc-js to 1.1.199

commit:fe5af63
author:Dan Stillman
date:2018-03-30 07:27 (JST)

Fix weird test failure after c5cd38b4a5

commit:52c1249
author:Dan Stillman
date:2018-03-29 21:27 (JST)

The change in c5cd38b4a5 seems like it shouldn’t have had any effect, but creating an empty Set before yielding somehow avoided a race condition with the subsequent updateSession call.


Additional comments and cleanup for target selector handler

commit:c5cd38b
author:Dan Stillman
date:2018-03-29 20:27 (JST)

Skip items in save session that no longer exist

commit:9b9773d
author:Dan Stillman
date:2018-03-29 20:40 (JST)

Ideally I guess the entry would be removed from the save popup in the connector and a second button click would do a fresh save rather than reopening the popup, but for now just avoid an error.

Addresses zotero/zotero-connectors#220


Don’t select items in trash on target selector change

commit:a4aabd9
author:Dan Stillman
date:2018-03-29 20:24 (JST)

Items in the trash will still be updated properly (since they can still exist in collections and have tags), but the collection selected in the target selector should remain selected in the client.

Addresses zotero/zotero-connectors#220


Update parent item from target selector if item was made a child item

commit:00d85fb
author:Dan Stillman
date:2018-03-29 20:16 (JST)

This is necessary for automatic PDF recognition.

Addresses zotero/zotero-connectors#220


Return proper text for 409 errors from HTTP server

commit:0f6b712
author:Dan Stillman
date:2018-03-29 20:11 (JST)

Add Zotero.Item.prototype.parentItem getter

commit:46eb84e
author:Dan Stillman
date:2018-03-29 20:11 (JST)

Reimplement extraction, bind all items in document to shared library

commit:abdc92e
author:Frank Bennett
date:2018-03-29 10:05 (JST)

Support target selector sessions for /connector/import

commit:38330e4
author:Dan Stillman
date:2018-03-28 21:45 (JST)

Add a test case for copied citations (for 9c7271c6)

commit:bff7cee
author:Adomas Venčkauskas
date:2018-03-28 20:55 (JST)

Fix citations copied from other documents causing citeproc errors

commit:9c7271c
author:Adomas Venčkauskas
date:2018-03-28 20:40 (JST)

Might slow down the initial interaction with a document in automatic updates mode.


Fix non-HiDPI tag swatches when item type image is low-res

commit:9ae582e
author:Dan Stillman
date:2018-03-28 14:24 (JST)

Restore Zotero.Cite.getAbbreviation, needed by Better BibTeX

commit:54deeb7
author:Frank Bennett
date:2018-03-28 06:46 (JST)

Update version

commit:292a033
author:Dan Stillman
date:2018-03-28 01:11 (JST)

Fix potential upgrade error from c96363746b

commit:3c5bc44
author:Dan Stillman
date:2018-03-27 23:42 (JST)

If a related item was defined using both an old userID and the current one, the schema upgrade step could fail.


Update locales from Transifex

commit:3db9155
author:Dan Stillman
date:2018-03-27 23:34 (JST)

Force empty storage filenames to ‘_’

commit:24b9612
author:Dan Stillman
date:2018-03-27 23:17 (JST)

Hopefully fixes https://forums.zotero.org/discussion/71039/sync-error-empty-path-for-item


Update version

commit:a9e047c
author:Dan Stillman
date:2018-03-27 23:18 (JST)

Restore 34455197149ce15ea24156804e8412fcf2b7b9f5

commit:9035554
author:Frank Bennett
date:2018-03-27 19:48 (JST)

Upstream fixes for integration

commit:cf82f0b
author:Frank Bennett
date:2018-03-27 19:44 (JST)

Update version

commit:6052f4c
author:Dan Stillman
date:2018-03-27 18:56 (JST)

Ensure citation fields are properly initialized (regression 3445519)

commit:4e977f9
author:Adomas Venčkauskas
date:2018-03-27 18:43 (JST)

Bump version to m17

commit:cc0748f
author:Frank Bennett
date:2018-03-27 18:36 (JST)

Revert 34455197149ce15ea24156804e8412fcf2b7b9f5

commit:dd0ed5f
author:Frank Bennett
date:2018-03-27 18:27 (JST)

Update translators

commit:b600885
author:Dan Stillman
date:2018-03-27 16:10 (JST)

Adjust tests to reflect author-to-director CSL-M video mapping

commit:254637b
author:Frank Bennett
date:2018-03-27 07:06 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0-dev

commit:79d1cc7
author:Frank Bennett
date:2018-03-27 06:40 (JST)

Bump version to m15

commit:62a3187
author:Frank Bennett
date:2018-03-27 06:36 (JST)

Update translators and repotime

commit:35ea73f
author:Frank Bennett
date:2018-03-27 06:36 (JST)

Fix display bug in multilingual fields

commit:bdb69f0
author:Frank Bennett
date:2018-03-27 06:32 (JST)

Fix citationByIndex[i].sortedItem errors during citation insertion

commit:3445519
author:Adomas Venčkauskas
date:2018-03-26 21:31 (JST)

Caused by inproper handling of copy-pasted citations in documents


Update COPYING

commit:e746da4
author:Sean Takats
date:2018-03-26 18:27 (JST)

Fix upgrade error in c96363746b if no related items

commit:32aebd3
author:Dan Stillman
date:2018-03-26 17:48 (JST)

Fix related-item relations pointing to a previous user account

commit:c963637
author:Dan Stillman
date:2018-03-26 15:09 (JST)

If somebody switched accounts in a previous version, it was apparently possible for related items to end up pointing at an item URI with the old userID, which could cause a 403 on sync.

https://forums.zotero.org/discussion/70989/report-id-477331252

(5.0 deletes data when switching accounts to avoid exactly this sort of bug.)


Use HiDPI icons in related-items box

commit:43692ee
author:Dan Stillman
date:2018-03-26 15:08 (JST)

Return pdfMaxPages to search preferences (#1475)

commit:39ed221
author:Martynas Bagdonas
date:2018-03-26 15:12 (JST)

Simplify installation instruction in README.md

commit:fdc8225
author:Frank Bennett
date:2018-03-26 12:09 (JST)

Add function to delay syncs, and connector server endpoint to trigger it

commit:2effad4
author:Dan Stillman
date:2018-03-25 17:56 (JST)

This will allow the connector to delay syncs while the target selector window is open, and it can probably be used for imports and other things.


Force author to director in CSL JSON export of videoRecording

commit:7b580bd
author:Frank Bennett
date:2018-03-25 08:17 (JST)

Fix regression in item type switch

commit:d75f7ea
author:Frank Bennett
date:2018-03-24 23:05 (JST)

Update repotime

commit:e703356
author:Frank Bennett
date:2018-03-24 21:10 (JST)

Update translators

commit:05a7ba4
author:Frank Bennett
date:2018-03-24 21:09 (JST)

Update jurisdiction data object

commit:ae36e7d
author:Frank Bennett
date:2018-03-24 20:26 (JST)

Bump version to 5.0.39m14

commit:97593a8
author:Frank Bennett
date:2018-03-24 16:08 (JST)

Update citeproc-js to 1.1.198

commit:f7f1962
author:Frank Bennett
date:2018-03-24 14:15 (JST)

Fix object key

commit:1997e07
author:Frank Bennett
date:2018-03-24 13:00 (JST)

Update translators

commit:41ff8f1
author:Frank Bennett
date:2018-03-24 12:51 (JST)

Set up for app extras

commit:5845102
author:Frank Bennett
date:2018-03-24 12:42 (JST)

Remove value from config

commit:ea38bb2
author:Frank Bennett
date:2018-03-24 12:41 (JST)

Add missing test data to repo

commit:6bb8bb0
author:Frank Bennett
date:2018-03-23 09:09 (JST)

Massage date parser a little, small revisions to itemFromCSLJSON and itemToCSLJSON

commit:483f138
author:Frank Bennett
date:2018-03-23 08:17 (JST)

Align citeProcJSExport.js dates with form used in Zotero tests

commit:082bf98
author:Frank Bennett
date:2018-03-23 08:16 (JST)

Fix item URLs not unproxifying when saving from the connector

commit:b9837c6
author:Adomas Venčkauskas
date:2018-03-22 22:36 (JST)

Regression from zotero/zotero-connectors#b7a0872


Fix citeproc.js, busted by merge oversight

commit:1fff63b
author:Frank Bennett
date:2018-03-22 19:46 (JST)

Update locales from upstream

commit:3246d6a
author:Frank Bennett
date:2018-03-22 19:43 (JST)

Update translators

commit:5e12ecf
author:Frank Bennett
date:2018-03-22 19:39 (JST)

Set to JM repotime.txt

commit:17d4c97
author:Frank Bennett
date:2018-03-22 19:39 (JST)

Merge changes from upstream

commit:52346c9
author:Frank Bennett
date:2018-03-22 19:39 (JST)

Fixes for bugs in tabbing, click-label-to-blur, and court/jurisdiction field updates

commit:42c7e00
author:Frank Bennett
date:2018-03-22 18:01 (JST)

Create automatic (not manual) tags when retrieving PDF metadata by ISBN

commit:67b34b1
author:Dan Stillman
date:2018-03-22 04:58 (JST)

https://forums.zotero.org/discussion/71003/metadata-problem


Update version

commit:a673956
author:Dan Stillman
date:2018-03-22 02:35 (JST)

Update locales from Transifex

commit:447659c
author:Dan Stillman
date:2018-03-22 01:13 (JST)

Bump version

commit:08e9bd7
author:Frank Bennett
date:2018-03-21 11:16 (JST)

Allow vertical bar to remain when normalizing abbrev keys

commit:928be2a
author:Frank Bennett
date:2018-03-21 11:16 (JST)

Update citeproc-js to 1.1.197

commit:00d4a5d
author:Frank Bennett
date:2018-03-21 07:46 (JST)

Merge new English strings

commit:8782eaf
author:Dan Stillman
date:2018-03-21 07:41 (JST)

Update translators

commit:c71f657
author:Dan Stillman
date:2018-03-20 16:48 (JST)

Update locales from Transifex

commit:dabd7c1
author:Dan Stillman
date:2018-03-20 16:46 (JST)

Changes to fix jurisdiction bugs

commit:5533427
author:Frank Bennett
date:2018-03-20 21:04 (JST)

Shows original and modified citation in warning prompt. Closes #1468

commit:3e39cb3
author:Adomas Venčkauskas
date:2018-03-20 18:47 (JST)

Use 1.25dppx for HiDPI icon threshold

commit:d44cc05
author:Dan Stillman
date:2018-03-20 05:46 (JST)

On some laptops, scaling settings might cause the DPI to drop between 96 (1x) and 144 (1.5x), and downscaled icons are probably better than upscaled ones.


Fix corrupt citation prompt going into recursive loop

commit:a12b997
author:Adomas Venčkauskas
date:2018-03-19 18:36 (JST)

Fix alert not displaying after failed style install

commit:8d3e893
author:Adomas Venčkauskas
date:2018-03-19 17:52 (JST)

Replace p tag with two line breaks in ZU.cleanTags (#1465)

commit:0bb2bdc
author:Philipp Zumstein
date:2018-03-19 15:35 (JST)

Register suppressedJurisdictions list in an async statement before processor is invoked

commit:c8c2236
author:Frank Bennett
date:2018-03-18 18:27 (JST)

Fix edited citation prompt not displaying (regression 25d8898)

commit:a659c6c
author:Adomas Venčkauskas
date:2018-03-18 04:47 (JST)

Fix [(j-1)].sorteditems.slice(…)[0] is undefined integration error

commit:749faab
author:Adomas Venčkauskas
date:2018-03-18 04:39 (JST)

Caused by empty citations being present in the document (i.e. without any cited items and placeholder text like {Citation}).


Use language field returned from recognizer-server

commit:7b8f2e1
author:Martynas Bagdonas
date:2018-03-17 02:40 (JST)

Bump version to 5.0.37m11

commit:51428e7
author:Frank Bennett
date:2018-03-16 15:27 (JST)

Update translators

commit:d063ed8
author:Frank Bennett
date:2018-03-16 15:26 (JST)

Update citeproc-js to 1.1.193

commit:cf12f1e
author:Dan Stillman
date:2018-03-16 02:13 (JST)

Update locales from Transifex and merge new English strings

commit:da08d7f
author:Dan Stillman
date:2018-03-15 16:23 (JST)

“Choose File Handler” -> “Choose Application” for PDF viewer

commit:06e17fd
author:Dan Stillman
date:2018-03-15 16:12 (JST)

(And potentially others in the future)


Update locales from Transifex and merge new English strings

commit:d145cff
author:Dan Stillman
date:2018-03-15 02:23 (JST)

Ensure delayed citation prompt strings are localizable

commit:e3648df
author:Adomas Venčkauskas
date:2018-03-15 02:08 (JST)

Ensure that document refresh doesn’t perform needless text writes

commit:25d8898
author:Adomas Venčkauskas
date:2018-03-14 22:27 (JST)

Clarify location of refresh button in delayed citation copy

commit:92346c8
author:Adomas Venčkauskas
date:2018-03-14 20:21 (JST)

Increase citation delay prompt timeout to 15 seconds

commit:6f6e18b
author:Adomas Venčkauskas
date:2018-03-14 16:22 (JST)

By prompting after 3 seconds we catch a lot of people who click through the prompt without bothering to read or figure out what it does and then come to the forums report the citing “bugs”. An increased timeout will catch less people and those who are caught are possibly more likely to figure out how delayed citing updates work since they would greatly benefit from it.


Restore Report Errors item

commit:3f2861a
author:Frank Bennett
date:2018-03-13 05:51 (JST)

Fix integration delayed citations popup timer. Closes #1461

commit:6c5aa06
author:Adomas Venčkauskas
date:2018-03-12 21:52 (JST)

Fix bug in Court field

commit:afbdcce
author:Frank Bennett
date:2018-03-12 10:36 (JST)

Update citeproc-js to 1.1.194

commit:a256398
author:Frank Bennett
date:2018-03-12 07:30 (JST)

Bump jurisdictions version

commit:7f448c1
author:Frank Bennett
date:2018-03-12 07:23 (JST)

Use all DOI translators for metadata retrieval

commit:c04b85e
author:Dan Stillman
date:2018-03-12 07:15 (JST)

The old recognizer code only used CrossRef, and the new code copied that, but I think the old code simply predated additional DOI translators and was never updated.


Refresh jurisdictions for NZ

commit:027d5a8
author:Frank Bennett
date:2018-03-12 07:09 (JST)

Update locales from upstream

commit:033ba03
author:Frank Bennett
date:2018-03-11 22:34 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0-dev

commit:d3744c7
author:Frank Bennett
date:2018-03-11 22:32 (JST)

Update jurisdictions

commit:317e1ac
author:Frank Bennett
date:2018-03-11 22:27 (JST)

Update version

commit:c89df69
author:Dan Stillman
date:2018-03-11 17:37 (JST)

Update locales from Transifex

commit:71bee9c
author:Dan Stillman
date:2018-03-11 16:01 (JST)

Remove obsolete line from Babel config

commit:92dcd41
author:Dan Stillman
date:2018-03-11 15:41 (JST)

The whole resource/tinymce directory is symlinked now.


Fix note display in read-only libraries and classic citation dialog

commit:90b9754
author:Dan Stillman
date:2018-03-11 15:41 (JST)

Select created items when importing RIS/BibTeX from connector

commit:877ff97
author:Dan Stillman
date:2018-03-11 15:20 (JST)

Don’t delete automatic tags after web translation

commit:137a0eb
author:Dan Stillman
date:2018-03-11 01:18 (JST)

Regression from c8cf9b9e6f, probably


Update version

commit:53bea1f
author:Dan Stillman
date:2018-03-11 01:15 (JST)

Follow Zotero practice of setting CSL date parser from current UI locale

commit:7392051
author:Frank Bennett
date:2018-03-10 18:14 (JST)

Make dateparser independent of CiteProc

commit:f82421a
author:Frank Bennett
date:2018-03-10 18:13 (JST)

Safer fix for external note focus issues

commit:3dcdd7f
author:Dan Stillman
date:2018-03-10 05:15 (JST)

Follow-up to 96e96c0348 and 07efe0304e


Fix separate-window button for child notes (broken by 96e96c0348)

commit:07efe03
author:Dan Stillman
date:2018-03-10 05:01 (JST)

Update locales from Transifex

commit:efe5d86
author:Dan Stillman
date:2018-03-10 04:33 (JST)

Update submodules

commit:5f6de1c
author:Dan Stillman
date:2018-03-10 04:32 (JST)

Focus correct note window when multiple note windows are open

commit:96e96c0
author:Dan Stillman
date:2018-03-10 04:24 (JST)

Probably broken by dcfaa5521e


Fix multiple-item context menu (broken by 7e3bad7390)

commit:6745ea9
author:Dan Stillman
date:2018-03-09 20:58 (JST)

Select parent item after metadata retrieval if only PDF was selected

commit:6c8cf71
author:Dan Stillman
date:2018-03-09 20:39 (JST)

TODO: select all parents


Fix cut-off top line of search bar on Windows

commit:16ad422
author:Dan Stillman
date:2018-03-09 20:35 (JST)

Restore attachment title and filename when undoing Retrieve Metadata

commit:da30f9e
author:Dan Stillman
date:2018-03-09 15:07 (JST)

Update locales from Transifex

commit:f5a2534
author:Dan Stillman
date:2018-03-09 12:03 (JST)

Keep PDF handler menulist the right size

commit:81a75d7
author:Dan Stillman
date:2018-03-09 09:38 (JST)

Don’t hide the automatic citation updates option in doc prefs

commit:f871da1
author:Adomas Venčkauskas
date:2018-03-09 05:23 (JST)

Merge new English strings

commit:2f7c93a
author:Dan Stillman
date:2018-03-08 18:07 (JST)

Allow a day for undo/report for metadata retrieval, not an hour

commit:23ebded
author:Dan Stillman
date:2018-03-08 18:06 (JST)

“Undo Retrieve Metadata” and “Report Inaccurate Metadata”

commit:7e3bad7
author:Dan Stillman
date:2018-03-08 17:50 (JST)

New context menu options for items that were recognized in the last day and that haven’t been modified


Fix embedded items not showing up in the citation dialog.

commit:cc5c17a
author:Adomas Venčkauskas
date:2018-03-08 17:21 (JST)

Regression in 2ad0dc00d, bad fix in 553d2b00. Closes #1448


Use ‘paste’ plugin from TinyMCE 4.6.7 to fix drag and drop cursor issue

commit:c7d05ad
author:Dan Stillman
date:2018-03-08 14:17 (JST)

https://forums.zotero.org/discussion/70720/after-copy-by-dragging-the-cursor-disappears


Fix font size scaling of tag selector tags on macOS and Linux

commit:438d966
author:Dan Stillman
date:2018-03-08 12:15 (JST)

Prevent note font size pref from being cut off

commit:ea569b8
author:Dan Stillman
date:2018-03-07 18:26 (JST)

Merge new English strings

commit:37eb26d
author:Dan Stillman
date:2018-03-07 18:51 (JST)

Reorganize file prefs and add UI for choosing PDF handler

commit:647463c
author:Dan Stillman
date:2018-03-07 18:20 (JST)
  • Add a File Handling section to the General pane of the preferences, and move several prefs from Miscellaneous to there
  • Add a UI to that section for choosing the PDF handler
  • Update Zotero.launchFileWithApplication() to use /usr/bin/open on macOS if the handler is an .app (which it will be if set through the chooser, since it’s limited to Mac applications, though an executable can still be set via the hidden pref if desired for some reason)
  • Move prefs for style/translator updates and translator error reporting (which isn’t particularly relevant anymore in the client) to Advanced

By default the PDF handler chooser says “System Default”, which isn’t the nicest thing, and there’s probably a way to get/guess the system default, since Firefox seems to know it (at least on macOS), but I couldn’t quickly find a way to do it.

Addresses #1450


Fix unloaded citation items being serialized with string IDs

commit:079cb25
author:Adomas Venčkauskas
date:2018-03-06 18:46 (JST)

Only show Quick Copy menu option when appropriate

commit:b25d99c
author:Dan Stillman
date:2018-03-06 18:38 (JST)

Reduce idle CPU use to ~0%

commit:c4a6421
author:Dan Stillman
date:2018-03-06 18:19 (JST)

Various animated things (search spinner, progress meters) were using CPU even when hidden, either because they weren’t properly hidden (equivalent of display: none rather than visibility: hidden) or because of bizarre Firefox bugs with progress meters on Linux.

Addresses #1455


Allow custom handler for PDF files

commit:da09a3b
author:Dan Stillman
date:2018-03-06 09:29 (JST)

Configurable via extensions.zotero.fileHandler.pdf hidden pref for now, though we’ll probably make it a visible pref.

We also appear to have been doing blocking launches when launch() failed, which may have been causing UI hangs when opening files on some Linux installations. (I’m not sure if that’s an issue with recent Firefox builds. launch() works on Ubuntu 17.10.) All launches are now async.

This is a rewritten version of PR #1450 by @ehhc.

Closes #1450


Additional debugging lines for connector sessions

commit:f6926cc
author:Dan Stillman
date:2018-03-03 05:16 (JST)

Update translators

commit:51ddc46
author:Dan Stillman
date:2018-03-06 08:10 (JST)

Update locales from Transifex

commit:de4aa4c
author:Dan Stillman
date:2018-03-06 08:00 (JST)

Make atob() available in translator sandbox

commit:23bbb5a
author:Dan Stillman
date:2018-03-06 07:37 (JST)

Addresses zotero/translators#1576


Fix blue toolbar background on Windows with DWM compositor

commit:87efe75
author:Dan Stillman
date:2018-03-06 07:13 (JST)

Applies to Windows 7 with Aero effects and later Windows versions


Fix an error being logged when window to activate is gone on Linux

commit:381351b
author:Adomas Venčkauskas
date:2018-03-05 21:28 (JST)

Show delayed citations checkbox in doc prefs dialog after initialization

commit:13766e1
author:Adomas Venčkauskas
date:2018-03-05 21:26 (JST)

Closes #1458


Fix dead integration field object function calls

commit:5a1cf3a
author:Adomas Venčkauskas
date:2018-03-05 20:46 (JST)

Small improvement in language menu. Scroll only content, allow cols to expand a little

commit:1585a58
author:Frank Bennett
date:2018-03-05 19:39 (JST)

Reduce delayed-citations timeout to 3 seconds

commit:3f905be
author:Dan Stillman
date:2018-03-05 16:16 (JST)

5 seconds is too long


Prevent doc prefs from expanding vertically

commit:1c23094
author:Frank Bennett
date:2018-03-05 05:48 (JST)

Include the recognizer URL in config

commit:5bf476a
author:Frank Bennett
date:2018-03-04 19:22 (JST)

Point client at new updater service

commit:c46ea4d
author:Frank Bennett
date:2018-03-04 15:36 (JST)

Update translators

commit:ed01b2a
author:Frank Bennett
date:2018-03-04 15:21 (JST)

Update locales from upstream

commit:c8f644d
author:Frank Bennett
date:2018-03-04 15:15 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0-dev

commit:e1409e6
author:Frank Bennett
date:2018-03-04 15:11 (JST)

Upgrade citeproc-js to 1.1.192

commit:376e77c
author:Frank Bennett
date:2018-03-04 14:55 (JST)

Make the Windows UI somewhat less unpleasant

commit:44632e2
author:Dan Stillman
date:2018-03-03 09:50 (JST)
  • Get rid of the hideous blue effect in the menubar and toolbar
  • Slim down splitters
  • Get rid of awful grippies except when collapsed (and make them slightly less ugly in the collapsed state)
  • Reduce spacing of tags in tag selector
  • Tweak twisty spacing
  • Get rid of stray line to the right of item pane tabs

We may still want to get rid of the menubar (#366), and we can do better than the ugly gray backgrounds (#365), but this is a start.

I’m not sure if everything will look the same on all Windows versions, so this will need a little testing.

Closes #367


Prevent Undo from clearing existing note

commit:724329d
author:Dan Stillman
date:2018-03-02 08:24 (JST)

When loading the first note of a session in the right-hand pane or when loading a note in the separate window, if you made a change and then pressed Undo twice (or maybe only once in some situations), it could undo to empty (though you could usually Redo to restore it).


Remove special handling of Cmd-Shift-Z in notes

commit:bf122ad
author:Dan Stillman
date:2018-03-02 08:19 (JST)

No longer relevant in standalone app


Symlink TinyMCE directory during build

commit:7a15c88
author:Dan Stillman
date:2018-03-02 08:18 (JST)

Update TinyMCE to 4.7.9

commit:e8403b9
author:Dan Stillman
date:2018-03-02 08:16 (JST)

Be more lenient about Extra field values than citeproc-js

commit:1f320e1
author:Dan Stillman
date:2018-03-02 06:58 (JST)

Allow fields like “Original Date: 2018” and convert them to “original-date: 2018” when sending to citeproc-js.

For reference:

http://citeproc-js.readthedocs.io/en/latest/csl-json/markup.html#cheater-syntax-for-odd-fields


Shorten auto-renaming pref

commit:e1e5178
author:Dan Stillman
date:2018-03-01 18:07 (JST)

So we now have autoRecognizeFiles and autoRenameFiles.


Disable background full-text processing during tests

commit:6e4d6a2
author:Dan Stillman
date:2018-03-01 17:45 (JST)

Increase Travis test timeout to 15 seconds

commit:18d0e98
author:Dan Stillman
date:2018-03-01 17:38 (JST)

Though it probably won’t help, since I imagine most timeouts are hangs caused by race conditions


Fix bug in 97661539dc

commit:7e290b2
author:Dan Stillman
date:2018-03-01 17:04 (JST)

Merge new English string

commit:0d4fd26
author:Dan Stillman
date:2018-03-01 16:03 (JST)

Avoid repeating line in Zotero.Fulltext.indexItems()

commit:00b2823
author:Dan Stillman
date:2018-03-01 15:12 (JST)

Wait for DB transaction to end before indexing string

commit:b50b055
author:Dan Stillman
date:2018-03-01 15:11 (JST)

This might help avoid timeouts during indexing.

Addresses #1284


Serialize attachment indexing

commit:1cfc901
author:Dan Stillman
date:2018-03-01 15:07 (JST)

Add newly added attachments to a queue, start processing it after five seconds have passed since the last attachment was added, and process another every half second after that unless another is added.

This queue won’t survive a restart, so the queue should really be in the DB, but this should avoid problems when adding multiple attachments at once.

Addresses #1284


Don’t show Reindex button for files that aren’t PDFs or text files

commit:26dcaad
author:Dan Stillman
date:2018-03-01 14:07 (JST)

Automatically retrieve metadata when saving PDFs

commit:9766153
author:Dan Stillman
date:2018-03-01 11:43 (JST)

Applies to dragging to the collections pane or the items pane, adding via New Item menu, or saving via the connector server

If the renaming pref is enabled, the PDF is renamed after recognition.

Can be disabled in the preferences

Closes #917


Disable auto_focus for TinyMCE

commit:081793f
author:Dan Stillman
date:2018-03-01 11:10 (JST)

TinyMCE triggers a focus on the window itself, which means that the window steals focus when an attachment is created even if another Zotero window is in front. Instead, do a manual focus in the external note window, which is the one place I could find where we rely on it (though there might be others).


Fix PDF recognition within collection (broken by f8b41c971c)

commit:3cc92fe
author:Dan Stillman
date:2018-03-01 07:34 (JST)

Fix recognizer dialog with multiple tests

commit:f99038f
author:Dan Stillman
date:2018-03-01 07:32 (JST)

Do cleanup on ‘unload’ rather than ‘close’ (which is limited to a click on the close button and doesn’t get called for win.close()) and clear the queue after each test.


Fix auto-rename after PDF recognition (wrong pref in f8b41c971)

commit:757709c
author:Dan Stillman
date:2018-03-01 06:27 (JST)

Add ‘window’ getter to CollectionTreeView and ItemTreeView

commit:da49f99
author:Dan Stillman
date:2018-03-01 06:23 (JST)

Fix scope of Zotero_RecognizePDF_Dialog

commit:aff2bef
author:Dan Stillman
date:2018-03-01 06:19 (JST)

When Window is accessed from another scope (e.g., ItemTreeView), the let somehow prevents Zotero_RecognizePDF_Dialog from showing up on the Window object like all the other objects loaded via <script>.


Update renamed styles

commit:16f228b
author:Dan Stillman
date:2018-02-28 18:30 (JST)

Update citeproc-js to 1.1.190

commit:153ed72
author:Dan Stillman
date:2018-02-28 18:29 (JST)

Update version

commit:7210653
author:Dan Stillman
date:2018-02-28 18:30 (JST)

Update locales from Transifex and merge new English strings

commit:e03ecfa
author:Dan Stillman
date:2018-02-28 16:52 (JST)

Fix await->yield in f8b41c971

commit:1d367f0
author:Dan Stillman
date:2018-02-28 09:24 (JST)

Automatic attachment file renaming changes

commit:f8b41c9
author:Dan Stillman
date:2018-02-27 15:40 (JST)

Automatic renaming is now done for dragging of an external file onto an item (as added in 7cb95f41) as well as dragging as a linked file, dragging a non-native (not text or HTML) URL, “Attach Link to File…”, “Attach Stored Copy of File…”, and “Retrieve Metadata for PDF”. It only applies if a single file is being added and if the parent item has no non-HTML attachments. By default, the renaming only applies to PDFs, but this can be changed with the renameAttachmentFiles.automatic.fileTypes hidden pref.

A new General pref, “Automatically rename attachment files using parent metadata”, controls whether the renaming happens.

Files saved via web translators are renamed regardless of this pref, because they would often be gibberish otherwise.

Closes #113


Replace some nsIWindowMediator getService() calls with Services.wm

commit:68879a0
author:Dan Stillman
date:2018-02-28 04:13 (JST)

Don’t use hidden browser to download images

commit:b0d9a9c
author:Dan Stillman
date:2018-02-28 06:04 (JST)

Add Zotero.File.rename() (extracted from Zotero.Item::renameAttachmentFile())

commit:f5b1ee4
author:Dan Stillman
date:2018-02-28 04:10 (JST)

Remove Fx54 test from Travis config

commit:b5cc0f9
author:Dan Stillman
date:2018-02-26 11:54 (JST)

Bump version

commit:935446a
author:Frank Bennett
date:2018-02-24 23:37 (JST)

Update styles

commit:1b4db7a
author:Frank Bennett
date:2018-02-24 23:36 (JST)

Bump version

commit:9afb9f2
author:Frank Bennett
date:2018-02-24 23:08 (JST)

Upgrade citeproc-js to 1.1.190

commit:307d506
author:Frank Bennett
date:2018-02-24 22:51 (JST)

Better handling of 403 for attachment metadata upload

commit:c0b63e5
author:Dan Stillman
date:2018-02-24 07:59 (JST)

Check file-editing access for the group from the API before offering to reset, update the filesEditable setting properly, and restart the sync automatically after resetting.


Make Esc in PDF recognizer window close rather than minimize if done

commit:5ed10c6
author:Dan Stillman
date:2018-02-23 16:38 (JST)

Bump version

commit:5f12bc7
author:Frank Bennett
date:2018-02-23 13:00 (JST)

Upgrade citeproc-js to 1.1.188

commit:a66ebfd
author:Frank Bennett
date:2018-02-23 12:41 (JST)

Use separate subdomain for recognizer requests for now

commit:7c64666
author:Dan Stillman
date:2018-02-22 16:01 (JST)

Improved PDF recognizer and 1x PDF icons

commit:c28c8c8
author:Dan Stillman
date:2018-02-22 14:26 (JST)

Update locales from Transifex and merge new English strings

commit:3fbb463
author:Dan Stillman
date:2018-02-22 15:04 (JST)

Tweak recognizer strings

commit:9ce9502
author:Dan Stillman
date:2018-02-22 15:03 (JST)

Merge pull request #1420 from mrtcode/recognizer

commit:a8312ac
author:Dan Stillman
date:2018-02-22 03:59 (JST)

New PDF recognizer


Throw actual error if file open fails in md5Async()

commit:9cb2b81
author:Dan Stillman
date:2018-02-22 00:21 (JST)

Fix version

commit:606fafb
author:Frank Bennett
date:2018-02-21 22:48 (JST)

Updated journal article icon with fixed transparency

commit:164fea0
author:Dan Stillman
date:2018-02-21 02:19 (JST)

New PDF recognizer

commit:991a50d
author:Martynas Bagdonas
date:2018-01-20 17:45 (JST)

Update citeproc-js to 1.1.186

commit:ce0dd5c
author:Dan Stillman
date:2018-02-19 21:23 (JST)

Update locales from Transifex and merge new English strings

commit:55b30dd
author:Dan Stillman
date:2018-02-19 06:11 (JST)

Hide Accessed row in attachment box when provided

commit:7fed34f
author:Dan Stillman
date:2018-02-19 05:24 (JST)

If, say, a link without an access date is created via an import


Show full URL in tooltip when hovering over attachment URL

commit:30b59eb
author:Dan Stillman
date:2018-02-19 05:24 (JST)

Nicer, localized messages for various field-too-long sync errors

commit:2200bad
author:Dan Stillman
date:2018-02-19 05:21 (JST)

Closes #351 Closes #1177


Update translators

commit:0267fef
author:Frank Bennett
date:2018-02-19 00:17 (JST)

Bump version to m4

commit:89c9f8e
author:Frank Bennett
date:2018-02-18 23:06 (JST)

File debug reports with Uni server

commit:19ab2c4
author:Frank Bennett
date:2018-02-18 23:05 (JST)

Remove Report Errors menu item

commit:9d69599
author:Frank Bennett
date:2018-02-18 23:04 (JST)

Bump version to m3

commit:2603e8f
author:Frank Bennett
date:2018-02-18 11:50 (JST)

Preload potential abbrevs data in integration.js

commit:a6fc0bb
author:Frank Bennett
date:2018-02-18 11:04 (JST)

Bump mini-version

commit:b0ab85f
author:Frank Bennett
date:2018-02-17 22:44 (JST)

Extend timeout in test fixture

commit:f4fd12b
author:Frank Bennett
date:2018-02-17 22:24 (JST)

Fix embedded items in quickFormat

commit:5a8fa86
author:Frank Bennett
date:2018-02-17 19:35 (JST)

Point at Juris-M get-started page

commit:8c9b931
author:Frank Bennett
date:2018-02-17 19:35 (JST)

Hard-code strings and tweak styling for disabled word processor plugins

commit:63f206c
author:Dan Stillman
date:2018-02-16 20:33 (JST)

This will hopefully be both temporary and rare, so let’s not bother localizing htem.


Add a button in preferences to enable word plugins if some are disabled

commit:628bc53
author:Adomas Venčkauskas
date:2018-02-16 18:37 (JST)

Fix right/left arrow char move in name fields

commit:e32c64c
author:Frank Bennett
date:2018-02-16 12:56 (JST)

Improves citation processing speed

commit:00e52ae
author:Adomas Venčkauskas
date:2018-02-15 19:26 (JST)

Prevents from unnecesarily sending the same citation to citeproc multiple times


Automatically set Referer for external attachment downloads

commit:bb92572
author:Dan Stillman
date:2018-02-15 15:58 (JST)

Rather than requiring translators to explicitly set a referrer, as proposed in #772 and #1375, this simply sets it to the URL where the save button was triggered. This fixes the Project Euclid example in #772. It’s possible it won’t fix all cases, since the translator might build the URL manually or via an intermediate page, but hopefully it will fix the majority of cases.

I guess there’s a possibility that this would break something that currently works, but it’s hard to imagine a site would block based on the wrong referrer from the right site and not block on no referrer.

Unlike #1375, this doesn’t bother with the referrer for native downloads (e.g., snapshots or images). The former probably don’t need it, and the latter should probably be switched to use saveURI() anyway.

This might also fix zotero/translators#523 (SSRN) if the translator allowed it.

Closes #1375


Always show automatic updates option by default

commit:10f9fc9
author:Frank Bennett
date:2018-02-15 16:06 (JST)

Extend timeout. Sync tests still fail locally on Mac, OK under Linux.

commit:0ca0c9b
author:Frank Bennett
date:2018-02-15 10:26 (JST)

Update citeproc-js to 1.1.184

commit:f1b4f8a
author:Frank Bennett
date:2018-02-15 07:12 (JST)

Provide a URL for Juris-M repo services

commit:f9f48c5
author:Frank Bennett
date:2018-02-15 06:50 (JST)

Remember suppress-trailing-punctuation settings

commit:6e0dbde
author:Frank Bennett
date:2018-02-15 06:49 (JST)

New tag selector colors.

commit:081f6bc
author:Sean Takats
date:2018-02-14 21:59 (JST)

Adds 10 more HiDPI itemType icons.

commit:d0aaa71
author:Sean Takats
date:2018-02-14 19:56 (JST)

Update PDF tools version and fix fulltext test

commit:d810dea
author:Martynas Bagdonas
date:2018-02-14 17:43 (JST)

Probably adds HiDPI/Retina icon for thesis.

commit:a8c19b4
author:Sean Takats
date:2018-02-14 17:58 (JST)

Fix loss-of-title-of-type-change bug

commit:2d4624b
author:Frank Bennett
date:2018-02-14 15:52 (JST)

Simplify error logging in translator architecture

commit:942b8b9
author:Dan Stillman
date:2018-02-14 09:22 (JST)

Hopefully the previous stuff is no longer necessary


Make no-results error for search translation available as a property

commit:542584e
author:Dan Stillman
date:2018-02-14 09:05 (JST)

This allows translation-server to return a specific error code when there were no results.

Also clarify the debug logging for search translation.


Fix hang for invalid DOI in translation-server /search

commit:4fdfdd3
author:Dan Stillman
date:2018-02-14 08:26 (JST)

Return “Not Implemented” from server for 501, not “Method Not Implemented”

commit:a937c99
author:Dan Stillman
date:2018-02-14 08:25 (JST)

Fix startup error in new PDF code if application directory is read-only

commit:aedd361
author:Dan Stillman
date:2018-02-12 08:55 (JST)

In Firefox 52, FileUtils.getFile() tries to create the path to the file even if the path array is empty. (In later versions (maybe in 54, which we’re using on macOS) it only does this if more than one path component is provided.) We only need the special directory anyway, so we can just use getDir().


Fix field language setter

commit:44a86f5
author:Frank Bennett
date:2018-02-13 12:06 (JST)

Fix node ID

commit:e04f62b
author:Frank Bennett
date:2018-02-13 12:05 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jm-5.0-dev

commit:c671306
author:Frank Bennett
date:2018-02-12 23:33 (JST)

Expose style in citation plugin, for Abbrevs Filter

commit:13994c1
author:Frank Bennett
date:2018-02-12 22:25 (JST)

Fix citeproc errors upon first interaction with the doc

commit:e72da41
author:Adomas Venčkauskas
date:2018-02-12 18:35 (JST)

Fix noteIndex not being passed to citeproc. Closes #1439

commit:8e2c479
author:Adomas Venčkauskas
date:2018-02-12 17:58 (JST)

Fix jurisdiction and court field UI

commit:e23af88
author:Frank Bennett
date:2018-02-12 17:56 (JST)

Add a pref to always show doc integration automatic updates option

commit:966c293
author:Adomas Venčkauskas
date:2018-02-12 17:47 (JST)

Update translators

commit:e3987ea
author:Frank Bennett
date:2018-02-12 09:04 (JST)

Remove redundant code block

commit:eb64b08
author:Frank Bennett
date:2018-02-12 08:18 (JST)

Fix code misstep resulting from upstream merge

commit:68f4d0c
author:Frank Bennett
date:2018-02-12 08:17 (JST)

Fix “channel is undefined” for invalid HTTP response during WebDAV sync

commit:f04a8c3
author:Dan Stillman
date:2018-02-11 15:03 (JST)

Follow-up to 4bbae6e17

We’re now using Zotero.HTTP.request(), which does its own checking for security errors, so there’s no need to do WebDAV-specific checks (though we could consider checking for Zotero.HTTP.SecurityError and showing more specific messages, since a self-signed certificate is more likely in the case of WebDAV).


Better handling of invalid HTTP responses

commit:4bbae6e
author:Dan Stillman
date:2018-02-11 12:14 (JST)

If a server returns an invalid HTTP response (e.g., Content-Encoding: gzip with a plaintext body, a.k.a. NS_ERROR_INVALID_CONTENT_ENCODING) but we can still parse a 4xx or 5xx HTTP response code, use that for the XHR status, since it might be enough for what we need to do (e.g., verify a 404 from a WebDAV server). This fixes a current problem with Box [1].

Also fix a “msg is not defined” error when the XHR status is 0 but the SSL connection is fine and include the channel and response status on the UnexpectedStatusException object (though both of these would now only happen on an invalid 2xx response, when the XHR status would remain as 0).

[1] https://forums.zotero.org/discussion/comment/301014/#Comment_301014


Use current Zotero source version number

commit:2d8918a
author:Frank Bennett
date:2018-02-11 10:44 (JST)

Update citeproc-js to 1.0.183

commit:2c6ff8c
author:Frank Bennett
date:2018-02-11 10:43 (JST)

Update translators

commit:840b30e
author:Frank Bennett
date:2018-02-11 10:08 (JST)

Locale changes from upstream

commit:f4b5a2f
author:Frank Bennett
date:2018-02-10 23:27 (JST)

Pull changes from upstream master

commit:ac472f5
author:Frank Bennett
date:2018-02-10 23:24 (JST)

Require Administrator users on Windows Cygwin, and use symlinks always

commit:0adac3c
author:Frank Bennett
date:2018-02-10 21:48 (JST)

Add is-admin to node project package

commit:b8443fa
author:Frank Bennett
date:2018-02-10 21:42 (JST)

Fix detection of WebDAV settings changes when clicking Verify Server

commit:1aade0f
author:Dan Stillman
date:2018-02-10 21:26 (JST)

onchange() weirdly isn’t called when clicking off the textbox to a button

Fixes #1291


Adjust version

commit:56d6462
author:Frank Bennett
date:2018-02-10 16:47 (JST)

Fix citation text editor (regression 09ceaa953)

commit:9ed1792
author:Adomas Venčkauskas
date:2018-02-09 22:57 (JST)

Show “More Information…” button on WebDAV SSL cert error

commit:e9a3f9b
author:Dan Stillman
date:2018-02-09 16:35 (JST)

(Though the button takes you to to https://www.zotero.org/support/kb/ssl_certificate_error rather than https://www.zotero.org/support/kb/incomplete_cert_chain, since the error comes from Zotero.HTTP.)


Fix “msg is not defined” on HTTP connection failure

commit:84d8bb4
author:Dan Stillman
date:2018-02-09 16:34 (JST)

Update README.md

commit:552662a
author:Frank Bennett
date:2018-02-09 14:29 (JST)

Provide a mechanism for customizing firefox path for use in tests

commit:9916e0e
author:Frank Bennett
date:2018-02-09 11:18 (JST)

Delete old build-hack file cruft

commit:279d575
author:Frank Bennett
date:2018-02-09 11:05 (JST)

Update locales from Transifex and merge new English strings

commit:ad53b33
author:Dan Stillman
date:2018-02-08 17:23 (JST)

Wait for any DB transactions to finish before starting sync

commit:bd7e1b2
author:Dan Stillman
date:2018-02-08 17:06 (JST)

purgeDataObjects(), which runs at the beginning of the sync process, uses transactions, and those can fail after the default wait timeout if there’s another active transaction. Instead, check explicitly for another transaction and, if there is one, display a nice message and wait for it to finish. This isn’t foolproof, but it should reduce the frequency of “operation timed out” sync errors. (Avoiding all long transactions would be a better solution.)


Fix “Can’t queue event outside of a transaction”

commit:3f6ecc0
author:Dan Stillman
date:2018-02-08 16:07 (JST)

If a transaction took over 30 seconds and another transaction timed out waiting for it, the second transaction would reset the notifier queue, but if the first transaction then tried to queue an event, it would fail with this error and roll back. (It would be nice to figure out why transactions are taking over 30 seconds, though.)


Add sessionID option to translate() that gets passed to the ItemSaver

commit:80cfd60
author:Dan Stillman
date:2018-02-06 15:40 (JST)

This will allow the connector to send a sessionID with a save request.


Support for connector-based save target selection

commit:c8cf9b9
author:Dan Stillman
date:2018-02-06 15:40 (JST)
  • Updates /saveItems and /saveSnapshot to take a sessionID
  • Provides a list of editable collections in the current library
  • Adds an /updateSession method that takes a sessionID and updates the collection and tags of any items saved via that operation (and changes the currently selected collection)

Cross-library changes are not yet supported


Remove fail() override in Mocha

commit:4731b8f
author:Dan Stillman
date:2018-02-06 15:25 (JST)

I’m not sure what this was for, but at least with an async test function it seems to be causing spurious “the string ‘x’ was thrown, throw an Error :)” messages that hide the real error.


Reset PDF tools path for tests in resetDB()

commit:45ddf98
author:Dan Stillman
date:2018-02-06 13:09 (JST)

And include path on error when running PDF tool


Use rowid to clean invalid entries from translatorCache

commit:06fb74a
author:Dan Stillman
date:2018-02-07 13:45 (JST)

Since in truly weird cases [1] fileName might not exist

https://forums.zotero.org/discussion/comment/300558/#Comment_300558


Amend comment regarding citationsByIndex keys sort order

commit:46854b6
author:Adomas Venčkauskas
date:2018-02-06 23:08 (JST)

Fix field type changes triggering citation modified prompts

commit:4add3ec
author:Adomas Venčkauskas
date:2018-02-06 22:19 (JST)

Fix some more citation update bugs

commit:09ceaa9
author:Adomas Venčkauskas
date:2018-02-06 22:09 (JST)

Remove LibreOffice specific setText() calls (addressed within plugin)

commit:edc18a4
author:Adomas Venčkauskas
date:2018-02-02 23:00 (JST)

Update submodules

commit:d50adec
author:Frank Bennett
date:2018-02-05 20:40 (JST)

Use the right port number in test

commit:86e21c2
author:Frank Bennett
date:2018-02-05 20:12 (JST)

Use later version of chai.js

commit:5b3b9b7
author:Frank Bennett
date:2018-02-05 20:12 (JST)

Be fussy about math symbolx in PDF text dump

commit:778d8b6
author:Frank Bennett
date:2018-02-05 16:36 (JST)

Adapt test to Juris-M

commit:6d80075
author:Frank Bennett
date:2018-02-05 11:13 (JST)

Fix JM coding error

commit:5442b91
author:Frank Bennett
date:2018-02-05 10:26 (JST)

Fix JM syntax error

commit:beccfad
author:Frank Bennett
date:2018-02-05 10:25 (JST)

Locales from upstream master

commit:228d1c7
author:Frank Bennett
date:2018-02-05 09:51 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jm-5-dev

commit:f274989
author:Frank Bennett
date:2018-02-05 08:17 (JST)

Allow dragging parent items to collection if children are selected

commit:38411fb
author:Dan Stillman
date:2018-02-03 18:09 (JST)

This is a simplified version of the fix from #872. Unlike the proposal in #36, this doesn’t require all child items to be selected, since in a search some children might be grayed out. If the child of an unselected parent item is included, the drag isn’t allowed.

Closes #36


Allow parentItemID as a createDataObject() parameter in tests

commit:ad216bc
author:Dan Stillman
date:2018-02-03 18:14 (JST)

Not just parentID


Fix citation preview citeproc error. Closes #1430

commit:948a4dd
author:Adomas Venčkauskas
date:2018-01-31 21:13 (JST)

Fix slow display of citation dialog on first interaction with doc

commit:97a045f
author:Adomas Venčkauskas
date:2018-01-31 19:59 (JST)

Use temp directory for recognizePDFCache.txt

commit:b7a24a5
author:Dan Stillman
date:2018-01-31 19:34 (JST)

Fix “Retrieve Metadata for PDF” with bundled PDF tools

commit:31f0f0d
author:Dan Stillman
date:2018-01-31 19:34 (JST)

Reduce minimum width of Zotero pane to 670px

commit:2d43518
author:Dan Stillman
date:2018-01-31 09:12 (JST)

We could potentially do more, but this is the narrowest the pane can be with the left pane collapsed without starting to hide toolbar icons, so let’s try this. (This will still hide the sync icon if the left pane isn’t collapsed.)

Closes #675 Closes #1183


Don’t show Title in column picker, because hiding it doesn’t make sense

commit:e4a3996
author:Dan Stillman
date:2018-01-31 09:11 (JST)

Update locales from Transifex

commit:2219bd9
author:Dan Stillman
date:2018-01-30 07:38 (JST)

Update submodules

commit:eca9d82
author:Dan Stillman
date:2018-01-30 07:22 (JST)

Update citeproc-js to 1.1.183

commit:4a41f21
author:Dan Stillman
date:2018-01-30 07:21 (JST)

Fix test breakage from d67c6542451

commit:5b46735
author:Dan Stillman
date:2018-01-26 18:23 (JST)

Prompt to reset local group files on 403 for file attachment upload

commit:c5fa130
author:Dan Stillman
date:2018-01-26 17:36 (JST)

And reset modified file attachments when resetting files


Add version option to toResponseJSON()

commit:d67c654
author:Dan Stillman
date:2018-01-26 17:33 (JST)

Warn about version 0 when saving to sync cache

commit:3390f24
author:Dan Stillman
date:2018-01-26 17:32 (JST)

This should be an error, because the API will never return 0, but most tests don’t currently set the version properly in the response JSON.


Fix integration test errors. Closes #1426

commit:d857a81
author:Adomas Venčkauskas
date:2018-01-25 19:48 (JST)

Fixes index is not defined error. Closes #1422

commit:fe4b757
author:Adomas Venčkauskas
date:2018-01-25 19:39 (JST)

Fix slow citation dialog initialization

commit:2523bca
author:Adomas Venčkauskas
date:2018-01-24 23:03 (JST)

Report: https://forums.zotero.org/discussion/69929/beta-delay-citation-feature


Fix footnote edit crashing in MacWord

commit:8544618
author:Adomas Venčkauskas
date:2018-01-24 23:00 (JST)

Checkin to test Travis

commit:ed95699
author:Frank Bennett
date:2018-01-24 22:14 (JST)

Enable 2x PDF icon

commit:0bb0912
author:Dan Stillman
date:2018-01-24 20:15 (JST)

Fix an integration error when bibl present without citations

commit:d41c8d6
author:Adomas Venčkauskas
date:2018-01-22 20:26 (JST)

Fix ‘id must be a positive integer’ integration error

commit:553d2b0
author:Adomas Venčkauskas
date:2018-01-22 20:25 (JST)

Report: https://forums.zotero.org/discussion/comment/298804#Comment_298804


Run deploys from Travis on

*-hotfix branches

commit:a1b6f07
author:Dan Stillman
date:2018-01-20 13:46 (JST)

Fix startup hang if note is null in database

commit:2194dff
author:Dan Stillman
date:2018-01-20 02:57 (JST)

Merge pull request #1417 from mrtcode/pdftools-test

commit:ca9a7c6
author:Dan Stillman
date:2018-01-19 09:24 (JST)

Fix PDF tools usage in tests


Cache PDF tools in the source directory between test runs

commit:37eb597
author:Dan Stillman
date:2018-01-19 09:20 (JST)

This avoids having to download a 13 MB file on every test run.


Fix Zotero.Fulltext.setItemContent() test

commit:db2ddfd
author:Dan Stillman
date:2018-01-19 08:53 (JST)

Fix Zotero.Fulltext tests

commit:723b4d3
author:Martynas Bagdonas
date:2018-01-18 23:48 (JST)

Fix PDF tools usage in tests

commit:5815088
author:Martynas Bagdonas
date:2018-01-18 19:23 (JST)

Merge pull request #1415 from mrtcode/pdftools

commit:5d39221
author:Dan Stillman
date:2018-01-18 14:20 (JST)

Bundled PDF tools


Deleted strings that are no longer in use

commit:77ffc6a
author:Martynas Bagdonas
date:2018-01-16 02:52 (JST)

Use the bundled PDF tools

commit:0d5ea85
author:Martynas Bagdonas
date:2018-01-16 02:09 (JST)

Update translators

commit:e3dee4d
author:Dan Stillman
date:2018-01-17 15:15 (JST)

Update version

commit:9a9a4bf
author:Dan Stillman
date:2018-01-17 15:14 (JST)

Update locales from Transifex and merge new English strings

commit:d662a82
author:Dan Stillman
date:2018-01-17 03:25 (JST)

Add missing spinners from 87cf336e2

commit:48757f0
author:Dan Stillman
date:2018-01-17 02:52 (JST)

Tweak padding in doc prefs

commit:17d4515
author:Dan Stillman
date:2018-01-17 02:42 (JST)

Tweak wording of delayed-citations mode

commit:e4cc28a
author:Dan Stillman
date:2018-01-17 02:36 (JST)

“Delay citation updates until manual refresh” would be fine in the doc prefs, but “until manual refresh” is a bit too awkward for the prompt. Instead, go with @rmzelle’s suggestion from #1242 of referring to “automatic citation updates”, and invert the checkbox.


Fix translator architecture hangs on bad JSON in translatorCache

commit:cc9efde
author:Dan Stillman
date:2018-01-17 01:04 (JST)

Start sync icon spinning before purging data

commit:2b8311d
author:Dan Stillman
date:2018-01-15 17:22 (JST)

Merge pull request #1242 from adomasven/feature/delay-updating-citatations

commit:0cd50b5
author:Dan Stillman
date:2018-01-16 23:11 (JST)

Refactor integration and delay citation updates


Refresh citation text upon citation insertion

commit:2b27e40
author:Adomas Venčkauskas
date:2018-01-16 20:55 (JST)

Ensure delayed citation styling is removed upon proper update

commit:b985ef8
author:Adomas Venčkauskas
date:2017-12-12 21:21 (JST)

Ensure delayed citation styling is removed upon proper update


Update locales from Transifex

commit:fec3fa2
author:Dan Stillman
date:2018-01-12 10:23 (JST)

Update submodules

commit:09fc3c2
author:Dan Stillman
date:2018-01-12 10:19 (JST)

Automatically rename dragged file attachments from parent metadata

commit:7cb95f4
author:Dan Stillman
date:2018-01-10 14:39 (JST)

Rename happens if only one file is dragged and the parent item has no existing file attachments.

Closes #1405


Add spacing between icon and search field in Quick Format window

commit:ea2fead
author:Dan Stillman
date:2018-01-08 15:08 (JST)

Cancel active Quick Format search if another one starts

commit:87cf336
author:Dan Stillman
date:2018-01-08 15:05 (JST)

This fixes inconsistent results (#1349) from async searches finishing out of order.

Also adds spinner when search is active


Blacklist spurious warnings about word processor plugin update manifests

commit:7d41047
author:Dan Stillman
date:2018-01-08 14:01 (JST)

Increase save time for Accessed test for Travis

commit:c83de8a
author:Dan Stillman
date:2018-01-05 20:04 (JST)

Allow “now” in Accessed field to use current time

commit:3f6ef7f
author:Dan Stillman
date:2018-01-05 17:40 (JST)

Closes #1340


Add schema update step to remove dc:isReplacedBy relations

commit:5847388
author:Dan Stillman
date:2018-01-05 16:53 (JST)

These should’ve all been replaced with dc:replaces relations in a schema update step, so any that exist were likely synced down from the API (since fixed) and should be obsolete/redundant.


Add “Publication” to top level of search condition drop-down

commit:4ac368e
author:Dan Stillman
date:2018-01-05 12:59 (JST)

Clear parentKey change marker after save

commit:fdb9e20
author:Dan Stillman
date:2018-01-05 09:10 (JST)

Fixes #1325, Field editor closes during auto-sync of newly created parent item


Pause the document update timer during warning dialogs

commit:4b78ebc
author:Adomas Venčkauskas
date:2017-12-06 19:00 (JST)

Simplify field handling

commit:47744e4
author:Adomas Venčkauskas
date:2017-12-06 18:41 (JST)

Don’t use field.writeToDoc(), because it prevents from optimizing libreoffice text writes


Add session.getItems in preparation for document collections

commit:2ad0dc0
author:Adomas Venčkauskas
date:2017-10-16 20:05 (JST)

Display a refresh notice instead of bibliography when citing delayed

commit:f8f403e
author:Adomas Venčkauskas
date:2017-08-29 22:01 (JST)

Option to delay updating citation in document.

commit:2827f70
author:Adomas Venčkauskas
date:2017-06-06 18:07 (JST)

The checkbox in doc prefs is hidden until an update takes 5s or longer after which the user is prompted to enable delaying.


Add more integration tests

commit:6d05c34
author:Adomas Venčkauskas
date:2017-06-01 19:03 (JST)

Integration refactor megacommit

commit:5805c7e
author:Adomas Venčkauskas
date:2017-05-30 21:55 (JST)
  • Removed obsolete logic for citation.properties.deleted, which is no longer set anywhere
  • Introduced a bibliography class
  • BibliographyEditInterface no longer edits state
  • Fields._processFields() now has linear flow because:
  • Exception handling for missing items and corrupt fields reworked to be handled in relevant Field classes, so that the flow remains linear
  • Document modifying functions (i.e. Fields.updateDocument()) now only called in Zotero.Integration.Interface functions instead of all over the place
  • document.setDocPrefs() now called after every execCommand() since the cost is trivial, but that simplifies a bunch of logic
  • Misc code cleanup

TODO at some point in the future: - Move Integration.(init/delete)Pipe out - Decouple references and clarify functions in Integration.Fields and

Integration.Session

Add Zotero.Integration.Citation

commit:f44d563
author:Adomas Venčkauskas
date:2017-05-25 16:48 (JST)
  • Moves a bunch of citation related processing from Integration.Session
  • Replaces missing item handling with a function instead of exception
  • Solves some really confusing flow issues in _processFields

Make current session globally available

commit:a1acbd4
author:Adomas Venčkauskas
date:2017-05-24 17:54 (JST)

Decoupling! Sessions can be instantiated without Zotero.Integration.Interface


Fix bugs for style-switching and footnote citations

commit:54b4ec6
author:Adomas Venčkauskas
date:2017-05-23 21:21 (JST)

Refactor CitationEditInterface

commit:4159c63
author:Adomas Venčkauskas
date:2017-05-23 20:31 (JST)

This is the first really big change that detangles UI stuff from directly changing state. io.citation is no longer tied to the citation loaded in the session in any way and CitationEditInterface does not write anything to session or document. All writes are handled in Fields.addEditCitation()


Move citation unserialization

commit:41db61e
author:Adomas Venčkauskas
date:2017-05-17 23:12 (JST)

Using new es6 class syntax because getters/setters don’t retain this context with Zotero.extendClass and we’re building with at least FX45 on every platform now where the syntax is supported


Add a wrapper class for citation and bibliography fields

commit:52fd0d9
author:Adomas Venčkauskas
date:2017-05-17 23:15 (JST)

Rename Integration.Document to Integration.Interface

commit:41c93ab
author:Adomas Venčkauskas
date:2017-05-16 00:19 (JST)

Remove integration plugin version checks

commit:18e4e37
author:Adomas Venčkauskas
date:2017-05-05 23:57 (JST)

Moves utilities code away from Zotero.Integration

commit:430f58d
author:Adomas Venčkauskas
date:2017-05-05 23:51 (JST)

Don’t close clicked field when clicking away from changed field

commit:2baa537
author:Dan Stillman
date:2018-01-03 16:33 (JST)

Fixes #1401

The item box badly wants to be redone in React.


Additional try/catch to fix NS_ERROR_UNEXPECTED from tree select

commit:374eefa
author:Dan Stillman
date:2018-01-03 10:17 (JST)

Follow-up to 7cd1439928


Add attr()/text() to translator sandbox

commit:2bc44dd
author:Dan Stillman
date:2017-12-28 08:18 (JST)

The current document is automatically used (but can still be provided as the first argument to avoid accidental bugs during the transition).

Closes #1323 Addresses zotero/translators#1277


Update locales from Transifex

commit:5350931
author:Dan Stillman
date:2017-12-28 07:07 (JST)

Fix undo in notes to not restore changes from another note

commit:c4fde7e
author:Dan Stillman
date:2017-12-28 06:49 (JST)

Fixes #1398


Bump version

commit:b354293
author:Frank Bennett
date:2017-12-22 09:33 (JST)

Update locales from Transifex

commit:5fcac10
author:Dan Stillman
date:2017-12-21 11:42 (JST)

Fix deletion of tags across libraries

commit:a1c96f1
author:Dan Stillman
date:2017-12-21 10:37 (JST)

https://forums.zotero.org/discussion/comment/296384/#Comment_296384


Update version

commit:b1b9dcf
author:Dan Stillman
date:2017-12-21 10:38 (JST)

Update version

commit:22d3fbb
author:Dan Stillman
date:2017-12-20 05:59 (JST)

Hopefully fix intermittently broken items pane

commit:7cd1439
author:Dan Stillman
date:2017-12-18 16:55 (JST)

https://forums.zotero.org/discussion/69226/papers-become-invisible-in-the-middle-pane

I can’t reproduce this, but it seems like if the tree disappears (due to a collection change?) while the tree is refreshing, the toggleSelect() in the rememberSelection() call can fail and break the tree.


Fix some UI issues with storage settings

commit:fa33eb7
author:Dan Stillman
date:2017-12-18 14:34 (JST)
  • Enable/disable download mode drop-down for groups separately from user library
  • Fixing hiding of terms of service message when Zotero storage isn’t selected

Update version

commit:7d98f04
author:Dan Stillman
date:2017-12-15 16:29 (JST)

Open /start on first-run instead of /start_standalone

commit:545c800
author:Dan Stillman
date:2017-12-15 14:14 (JST)

Closes #1389


Disable “Check Database Integrity” button while running

commit:6acf208
author:Dan Stillman
date:2017-12-15 13:49 (JST)

Update locales from Transifex

commit:a85ea18
author:Dan Stillman
date:2017-12-15 13:31 (JST)

Log skipped libraries

commit:0ad4393
author:Dan Stillman
date:2017-12-15 13:20 (JST)

Fix type in report.js

commit:f913e7a
author:Frank Bennett
date:2017-12-14 16:29 (JST)

Add missing yield statement

commit:19c5659
author:Frank Bennett
date:2017-12-14 16:28 (JST)

Use numbered placeholders for new localized strings

commit:1a46196
author:Dan Stillman
date:2017-12-14 16:18 (JST)

Update submodules

commit:90d948a
author:Dan Stillman
date:2017-12-14 11:33 (JST)

Update locales from Transifex

commit:aefeb1f
author:Dan Stillman
date:2017-12-14 11:05 (JST)

Fix cursor reset while typing in attachment notes

commit:05eb3a3
author:Dan Stillman
date:2017-12-12 17:31 (JST)

If you started typing just as auto-save was kicking in (i.e., 1 second after stopping typing), any additional characters could be removed and the cursor could jump back to the beginning of the note.

Fixes #1336, probably


Wrap URLs and DOIs in HTML output

commit:8f5903f
author:Dan Stillman
date:2017-12-12 13:24 (JST)

Closes #1387


Update citeproc-js to 1.1.182

commit:9ca4089
author:Dan Stillman
date:2017-12-12 07:34 (JST)

Tweak a couple font sizes in Sync -> Reset pane

commit:392687f
author:Dan Stillman
date:2017-12-12 07:34 (JST)

Updates locales from Transifex and merge new English strings

commit:341d4f1
author:Dan Stillman
date:2017-12-11 17:58 (JST)

Fix auto-focusing of notes in external window

commit:6051c24
author:Dan Stillman
date:2017-12-11 16:39 (JST)

Don’t show note in right-hand pane when editing in separate window

commit:dcfaa55
author:Dan Stillman
date:2017-12-11 16:23 (JST)
  • When a child note is opened in a separate window, the parent window is selected. (This used to work but was broken in 5.0.)
  • When a top-level note is opened (via double-click), the right-hand pane changes to show “Editing in separate window”.
  • If a note that’s currently open in a separate window is clicked on, the right-hand pane shows “Editing in a separate window”.
  • If a note window is closed and the item is selected, the note editor reappears in the right-hand pane after the note is saved.

This will avoid unnecessary UI updates and data loss bugs from the two notes getting out of sync (and is just generally cleaner).

Also:

  • General cleanup of note display code

Prevent Add Item by Identifier button from flashing on textbox click

commit:b2c9a42
author:Dan Stillman
date:2017-12-11 13:15 (JST)

Nesting the panel in the toolbarbutton seems to cause the button to appear as if it were clicked on any click/right-click in the textbox, and I couldn’t find a way to prevent that with event.stopPropagation().

Also cleans up this code in general


Fix context-menu paste into Add Item by Identifier

commit:383f8d2
author:Dan Stillman
date:2017-12-11 07:20 (JST)

The context menu was triggering onpopuphidden, which was clearing the textbox.


Avoid upload retry loops

commit:df38f4d
author:Dan Stillman
date:2017-12-10 17:26 (JST)
  • Don’t try uploading an object more than 5 times
  • Don’t retry a child item if the parent item failed too

Update Node packages

commit:c176959
author:Dan Stillman
date:2017-12-10 17:15 (JST)

Select text in search bar when using Find menu option (or shortcut)

commit:c723e1e
author:Dan Stillman
date:2017-12-10 16:21 (JST)

https://forums.zotero.org/discussion/69305


API-based “Restore to Online Library”

commit:f353b7c
author:Dan Stillman
date:2017-12-08 14:27 (JST)

Restores the “Restore to Zotero Server” functionality, now using the API:

  1. Get all remote keys and send DELETE for any that don’t exist locally.
  2. Upload all local objects in full (non-patch) mode using only library version so that the remotes are overwritten.
  3. Reset file sync history, causing all files to be uploaded (or, more likely, reassociated with existing remote files).

Since these are treated as regular updates on the server, they’ll sync down to other clients normally. Unsynced changes by other clients might still trigger conflicts.

This and Reset File Sync History can also now be run on group libraries, with a library selector in the Reset pane (which I forgot to do with React).

The full sync option is now removed from the Reset pane, since there wasn’t ever really a reason to run it manually.

We should be able to reimplement Restore from Online Library (#1386) using the inverse of this approach.

Closes #914


Add comment regarding strToDate()’s month handling in retrieveItem()

commit:885ed60
author:Dan Stillman
date:2017-12-08 14:14 (JST)

Don’t compress uploaded data in tests

commit:da1dd75
author:Dan Stillman
date:2017-12-08 14:10 (JST)

It would be better to handle this automatically in Sinon, but as it is uploads are compressed if they’re bigger than an arbitrary limit, which can break tests unexpectedly if they check req.requestBody.


Avoid deprecation warning in recognizePDF

commit:e01cb38
author:Dan Stillman
date:2017-12-08 14:10 (JST)

Show file path instead of “(null)” when installing style via file open

commit:9a43b53
author:Dan Stillman
date:2017-12-08 14:04 (JST)

And fix deprecation warning from passing an nsIFile

(Also updates the Zotero.Styles.install() documentation to note that the first parameter’s file property can be a string path.)


Add utility functions for building drop-down library lists

commit:045f1fb
author:Dan Stillman
date:2017-12-08 14:01 (JST)

A XUL one for the current use in Advanced Search and an HTML one for future uses. Sets the value to libraryID and adds data attributes for editable/filesEditable on the HTML one.


Update version

commit:36436d0
author:Dan Stillman
date:2017-12-04 08:05 (JST)

Update locales from Transifex

commit:816fb52
author:Dan Stillman
date:2017-12-04 05:24 (JST)

Update submodules

commit:8f98398
author:Dan Stillman
date:2017-12-04 05:20 (JST)

Show friendlier error on setDates() failure during file sync download

commit:4c337e5
author:Dan Stillman
date:2017-12-02 18:14 (JST)

Clear Windows read-only attribute when storing file

commit:6941f96
author:Dan Stillman
date:2017-12-02 18:11 (JST)

Fix “Access is denied” file sync error with read-only files

commit:c3df3fc
author:Dan Stillman
date:2017-12-02 17:57 (JST)

If the read-only file is set on a file in the ‘storage’ directory, it’s added to the ZIP for snapshot/WebDAV syncing, and when extracted the setDates() call was failing. This clears the read-only attribute (and system and hidden) when extracting all files.


Missed image files for 2x grippy dimples from 640846961a

commit:2c47b64
author:Dan Stillman
date:2017-12-02 15:51 (JST)

Fix sync error after resetting read-only group

commit:cdaf73b
author:Dan Stillman
date:2017-12-02 15:35 (JST)

If an item needed to be erased, it would fail with “Cannot edit item in read-only library”, because the deletion didn’t skip the edit check.


2x grippy dimple

commit:6408469
author:Dan Stillman
date:2017-12-02 03:09 (JST)

Update citeproc-js to 1.1.181

commit:fb74fe7
author:Dan Stillman
date:2017-12-01 16:10 (JST)

Show sync error about embedded images in notes for attachment notes too

commit:b397ee2
author:Dan Stillman
date:2017-12-01 13:50 (JST)

Clone feed items if translation returns no items. Closes #1377

commit:6970556
author:Adomas Venčkauskas
date:2017-11-30 18:39 (JST)

Don’t show Firefox profile access message on empty ‘zotero’ dir

commit:9b9af65
author:Dan Stillman
date:2017-11-29 17:57 (JST)

But maybe do show in cases where it didn’t show before, since we were using exists(), which can return false for inaccessible directories.


Fix localized sorting of creator types

commit:e2eef77
author:Dan Stillman
date:2017-11-29 14:28 (JST)

Don’t just rely on “Author” being first


Fix error selecting item with item type without creator types

commit:76b96a8
author:Dan Stillman
date:2017-11-29 13:22 (JST)

https://forums.zotero.org/discussion/69118/


Update version

commit:d5dd5c5
author:Dan Stillman
date:2017-11-29 04:17 (JST)

Update submodules

commit:bbad56a
author:Dan Stillman
date:2017-11-28 09:55 (JST)

Update locales from Transifex

commit:45b0c3a
author:Dan Stillman
date:2017-11-28 09:54 (JST)

Skip auto-sync on stream notification if library version is up to date

commit:5759689
author:Dan Stillman
date:2017-11-28 09:46 (JST)

This avoids an extra no-op sync after an upload when the notification for the change comes back down from the streaming server.


Simplify quick search handling in itemTreeView notify()

commit:baeb846
author:Dan Stillman
date:2017-11-28 09:46 (JST)

Avoid logged deprecation warning in external note editor

commit:7bbb4a8
author:Dan Stillman
date:2017-11-28 09:45 (JST)

Restore use of beginUpdateBatch/endUpdateBatch in itemTreeView notify()

commit:202192b
author:Dan Stillman
date:2017-11-28 09:43 (JST)

Not sure why this was disabled, but it prevents flashing of child items when a child item is modified.


Avoid unnecessary item map refreshes during sorting

commit:ae21b31
author:Dan Stillman
date:2017-11-28 07:32 (JST)

Filter stack in debug output when using debug.stackTrace pref

commit:a854ce9
author:Dan Stillman
date:2017-11-28 07:31 (JST)

Don’t start transaction to clear search temp table

commit:a70a517
author:Dan Stillman
date:2017-11-28 07:29 (JST)

This might fix loss of item focus when editing a note in a search, possibly starting with fbf2fbe0c6.


Temporarily restore double text setting in LibreOffice for footnotes

commit:da38787
author:Adomas Venčkauskas
date:2017-11-28 00:24 (JST)

Regressions from 921b21c3. Footnotes in LibreOffice lose styling


Update version

commit:8178307
author:Dan Stillman
date:2017-11-22 18:39 (JST)

Fix sync error if item with no content type somehow was indexed

commit:8241149
author:Dan Stillman
date:2017-11-22 18:22 (JST)

https://forums.zotero.org/discussion/68954/mimetype-is-undefined-error

Not sure how this could happen.


Merge locales from Transifex

commit:d45a9c2
author:Dan Stillman
date:2017-11-22 17:18 (JST)

Localize “Verify Server”

commit:dfea8b5
author:Dan Stillman
date:2017-11-22 06:58 (JST)

Update submodules

commit:d4ae63f
author:Dan Stillman
date:2017-11-22 12:24 (JST)

Check for lost legacy data directory after migration

commit:4a6922b
author:Dan Stillman
date:2017-11-22 12:21 (JST)

The check only does anything if we’re using the default location, and otherwise if we migrate the wrong directory (say, because somebody opened Standalone 4.0 before upgrading to 5.0) we won’t prompt until the next restart.


Remove the additional setText() call for libreoffice plugin

commit:921b21c
author:Adomas Venčkauskas
date:2017-11-16 19:54 (JST)

Possible since zotero/zotero-libreoffice-integration@2deea6bd46b50f72cdc937a468e88ab6cd4461ad


Don’t send inPublications=false in ‘full’ mode for group items

commit:88a6e4f
author:Dan Stillman
date:2017-11-21 06:27 (JST)

Skip migration on error checking whether dataDir is on different drive

commit:f0b7a21
author:Dan Stillman
date:2017-11-21 01:38 (JST)

Remove ellipses from toolbar button labels

commit:f546fbd
author:Dan Stillman
date:2017-11-20 11:50 (JST)

Update locales from Transifex

commit:d072c62
author:Dan Stillman
date:2017-11-20 11:33 (JST)

Update version

commit:bdd9bfd
author:Dan Stillman
date:2017-11-18 13:24 (JST)

Check for Firefox profile access at startup and show warning

commit:10a5d8d
author:Dan Stillman
date:2017-11-18 12:36 (JST)

f40b7ae6ac didn’t help with people who’ve already upgraded, so check at startup and show a warning if the profile is inaccessible until 1) the profile has been accessed once or 2) the user checks “Don’t show again” in the warning dialog.

Also fix Zotero.Profile.getDefaultInProfilesDir() to properly throw an error if it can’t access the default directory.


Update version

commit:8f42a3c
author:Dan Stillman
date:2017-11-17 23:38 (JST)

Update submodules

commit:48928de
author:Dan Stillman
date:2017-11-17 23:37 (JST)

Show warning on Firefox profile access error after installation

commit:f40b7ae
author:Dan Stillman
date:2017-11-17 23:29 (JST)

https://www.zotero.org/support/kb/data_missing_after_zotero_5_upgrade


Reduce spacing in collection pane on Linux. Closes #1369

commit:9bf4bac
author:Adomas Venčkauskas
date:2017-11-17 20:17 (JST)

The collections pane height change in bf36a98 made the linux collection pane vertical spacing very big. This resets it to previous spacing


More complete fix for invalid creator row error at startup

commit:04a730d
author:Dan Stillman
date:2017-11-17 16:55 (JST)

Follow-up to 7d3311679e


Add creator fix to integrity check, and run at startup if necessary

commit:7d33116
author:Dan Stillman
date:2017-11-16 20:43 (JST)

Fix DB integrity check when there’s only one of a given problem

commit:1cb49cc
author:Dan Stillman
date:2017-11-16 19:54 (JST)

Add Zotero.getStringFromBundle()

commit:810e0a3
author:Dan Stillman
date:2017-11-16 15:18 (JST)

The same as Zotero.getString(), but takes an nsIStringBundle as the first parameter. Extensions could use this to get the same getString() features with their own properties files.


Don’t ignore whitespace when sorting

commit:c7fd46e
author:Dan Stillman
date:2017-11-16 15:15 (JST)

Intl.Collator’s ignorePunctuation ignores whitespace too, so stop using it, since it produces much weirder results than sorting on punctuation does.


Update version

commit:3c2bcf0
author:Dan Stillman
date:2017-11-16 15:17 (JST)

Update submodules

commit:20ad57a
author:Dan Stillman
date:2017-11-13 08:46 (JST)

Update locales from Transifex

commit:cd90cfd
author:Dan Stillman
date:2017-11-13 08:46 (JST)

Fix extremely slow tag query with some SQLite databases

commit:fbf2fbe
author:Dan Stillman
date:2017-11-11 16:56 (JST)

Reverts a80f13099, “Avoid temporary table when getting tags for current view”, fixes a couple things, and removes the unused Zotero.Tags.getAllWithinSearch().

Fixes #1290


Don’t send translator error from connectors reports in private-browsing mode

commit:08eefea
author:Adomas Venčkauskas
date:2017-11-10 18:10 (JST)

Fix HTTP breakage in bb1cbdff269

commit:6b03124
author:Dan Stillman
date:2017-11-08 16:18 (JST)

Add test for short DOI parsing

commit:bbb6434
author:Dan Stillman
date:2017-11-08 06:53 (JST)

Follow-up to #1356


Fix responseCharset parameter in HTTP methods

commit:bb1cbdf
author:Dan Stillman
date:2017-11-08 06:51 (JST)

Setting contentCharset on the channel doesn’t seem to work anymore, so use overrideMimeType() instead like we do in the connector. As noted in the comment, we should probably have a responseContentType parameter instead, since that’s what XHR actually allows. For the moment we just use text/plain.


Support short DOIs in cleanDOI() and update DOI copyAsURL prefix (#1356)

commit:e935001
author:bwiernik
date:2017-11-08 06:48 (JST)

Add cleanDOI() tests

commit:01c71fd
author:Dan Stillman
date:2017-11-08 05:27 (JST)

In advance of #1356

We’re not properly handling DOIs in parentheses or brackets (which would require non-regex logic), so those tests are skipped for now.


Save to current collection from /connectors/savePage.

commit:24507a7
author:Adomas Venčkauskas
date:2017-11-06 19:57 (JST)

Closes #1351


Ignore translator browserSupport in connectors except bookmarklet

commit:8012829
author:Adomas Venčkauskas
date:2017-11-06 19:35 (JST)

Addresses zotero/zotero-connectors#197


Update to citeproc-js 1.1.80

commit:1617591
author:Dan Stillman
date:2017-11-05 16:23 (JST)

Fix test after a3e711b7b5

commit:0bf546a
author:Dan Stillman
date:2017-11-03 17:47 (JST)

Fix feed item read shortcut, and delay 1 second before marking as read

commit:a3e711b
author:Dan Stillman
date:2017-11-03 17:36 (JST)

This allows keyboard navigation without marking all items in between as read.


Add 2x version of creator type menu dropboxmarker

commit:c40e321
author:Dan Stillman
date:2017-11-02 03:41 (JST)

Fix “Rename File from Parent Metadata” if target filename exists

commit:0f743e5
author:Dan Stillman
date:2017-11-01 14:02 (JST)

Add a unique numeric suffix to the filename, before any extension


Remove unused Babel syntax plugins

commit:c784db8
author:Dan Stillman
date:2017-11-01 11:33 (JST)

Specify Node.js 8 for Travis, since current is now 9.0.0

commit:37521b6
author:Dan Stillman
date:2017-11-01 11:17 (JST)

Don’t return unparsed Mac persistent descriptor from Item.getFilePath()

commit:14ecf88
author:Dan Stillman
date:2017-11-01 11:03 (JST)

And auto-convert to path, not filename


Update version

commit:4137a61
author:Dan Stillman
date:2017-10-31 15:22 (JST)

Fix date parsing from Atom feeds

commit:676ab78
author:Dan Stillman
date:2017-10-31 15:14 (JST)

Use Atom namespace when getting fields, and use <updated> date before <published>. (The dates are also available on the nsIFeedContainer (feedEntry), but we’re getting them directly from the fields for some reason.)


Fix logged error clicking below list in “Choose Libraries…” window

commit:6150a08
author:Dan Stillman
date:2017-10-31 05:02 (JST)

Activate “Set Up Syncing” button on context-menu paste or drag and drop

commit:33bf3b2
author:Dan Stillman
date:2017-10-28 09:22 (JST)

Fix file conflict resolution after f0770fa84d

commit:196e45c
author:Dan Stillman
date:2017-10-27 17:07 (JST)

merge.xul now returns an object with .data and .selected instead of returning .data directly


Fix -s and -e arguments for test runner

commit:2184952
author:Dan Stillman
date:2017-10-27 17:03 (JST)

Fix some property access issues

commit:e22d7a8
author:Dan Stillman
date:2017-10-27 16:21 (JST)
  • Return undefined instead of throwing an error trying to access libraryTypeID on a Zotero.Feed – this fixes a test failure with the latest Chai, which annoyingly runs inspect() on an object passed to .include() regardless of whether the test succeeds
  • Make some deprecated properties non-enumerable to avoid unnecessary logging when the object is dumped

Update chai-as-promised after chai update

commit:241df13
author:Dan Stillman
date:2017-10-27 14:34 (JST)

(Though we should mostly just use async/await)


Don’t try to delete Quick Start Guide items in test

commit:34028d3
author:Dan Stillman
date:2017-10-27 14:09 (JST)

We don’t create these items anymore.


Bail on auto-build failure when running tests

commit:15942b9
author:Dan Stillman
date:2017-10-27 14:08 (JST)

Fix various conflict resolution bugs

commit:f0770fa
author:Dan Stillman
date:2017-10-27 14:07 (JST)

Among other things, when choosing the local side for a conflict, the remote version could still end up being saved.


Update chai to 4.1.2

commit:7f8699b
author:Dan Stillman
date:2017-10-27 14:08 (JST)

Fix possible skipped group download when another group is archived

commit:5901a3c
author:Dan Stillman
date:2017-10-27 08:04 (JST)

Fix potential restart error switching to first note of session

commit:14f4021
author:Dan Stillman
date:2017-10-26 14:22 (JST)

Fall back to en-US sorting if we can’t parse the locale

commit:1deba23
author:Dan Stillman
date:2017-10-26 13:54 (JST)

Update submodules

commit:56289b6
author:Dan Stillman
date:2017-10-26 12:56 (JST)

Update locales from Transifex

commit:7de192c
author:Dan Stillman
date:2017-10-26 12:55 (JST)

Additional debugging for group sync issue

commit:d08db42
author:Dan Stillman
date:2017-10-26 12:51 (JST)

https://forums.zotero.org/discussion/68299/group-library-not-showing-up-report-id-198634382


Fix items list problems when adding item with a search entered

commit:73d8842
author:Dan Stillman
date:2017-10-24 17:54 (JST)

When an item is created, an active quick search is cleared, but that’s now an async operation. We weren’t waiting for that, which meant that new items weren’t selected and depending on a race condition could even show the welcome pane despite there being items in the library.


Fix “item._changed.creators is undefined” error at startup

commit:1a779bb
author:Dan Stillman
date:2017-10-23 16:20 (JST)

This could occur if creator indexes needed to be corrected for an item.


Separate identifer parsing from Add Item by Identifier and search translation

commit:e35b035
author:Dan Stillman
date:2017-10-21 16:26 (JST)
  • Move identifier detection to Zotero.Utilities.Internal.extractIdentifiers() so that it can be used for things other than Add Item by Identifier (e.g., translation-server)
  • Add a Zotero.Translate.Search::setIdentifier() function that takes an identifier object produced by extractIdentifiers() ({ DOI: “10/…” }), converts that to the search format expected by translators, and calls setSearch()

Fix dropmarkers on Linux after 2x upgrades

commit:4e717a0
author:Dan Stillman
date:2017-10-21 07:15 (JST)

Throw a proper error if item.relations isn’t an object

commit:677b2ed
author:Dan Stillman
date:2017-10-21 06:42 (JST)

Update full-text sync tests after 2ecfff66817

commit:39a2445
author:Dan Stillman
date:2017-10-20 18:23 (JST)

Improve idle detection for full-text content processor

commit:2ecfff6
author:Dan Stillman
date:2017-10-20 15:01 (JST)

It was previously possible for a return-from-idle to not properly stop active processing.


Fixed 2x note column icon size

commit:9c5a3ad
author:Dan Stillman
date:2017-10-19 15:54 (JST)

Add missing 2x Mac collection/search icons and fix 2x sync icon size

commit:223c427
author:Dan Stillman
date:2017-10-18 19:05 (JST)

More 2x icon fixes

commit:30ae61d
author:Dan Stillman
date:2017-10-18 17:08 (JST)

Follow-up to 5b2af4845b


Update submodules

commit:45357bd
author:Dan Stillman
date:2017-10-18 10:05 (JST)

Update locales from Transifex

commit:16792df
author:Dan Stillman
date:2017-10-18 10:05 (JST)

Toolbar button and icon overhaul

commit:5b2af48
author:Dan Stillman
date:2017-10-18 09:36 (JST)
  • New 2x toolbar button shapes and other icons from @johanneskrtek – this HiDPI-ifies basically all graphics other than a few remaining item type icons
  • Use the Mac search dropmarker for all menu buttons, since it’s wider and more pleasant. Reduce menu button padding slightly to compensate.
  • Better toolbar button state for inactive window and pressed state
  • Fix dropmarker overlap in tag selector icon

Closes #347, Better/retina-style OS X toolbar icons Closes #1339, Create new button PNGs for macOS


Update version

commit:2b01a09
author:Dan Stillman
date:2017-10-18 09:53 (JST)

Fix #1335, Item drag and drop is unreliable

commit:1f5639d
author:Dan Stillman
date:2017-10-10 12:03 (JST)

Regression from e62433edfb

Load a locale file once via nsIConverterInputStream and cache it for subsequent retrieveLocale() calls. I’m not sure if using a stream instead of synchronous XHR is actually necessary now that there’s caching, but it can’t hurt.


Add note input event debugging via extensions.zotero.debugNoteEvents

commit:68b5ac4
author:Dan Stillman
date:2017-10-09 07:00 (JST)

Save note on forward-delete when text is selected

commit:8f39097
author:Dan Stillman
date:2017-10-09 06:59 (JST)

This doesn’t generate a keypress event for some reason, even though it does when no text is selected.


Fix rebuilding of full-text index

commit:4fb8f44
author:Dan Stillman
date:2017-10-09 05:58 (JST)

Fix sync error from invalid link mode in database

commit:08d3229
author:Dan Stillman
date:2017-10-08 17:42 (JST)

And add cleanup step to DB integrity check


Fix item selection that requires switching to library root

commit:773a93f
author:Dan Stillman
date:2017-10-07 18:05 (JST)

Broken in c7639f328fa


Remove unnecessary condition

commit:d4569d3
author:Dan Stillman
date:2017-10-07 16:43 (JST)

Fix data-dir-not-found error on first run with no legacy dataDir

commit:982719b
author:Dan Stillman
date:2017-10-07 16:44 (JST)

Update locales from Transifex

commit:352cf31
author:Dan Stillman
date:2017-10-06 08:00 (JST)

Adjust ignore mask in build script to #

*, not just #

*.

commit:225fa2b
author:Dan Stillman
date:2017-10-06 06:22 (JST)

Merge pull request #1293 from zotero/xhr-processDocuments

commit:d073dec
author:Dan Stillman
date:2017-10-06 06:21 (JST)

XMLHttpRequest() processDocuments


Fix breakage in the connector from 365e58249dc

commit:492e791
author:Dan Stillman
date:2017-10-06 05:58 (JST)

Remove babel-plugin-transform-async-to-module-method

commit:e14b8f9
author:Dan Stillman
date:2017-10-05 16:06 (JST)

Everything we support supports async/await now, so stop converting to Bluebird coroutine().


Fix translator test mismatches due to 5.0 tag format

commit:7d14da3
author:Dan Stillman
date:2017-08-22 09:45 (JST)

Don’t show “Running handler” for ‘debug’ handler during translation

commit:ffcf608
author:Dan Stillman
date:2017-08-22 09:32 (JST)

Use object for translate() in translator tests

commit:9209edd
author:Dan Stillman
date:2017-08-22 09:32 (JST)

Use new HTTP.processDocuments() in translatorTester

commit:23cf6bd
author:Dan Stillman
date:2017-08-22 09:31 (JST)

Allow substrings when filtering translator tests

commit:d526184
author:Dan Stillman
date:2017-08-22 09:30 (JST)

Fix import translators in translation-server

commit:c44af1c
author:Dan Stillman
date:2017-08-22 05:16 (JST)

Switch to XMLHttpRequest for processDocuments()

commit:819be60
author:Dan Stillman
date:2017-08-19 19:57 (JST)

processDocuments() now uses an XHR ‘document’ request, wrapped to provide a ‘location’ property, and uses promises for a simpler call signature (though the old one will continue to work, for existing translators). ‘done’ and ‘exception’ can now be handled via promises, and in the translator sandbox an optional noCompleteOnError argument instructs it not to automatically cancel the translation process with an error (e.g., for supplementary materials).

Since we do need a hidden browser in some situations (e.g., for saving snapshots), the old hidden-browser-based processDocuments() is still available as Zotero.HTTP.loadDocuments().

This hopefully also fixes various problems with document property access in translation-server.


Increase size of page logged for invalid PDF download

commit:5f9dc05
author:Dan Stillman
date:2017-10-05 10:36 (JST)

Avoid double item save when adding attachment

commit:ff798d3
author:Dan Stillman
date:2017-10-05 10:35 (JST)

Disable e10s for tests

commit:6e1e2dc
author:Dan Stillman
date:2017-10-05 10:35 (JST)

Fix #1272, Different-account warning with same username

commit:fcc366a
author:Dan Stillman
date:2017-10-03 14:44 (JST)

If you swapped in a database with a different sync account from the stored one and then opened the prefs, it would update the username to match the username from the API key, and then when you synced it would warn you using the new username for both accounts.

This stops the prefs from updating the username in the DB, so it only happens during a sync.

(This behavior was put in in 77a95b5e6d, I guess so that if you open the prefs twice before a sync it won’t briefly show a missing/outdated username after the first time, but that’s not a big deal.)


Update version

commit:f880fd1
author:Dan Stillman
date:2017-10-03 04:40 (JST)

Isolate test from 531170353b

commit:f7e2cd6
author:Dan Stillman
date:2017-10-02 11:42 (JST)

Disable app update during test runs

commit:959772d
author:Dan Stillman
date:2017-10-02 11:06 (JST)

Log warning if key not passed to getByLibraryAndKey()

commit:dc11b37
author:Dan Stillman
date:2017-10-02 11:05 (JST)

Fix bidirectional relations on Duplicate Item

commit:5311703
author:Dan Stillman
date:2017-10-02 11:04 (JST)

Fix additional refresh bug when Advanced Search window is open

commit:c014330
author:Dan Stillman
date:2017-10-01 13:23 (JST)

Follow-up to 89babf8832


Add deprecation warning for itemTreeView::saveSelection()

commit:699d563
author:Dan Stillman
date:2017-10-01 12:46 (JST)

Make missing row in itemTreeView::getSelectedItems() non-fatal

commit:4eb18e5
author:Dan Stillman
date:2017-10-01 12:45 (JST)

This might help avoid the search bar brokenness that people are seeing (and that we can’t reproduce), though the same problem might just cause a later error.


Update locales from Transifex

commit:f75d731
author:Dan Stillman
date:2017-10-01 08:33 (JST)

Update submodules

commit:5f413b2
author:Dan Stillman
date:2017-10-01 08:10 (JST)

Revert Create Bib/Doc Prefs font size change from db496e13c2f

commit:dec6b86
author:Dan Stillman
date:2017-10-01 08:08 (JST)

The font size is already controlled by the main font size pref, so this was just making the font disproportionally bigger.


Remove citeproc-prereqs, which isn’t necessary anymore

commit:52bbb79
author:Dan Stillman
date:2017-10-01 08:07 (JST)

Fix citeproc-js in Firefox 56

commit:e62433e
author:Dan Stillman
date:2017-09-30 17:01 (JST)

Our retrieveLocale() implementation was broken by https://bugzilla.mozilla.org/show_bug.cgi?id=1319111


Firefox 55 compatibility: fix zotero-platform files

commit:404e045
author:Dan Stillman
date:2017-08-09 11:45 (JST)

Mozilla removed support for the ‘platform’ keyword in chrome.manifest, so use os= instead


Fix refresh problems when Advanced Search is open, and maybe other times

commit:89babf8
author:Dan Stillman
date:2017-09-29 17:17 (JST)

Standardize connector server behavior for saves to read-only libraries

commit:48d4d2d
author:Dan Stillman
date:2017-09-28 06:31 (JST)

Return a 500 for read-only libraries for all save modes. Read-only views within editable libraries will save to the library root.

Addresses #185, RIS/BibTeX interception to read-only view behaves differently from save button


Update copyright and trademark info.

commit:18d15d8
author:Sean Takats
date:2017-09-27 22:37 (JST)

Remove connector proxy code

commit:7a062a7
author:Adomas Venčkauskas
date:2017-09-25 20:56 (JST)

Observing requests, auto-redirecting and learning proxies no longer relevant on this codebase (and interferes with Scaffold).


Remove old archive.org relations

commit:da21c9c
author:Dan Stillman
date:2017-09-23 05:56 (JST)

These aren’t allowed by the API and were breaking syncing (and haven’t been exposed anywhere for years anyway).


Apply linux tab fixes to all tabs (e.g. tabs in zotero plugins)

commit:42e2f22
author:Adomas Venčkauskas
date:2017-09-22 19:10 (JST)

Fix RIS/BibTeX import errors when in library root

commit:19447e7
author:Dan Stillman
date:2017-09-22 17:12 (JST)

Remove invalid relations mangled during import

commit:a455a72
author:Dan Stillman
date:2017-09-22 14:22 (JST)

Not sure if this occurred for our own translators, but it addresses items created from #1282.


Fix relations import via translators

commit:0d3d432
author:Dan Stillman
date:2017-09-22 14:02 (JST)

Fixes #1282


Restrict relation predicates to letters and colons for now

commit:10cae22
author:Dan Stillman
date:2017-09-22 14:01 (JST)

Restore related-items tests for Zotero.Translate.ItemGetter

commit:d80aa97
author:Dan Stillman
date:2017-09-22 12:03 (JST)

Update version

commit:1777fd1
author:Dan Stillman
date:2017-09-22 07:21 (JST)

Update citeproc-js to 1.1.178

commit:241e596
author:Dan Stillman
date:2017-09-22 04:47 (JST)

Fix sync errors from remote item referencing deleted local collection

commit:d81e2a5
author:Dan Stillman
date:2017-09-20 18:32 (JST)

Fix getAsync() integer warning when clicking on related item

commit:85d7c01
author:Dan Stillman
date:2017-09-20 16:35 (JST)

Fix editing in classic citation window (broken by 2901174ba3)

commit:c7639f3
author:Dan Stillman
date:2017-09-20 16:30 (JST)

This is (hopefully) a better fix for selection issues than 2901174ba3. A reference to the collectionTreeView is stored in a view property on the collectionTreeRow, and when an itemTreeView is initialized and passed a collectionTreeRow it assigns itself to an itemTreeView property on the row’s view.


Update version

commit:67ddc20
author:Dan Stillman
date:2017-09-20 16:35 (JST)

Check for invalid certificate in Zotero.HTTP.request()

commit:365e582
author:Dan Stillman
date:2017-09-20 13:19 (JST)

We were checking for this in the sync API client, but that didn’t apply to Amazon S3 for ZFS.


Revert “Use eraseTx() instead of erase() when deleting saved search”

commit:a858368
author:Dan Stillman
date:2017-09-20 12:47 (JST)

eraseTx() isn’t actually valid in this context.

This reverts commit 103c16a56328cb789c73c304e9f1391041983211.


Close import progress window on error

commit:8efbfb7
author:Dan Stillman
date:2017-09-19 15:35 (JST)

Fixes https://github.com/retorquere/zotero-better-bibtex/issues/719


Update version

commit:fbca2e5
author:Dan Stillman
date:2017-09-19 10:20 (JST)

Better isolate collectionTreeView test

commit:459e264
author:Dan Stillman
date:2017-09-19 06:45 (JST)

Fix error deleting collection after emptying trash

commit:afc7afe
author:Dan Stillman
date:2017-09-19 06:03 (JST)

Follow-up to c442daedce Fixes #1317


Fix non-integer warning when purging ids from sourceList.persist

commit:49506b6
author:Dan Stillman
date:2017-09-19 06:02 (JST)

Update locate engine download code

commit:d83d70e
author:Dan Stillman
date:2017-09-18 15:26 (JST)

Asyncify, make JSON load failures not fatal, and simplify icon download code (which also fixes download of CrossRef icon, which was failing for some reason).


Add sniffer entry for .ico files

commit:6d53839
author:Dan Stillman
date:2017-09-18 15:26 (JST)

Update submodules

commit:d2a33f2
author:Dan Stillman
date:2017-09-18 14:37 (JST)

Update locales from Transifex

commit:8ebff89
author:Dan Stillman
date:2017-09-18 14:36 (JST)

Update automatic trash emptying after 3872e646ac7

commit:fb61819
author:Dan Stillman
date:2017-09-16 13:44 (JST)

And restore ‘limit’ parameter used for auto-empty


Fix sync event listener after 3872e646ac

commit:e25af42
author:Dan Stillman
date:2017-09-16 10:02 (JST)

Fix test failure after 8215ba7a1d5c

commit:cc04ddb
author:Dan Stillman
date:2017-09-16 09:42 (JST)

Update submodules

commit:235d7c8
author:Dan Stillman
date:2017-09-16 09:25 (JST)

Speed up emptying trash

commit:3872e64
author:Dan Stillman
date:2017-09-16 09:20 (JST)

Shows a progress meter, which allows for larger chunks and fewer refreshes, avoids unnecessary updating of parent items that are being deleted anyway, and skip re-sorting of modified items in the trash.

Closes #1292, Emptying trash is slow


Update locales from Transifex

commit:7935d01
author:Dan Stillman
date:2017-09-15 13:51 (JST)

Crash Zotero on note-saving error

commit:8215ba7
author:Dan Stillman
date:2017-09-15 13:46 (JST)

Closes #1277, Crash note if not saving properly


Fix display of data dir in migration error message

commit:18c62be
author:Dan Stillman
date:2017-09-15 07:49 (JST)

When migrating prefs from Zotero for Firefox, the prefs specified a custom data dir, and that directory was missing, the “Previous directory:” line was blank.


Fix “SyntaxError: unterminated string literal” on first run

commit:9395af8
author:Dan Stillman
date:2017-09-15 07:48 (JST)

This could happen when migrating prefs from Firefox when the prefs.js file included a corrupted line.


Remove jm-sh from .gitmodules

commit:350e958
author:Frank Bennett
date:2017-09-15 02:06 (JST)

Use eraseTx() instead of erase() when deleting saved search

commit:103c16a
author:Dan Stillman
date:2017-09-13 14:02 (JST)

Update collection cache after “Delete collection and items…”

commit:c442dae
author:Dan Stillman
date:2017-09-13 14:01 (JST)

Fixes #1314


Add debugging for userID change

commit:5ec7c97
author:Dan Stillman
date:2017-09-13 05:22 (JST)

Merge new English strings

commit:892d4fb
author:Dan Stillman
date:2017-09-12 15:36 (JST)

Show better error message if data dir can’t be created

commit:a47c332
author:Dan Stillman
date:2017-09-12 15:35 (JST)

Update version

commit:e669bf0
author:Dan Stillman
date:2017-09-12 15:01 (JST)

Merge new English strings

commit:1cab2ba
author:Dan Stillman
date:2017-09-11 16:53 (JST)

Allow setting data directory via -datadir command-line flag

commit:e9439c9
author:Dan Stillman
date:2017-09-11 16:49 (JST)

Can be an absolute path or ‘profile’ to use ‘zotero’ subdirectory of profile directory as in earlier versions (but which won’t be treated as a legacy location eligible for migration)

Closes #1305


Filter stack displayed in startup error dialog

commit:d8d9758
author:Dan Stillman
date:2017-09-11 16:52 (JST)

Fix “undefined” for stack when a string is passed as Zotero.startupError

commit:48778b5
author:Dan Stillman
date:2017-09-11 16:52 (JST)

Filter ‘XPCOMUtils.jsm’ lines from stack traces

commit:33128d1
author:Dan Stillman
date:2017-09-11 16:51 (JST)

Update locales from Transifex

commit:c6e6cb6
author:Dan Stillman
date:2017-09-11 09:34 (JST)

Pass nonmatching court keys through when rendering in processor

commit:2ff62c5
author:Frank Bennett
date:2017-09-11 06:41 (JST)

Nonmatch text saves to court field. Bump version

commit:6a4ef46
author:Frank Bennett
date:2017-09-11 05:49 (JST)

Try for nonmatching field content, take 5

commit:c0c9dc9
author:Frank Bennett
date:2017-09-11 04:17 (JST)

Try for nonmatching field content, take 4

commit:db2ac74
author:Frank Bennett
date:2017-09-11 04:05 (JST)

Try for nonmatching field content, take 3

commit:b7c14b4
author:Frank Bennett
date:2017-09-10 23:14 (JST)

Try again for nonmatch content, take 3

commit:ca91b3b
author:Frank Bennett
date:2017-09-10 22:02 (JST)

Try again for nonmatch content, take 2

commit:6ad54dd
author:Frank Bennett
date:2017-09-10 21:56 (JST)

Try again for nonmatch content

commit:dd9404b
author:Frank Bennett
date:2017-09-10 21:31 (JST)

Try simply not forcing select to allow non-matching content

commit:4742ef8
author:Frank Bennett
date:2017-09-10 18:30 (JST)

Fix obvious bug in new court name selection code

commit:72bdd8e
author:Frank Bennett
date:2017-09-10 17:03 (JST)

Continue after failure in Add Item by Identifier

commit:64e840e
author:Dan Stillman
date:2017-09-10 16:38 (JST)

This should give better feedback when some identifiers fail, but for now restore 4.0 behavior.

Also add items by identifier in order, not reverse order


Allow non-listed court values

commit:8a7fdcd
author:Frank Bennett
date:2017-09-10 16:41 (JST)

Fix intermittent item selection failure

commit:2901174
author:Dan Stillman
date:2017-09-10 16:18 (JST)

Hack in unions for each call to itemData and itemCreators (isNot searches failed).

commit:b1f29aa
author:Frank Bennett
date:2017-09-10 10:30 (JST)

Fix sqlParams

commit:91c5c90
author:Frank Bennett
date:2017-09-10 09:43 (JST)

Hack to include variants in search results

commit:d9b56a6
author:Frank Bennett
date:2017-09-10 09:34 (JST)

Bump version

commit:9baf3fa
author:Frank Bennett
date:2017-09-09 15:00 (JST)

Tweak jurisdiction-depth param handing

commit:074977b
author:Frank Bennett
date:2017-09-09 11:13 (JST)

Update processor. Add jurisdiction-depth attribute.

commit:3e549f5
author:Frank Bennett
date:2017-09-09 10:32 (JST)

Update translators

commit:f9f0c5a
author:Frank Bennett
date:2017-09-08 21:01 (JST)

Fix syntax error in auto-complete SQL, take 2

commit:509c822
author:Frank Bennett
date:2017-09-08 21:00 (JST)

Fix syntax error in auto-search SQL

commit:73d9575
author:Frank Bennett
date:2017-09-08 18:26 (JST)

Recognize discrete country variable in processor derived from jurisdiction

commit:c2a9bc5
author:Frank Bennett
date:2017-09-08 17:45 (JST)

Update citeproc-js

commit:32b9c33
author:Frank Bennett
date:2017-09-08 15:10 (JST)

Bypass cache by default in Zotero.Utilities.Internal.saveURI()

commit:d271683
author:Dan Stillman
date:2017-09-08 12:54 (JST)

Simplify abbrev key normalization, cover names

commit:bcc39e2
author:Frank Bennett
date:2017-09-08 10:27 (JST)

Fix syntax error

commit:2626973
author:Frank Bennett
date:2017-09-08 08:03 (JST)

Update translators

commit:de548c5
author:Frank Bennett
date:2017-09-08 07:25 (JST)

Normalize abbreviation keys

commit:904b4ca
author:Frank Bennett
date:2017-09-08 07:24 (JST)

Bump version

commit:e226f18
author:Frank Bennett
date:2017-09-05 07:27 (JST)

Update locales

commit:efa481f
author:Frank Bennett
date:2017-09-03 06:48 (JST)

Adjust version compatibility in update.rdf (not sure if this is relevant now)

commit:8d882af
author:Frank Bennett
date:2017-09-03 06:29 (JST)

Change version string in install.rdf

commit:3e9ecec
author:Frank Bennett
date:2017-09-02 16:15 (JST)

Remove debug lines

commit:5248b08
author:Dan Stillman
date:2017-09-02 14:38 (JST)

Don’t purge data tables until after schema update

commit:1100015
author:Dan Stillman
date:2017-09-02 06:46 (JST)

It’s no longer necessary to do this before syncing, since tags and creators aren’t first-class objects.


Fix potential failure with full-text phrase search

commit:69c27cd
author:Dan Stillman
date:2017-09-02 06:44 (JST)

Phrase searches weren’t scoped to the current library, so they could return unloaded items in other libraries and cause the search to fail.


Simplify Zotero.ItemTreeView.prototype.getSortedItems()

commit:fd5c48a
author:Dan Stillman
date:2017-09-02 02:21 (JST)

Fix Create Bib for saved searches

commit:ed6d628
author:Dan Stillman
date:2017-09-02 02:21 (JST)

Do not attempt to edit sourt in Travis then

commit:ad9ba1e
author:Frank Bennett
date:2017-09-01 08:44 (JST)

More jiggery-pokery around hidden variables

commit:63f0200
author:Frank Bennett
date:2017-09-01 08:12 (JST)

Try moving vars back into .travis.yml

commit:260863c
author:Frank Bennett
date:2017-09-01 07:28 (JST)

Extend another timeout value

commit:e80f32b
author:Frank Bennett
date:2017-08-31 22:05 (JST)

Fix path, reposition sed call

commit:b384317
author:Frank Bennett
date:2017-08-31 20:03 (JST)

Stir in CL key at build time

commit:7bf51c7
author:Frank Bennett
date:2017-08-31 19:26 (JST)

Fix regression in 05d74c4cac

commit:01ecff8
author:Dan Stillman
date:2017-08-31 07:46 (JST)

Fix test failure after 94c4445475

commit:91ef561
author:Dan Stillman
date:2017-08-31 07:22 (JST)

If the styled textbox (i.e., TinyMCE) isn’t initialized, .value now returns null instead of throwing.


Don’t load note/attachments counts as primary data

commit:05d74c4
author:Dan Stillman
date:2017-08-31 07:06 (JST)

Zotero.Item::numNotes()/numAttachments() now require ‘childItems’ to have been loaded.

Fixes #1301, Slow startup with many items in trash


Allow parentID in importFileAttachment() test support function

commit:687f86a
author:Dan Stillman
date:2017-08-31 06:23 (JST)

The Zotero.Attachments functions only take parentItemID, but createDataObject() takes parentID.


Fix restart error moving away from note that hadn’t finished loading

commit:94c4445
author:Dan Stillman
date:2017-08-31 06:22 (JST)

Fix letter casing of repo name

commit:825599a
author:Frank Bennett
date:2017-08-30 21:27 (JST)

Fix slug name

commit:a396d7b
author:Frank Bennett
date:2017-08-30 20:55 (JST)

Revert secure env setting to Zotero original. Secret key via web UI now.

commit:68d2feb
author:Frank Bennett
date:2017-08-30 17:44 (JST)

Extend callback timeout

commit:9d2f5e8
author:Frank Bennett
date:2017-08-30 13:59 (JST)

Extended timeouts

commit:2df8069
author:Frank Bennett
date:2017-08-30 13:42 (JST)

Weird tweak in fulltext.js

commit:7f215d4
author:Frank Bennett
date:2017-08-30 09:47 (JST)

Fix bugs in loading of test versions of language/jurisdiction datasets

commit:f910b97
author:Frank Bennett
date:2017-08-30 08:31 (JST)

Use minimal lang/jurisd data everywhere, to see what happens

commit:72b9d96
author:Frank Bennett
date:2017-08-30 05:17 (JST)

Update locales from Transifex

commit:000e7f9
author:Dan Stillman
date:2017-08-24 08:54 (JST)

Combine Zotero and Juris-M data load overrides

commit:6f1a3b6
author:Frank Bennett
date:2017-08-29 20:55 (JST)

Add China to minimal language dataset. China is everywhere.

commit:6a7c592
author:Frank Bennett
date:2017-08-29 17:37 (JST)

Add more language tag descriptors needed for testing

commit:b027b4e
author:Frank Bennett
date:2017-08-29 17:18 (JST)

Add GB to minimal tag data used for testing

commit:9c198bc
author:Frank Bennett
date:2017-08-29 15:29 (JST)

Install minimal language data only by default, for testing

commit:ac3188c
author:Frank Bennett
date:2017-08-29 15:21 (JST)

Amend tests to reflect Juris-M behavior

commit:c5b8186
author:Frank Bennett
date:2017-08-29 10:54 (JST)

Omit jurisdiction data with skipBundledFiles, for testing

commit:7423ba1
author:Frank Bennett
date:2017-08-29 08:13 (JST)

Trivial change to trigger Travis CI

commit:4465597
author:Frank Bennett
date:2017-08-29 07:37 (JST)

Adjust tests to follow Juris-M behavior

commit:6b7e5eb
author:Frank Bennett
date:2017-08-29 01:00 (JST)

Adjust test result to follow Juris-M behavior

commit:52a8188
author:Frank Bennett
date:2017-08-29 00:24 (JST)

Align chrome.manifest content with Zotero

commit:1a76917
author:Frank Bennett
date:2017-08-28 09:56 (JST)

Set travis params

commit:46caac2
author:Frank Bennett
date:2017-08-27 20:17 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:a5f69d7
author:Frank Bennett
date:2017-08-26 11:54 (JST)

Merge pull request #1299 from Juris-M/z-abbrevs-filter-style-edit-hook

commit:b9b1c0c
author:Dan Stillman
date:2017-08-25 10:15 (JST)

Expose styleEngine in csledit.js, for Abbreviation Filter


Merge branch ‘jurism-6.0’ of https://github.com/juris-m/zotero into jurism-5.0

commit:4eaaa12
author:Frank Bennett
date:2017-08-25 09:41 (JST)

Add FIX_SYMLINKS.sh script

commit:a5cfcdf
author:Frank Bennett
date:2017-08-25 09:40 (JST)

Update locales from upstream Zotero

commit:e8503f8
author:Frank Bennett
date:2017-08-25 09:33 (JST)

Merge upstream Zotero to 5.0.17 tag

commit:89fe034
author:Frank Bennett
date:2017-08-25 07:14 (JST)

Source files for icon

commit:eafadee
author:Frank Bennett
date:2017-08-25 06:49 (JST)

Expose styleEngine in csledit.js, for Abbreviation Filter

commit:b0c0cd6
author:Frank Bennett
date:2017-08-24 23:26 (JST)

Update citeproc-js to 1.1.177

commit:a15b23e
author:Dan Stillman
date:2017-08-23 18:01 (JST)

Fix error relocating to filename with different Unicode normalization

commit:f4b73d2
author:Dan Stillman
date:2017-08-23 18:00 (JST)

Update version

commit:b3043c9
author:Dan Stillman
date:2017-08-22 22:30 (JST)

Update locales from Transifex

commit:e632f1c
author:Dan Stillman
date:2017-08-22 19:27 (JST)

Disable strict mode in citeproc-js for now

commit:1d19811
author:Dan Stillman
date:2017-08-22 19:18 (JST)

Update citeproc-js to 1.1.175

commit:879ed11
author:Dan Stillman
date:2017-08-22 19:18 (JST)

Update version

commit:8e36529
author:Dan Stillman
date:2017-08-20 06:26 (JST)

Don’t keep checking for lost Z4Fx data directory

commit:2919486
author:Dan Stillman
date:2017-08-20 06:47 (JST)

Remove unnecessary log line

commit:f45d561
author:Dan Stillman
date:2017-08-20 06:36 (JST)

Only prompt for recently updated Z4Fx data directories

commit:0391569
author:Dan Stillman
date:2017-08-20 06:30 (JST)

Add prompt to revert to Zotero for Firefox data directory

commit:267e316
author:Dan Stillman
date:2017-08-20 06:17 (JST)

For people affected by migration bugs prior to 5.0.15


Update version

commit:2725d42
author:Dan Stillman
date:2017-08-19 23:06 (JST)

Fix data directory migration if only Firefox profile directory

commit:d368c40
author:Dan Stillman
date:2017-08-19 22:58 (JST)

Update version

commit:bbfe4b9
author:Dan Stillman
date:2017-08-19 22:23 (JST)

Fix accessDate when translators set CURRENT_TIMESTAMP

commit:6673c64
author:Dan Stillman
date:2017-08-19 22:21 (JST)

(But it also seems like we always do that automatically for web translators, so I’m not sure why so many translators set that.)


Update version

commit:d92f566
author:Dan Stillman
date:2017-08-19 21:48 (JST)

Update locales from Transifex

commit:2d9284b
author:Dan Stillman
date:2017-08-19 21:45 (JST)

Make sure rootDocument is set in Zotero.Translate.Web.setDocument()

commit:de36a6e
author:Dan Stillman
date:2017-08-17 09:16 (JST)

For non-browser documents that we wrap, defaultView.top.document can be undefined without being inaccessible.

Fixes regression from dae0986b9be


Update citeproc-js to 1.1.174

commit:871cbae
author:Dan Stillman
date:2017-08-19 12:23 (JST)

Update version

commit:a65ae87
author:Dan Stillman
date:2017-08-18 23:15 (JST)

Fix linked attachment base directory handling at drive root

commit:7386b37
author:Dan Stillman
date:2017-08-18 23:04 (JST)

The first letter of the relative path was being removed on save if the base directory was set to the drive root (e.g. D:instead of D:foo).


Update submodules

commit:acb990c
author:Dan Stillman
date:2017-08-17 23:57 (JST)

Update locales from Transifex

commit:a4a786b
author:Dan Stillman
date:2017-08-17 23:56 (JST)

Fix #1286, Show proper error messages for OS.File errors

commit:1efe54e
author:Dan Stillman
date:2017-08-17 22:42 (JST)

Use passed URL rather than doc.location in translator processDocuments

commit:da2dedf
author:Dan Stillman
date:2017-08-17 00:58 (JST)

Outside of page contexts (e.g., from an XHR with responseType = ‘document’), document.location is null.


Update locales from Transifex

commit:d1de8b7
author:Dan Stillman
date:2017-08-16 08:46 (JST)

Fix attachment-download test

commit:13cd84e
author:Dan Stillman
date:2017-08-16 08:42 (JST)

Avoid XML Parsing Error for WebDAV requests that don’t return Content-Type

commit:065bac3
author:Dan Stillman
date:2017-08-16 08:07 (JST)

If responseType isn’t set and the response doesn’t include a Content-Type header, Firefox tries to parse the file as XML, and if the file isn’t XML it logs an “XML Parsing Error”, which includes the username and password.


Update password-hiding logic for malformed-XML XHR errors in reports

commit:db8bb34
author:Dan Stillman
date:2017-08-16 07:38 (JST)

Don’t log WebDAV Authorization header

commit:b171b15
author:Dan Stillman
date:2017-08-16 07:37 (JST)

Restore Cut/Copy/Paste to note context menu

commit:dd0fafd
author:Dan Stillman
date:2017-08-16 06:46 (JST)

Fix “Client failed to connect to the D-BUS daemon” in Travis output

commit:70ade61
author:Dan Stillman
date:2017-08-16 04:39 (JST)

Fix a cross-origin frame access error in Translate.Web.setDocument

commit:dae0986
author:Adomas Venčkauskas
date:2017-08-15 21:36 (JST)

Changes imports from connector to save to selected collection

commit:a5a7df3
author:Adomas Venčkauskas
date:2017-08-15 17:14 (JST)

Closes #1289


Update version

commit:cee2e1d
author:Dan Stillman
date:2017-08-15 07:37 (JST)

Fix <label class=”text-link”/> in basic viewer (e.g., Add-ons pane)

commit:c31f0b6
author:Dan Stillman
date:2017-08-15 07:36 (JST)

I’m not sure when this stopped working, or whether the Add-ons pane was in the basic viewer before, but that fixes it.


Fix error refreshing missing citation without name part

commit:8797c7f
author:Dan Stillman
date:2017-08-15 04:24 (JST)

https://forums.zotero.org/discussion/66789/


Don’t look up library name for each downloaded file

commit:a24f16e
author:Dan Stillman
date:2017-08-13 10:26 (JST)

Update locales from Transifex

commit:b0826fd
author:Dan Stillman
date:2017-08-13 10:09 (JST)

Fix first-run error with some upgrades after 39bfeac86c21

commit:c9b9d41
author:Dan Stillman
date:2017-08-13 10:00 (JST)

Fix “Open in Library” from Quick Format popup if main window is closed

commit:6bcf92d
author:Dan Stillman
date:2017-08-12 09:50 (JST)

Possible now on macOS


Add Zotero.openMainWindow()

commit:c59ae5c
author:Dan Stillman
date:2017-08-12 09:49 (JST)

Opens the main Zotero window if it’s not open, which is now possible on macOS.


Update version

commit:c293226
author:Dan Stillman
date:2017-08-12 07:11 (JST)

Don’t update storage version if file sync is stopped

commit:2770860
author:Dan Stillman
date:2017-08-12 03:29 (JST)

Otherwise subsequent syncs won’t download the remaining files until there’s a remote storage change.


Improve logic for determining whether to check for files to download

commit:9069559
author:Dan Stillman
date:2017-08-12 05:25 (JST)

This should fix cases of files not being downloaded after interrupted syncs until the next time files were changed remotely.


Merge new English strings

commit:c768d48
author:Dan Stillman
date:2017-08-12 02:15 (JST)

Show files remaining in library in sync button tooltip

commit:4c13d51
author:Dan Stillman
date:2017-08-11 05:41 (JST)

Fix error handling for HTTP.request() with responseType: ‘document’

commit:0df9674
author:Dan Stillman
date:2017-08-12 01:24 (JST)

Download missing attachments as needed even in at-sync-time mode

commit:9202ab8
author:Dan Stillman
date:2017-08-11 23:05 (JST)

Fix URL opening in some places (since 21cc9f16bff0)

commit:3a2f0e6
author:Dan Stillman
date:2017-08-11 18:50 (JST)

Update version

commit:0653ee3
author:Dan Stillman
date:2017-08-11 18:50 (JST)

Fix opening of some links in About pane

commit:65d63fa
author:Dan Stillman
date:2017-08-10 11:50 (JST)

Move ZoteroPane.launchURL() to Zotero.launchURL()

commit:21cc9f1
author:Dan Stillman
date:2017-08-10 11:49 (JST)

And add deprecation warning to ZoteroPane.launchURL()


Better Unicode path comparison in WebDAV.purgeOrphanedStorageFiles()

commit:678a6e1
author:Dan Stillman
date:2017-08-10 11:41 (JST)

Fix error message in WebDAV purgeOrphanedStorageFiles()

commit:83fe445
author:Dan Stillman
date:2017-08-10 10:59 (JST)

Choose most recently used data directory when upgrading to 5.0

commit:39bfeac
author:Dan Stillman
date:2017-08-10 10:31 (JST)

Previously, if someone was upgrading from Zotero for Firefox to 5.0 but at some point had installed Zotero Standalone and told it not to share the data directory, 5.0 would use the data directory from the Zotero profile directory, and people would end up with an empty database with a Zotero Quick Start Guide from years ago.

This checks for the database with the most recent mtime and uses that data directory instead. In the Firefox profile, that can be either the default ‘zotero’ subdirectory or a custom data directory. If one of the Firefox locations is used, Zotero prefs are read from Firefox, because it means that Zotero for Firefox was being used (because if Zotero Standalone had been in use it would’ve needed a custom data dir setting pointing at the Firefox database).


Ignore stored-file path with no ‘storage:’

commit:d3833b8
author:Dan Stillman
date:2017-08-09 09:39 (JST)

There was a report of an imported file with a relative path, probably from some ancient bug (in our code or a plugin’s)


Update locales from Transifex

commit:126fb86
author:Dan Stillman
date:2017-08-09 09:38 (JST)

Don’t stop after one uploaded full-text batch

commit:a02eb3c
author:Dan Stillman
date:2017-08-07 02:02 (JST)

Fix spacing of note editor and parent row in conflict resolution window

commit:945da5e
author:Dan Stillman
date:2017-08-07 01:52 (JST)

Fix spacing of full-text index state row

commit:aea378f
author:Dan Stillman
date:2017-08-07 01:51 (JST)

Merge new English strings

commit:782e798
author:Dan Stillman
date:2017-08-09 09:03 (JST)

Show “Queued” in right pane for unprocessed full-text and allow indexing

commit:07ce273
author:Dan Stillman
date:2017-08-07 01:50 (JST)

Stop storage requests on shutdown

commit:fffa1ba
author:Dan Stillman
date:2017-08-07 00:50 (JST)

Don’t initialize storage requests until they start

commit:9920a84
author:Dan Stillman
date:2017-08-07 00:50 (JST)

Add more logging for word plugin installer

commit:55992e3
author:Adomas Venčkauskas
date:2017-08-08 18:46 (JST)

Fix icon name

commit:a758c30
author:Frank Bennett
date:2017-08-08 14:03 (JST)

Add composite Windows icon

commit:b355a5e
author:Frank Bennett
date:2017-08-07 19:18 (JST)

Add composite Windows icon

commit:1e5ce2b
author:Frank Bennett
date:2017-08-07 19:15 (JST)

Add Windows icon

commit:3bf9efb
author:Frank Bennett
date:2017-08-07 19:02 (JST)

Fix icons

commit:655ccaa
author:Frank Bennett
date:2017-08-07 18:56 (JST)

Merge new English strings

commit:6232c83
author:Dan Stillman
date:2017-08-06 02:47 (JST)

Allow debug output logging to be enabled after later restart

commit:a0a2502
author:Dan Stillman
date:2017-08-06 02:44 (JST)

With the new system, it wasn’t possible through the UI to generate debug output for another action that happened after a restart, since it just restarted immediately. This adds a prompt after selecting the menu option that allows for restarting now, restarting later, or cancelling.


Update version

commit:83dfd07
author:Dan Stillman
date:2017-08-05 23:27 (JST)

Update app name in branding

commit:45f11ff
author:Frank Bennett
date:2017-08-05 16:28 (JST)

Fix “Copy as HTML” Quick Copy setting

commit:b3b9cac
author:Dan Stillman
date:2017-08-05 10:13 (JST)

Fix sync test after 7b0ed6da81

commit:8b7f338
author:Dan Stillman
date:2017-08-05 08:41 (JST)

Remove pointless Bluebird lines from various stack traces

commit:34e2393
author:Dan Stillman
date:2017-08-05 08:09 (JST)

Don’t unlink account on key info request connection failure

commit:7b0ed6d
author:Dan Stillman
date:2017-08-05 08:07 (JST)

This can happen when the computer is offline but that hasn’t been detected for some reason.


Resolve schema update promise even if repository update fails

commit:198fb28
author:Dan Stillman
date:2017-08-04 23:48 (JST)

Update locales from Transifex

commit:2b3f6b4
author:Dan Stillman
date:2017-08-04 07:42 (JST)

Add test script to repo

commit:32c88a1
author:Frank Bennett
date:2017-08-03 08:18 (JST)

Add console and branding subdirs to repo

commit:4bcacac
author:Frank Bennett
date:2017-08-03 05:17 (JST)

Fix a wrong cookieSandbox condition for /connector/saveSnapshot

commit:492293e
author:Adomas Venčkauskas
date:2017-08-02 21:43 (JST)

Reverse 110f2a patch to addCitationDialog.xul. Broke formatting.

commit:67bf516
author:Frank Bennett
date:2017-08-01 08:52 (JST)

Merge new English strings

commit:03f8c5f
author:Dan Stillman
date:2017-07-31 18:47 (JST)

Improve data directory startup error handling

commit:c6ab186
author:Dan Stillman
date:2017-07-31 18:40 (JST)

Better instructions and behavior if the data directory is inaccessible or missing, including automatically detecting a directory at the default location if the configured directory is missing and offering to use the default instead. Together, this means that if, say, security software prevents Zotero from accessing the data directory within the Firefox profile, it will suggest that the user move it to ~/Zotero and then prompt to use that directory.


Update submodules

commit:ffc32d9
author:Dan Stillman
date:2017-07-31 04:34 (JST)

Update locales from Transifex

commit:cd86cfc
author:Dan Stillman
date:2017-07-31 04:32 (JST)

Fix typo from 991967d5b

commit:33eb31d
author:Dan Stillman
date:2017-07-31 04:25 (JST)

Don’t close Zotero on macOS when window is closed

commit:5123c21
author:Dan Stillman
date:2017-07-30 20:43 (JST)

Keep the application open with limited menus, including a Window -> Zotero option bound to (Cmd-0) that can be used to reopen the main window.

This allows Zotero to use almost no CPU (instead of a few percentage points when the window is open, even when hidden with Cmd-H, though it’d be nice to fix that) and still allow saves from the connector.

There might be some things that aren’t being destroyed properly when the window is closed or other bugginess, but it seems to work pretty well.


Don’t rely on last browser window to open prefs from menu

commit:a8ba2fa
author:Dan Stillman
date:2017-07-30 20:42 (JST)

Use nsIWindowWatcher in Zotero.openInViewer()

commit:ee0b4f5
author:Dan Stillman
date:2017-07-30 20:36 (JST)

Instead of getting the last browser window


Refactor and improve target selection in connector server

commit:991967d
author:Dan Stillman
date:2017-07-30 20:34 (JST)

Fall back to lastViewedFolder if no active Zotero pane


Fix 2x icons in Timeline

commit:a92acfe
author:Dan Stillman
date:2017-07-30 16:58 (JST)

Fix searches for PowerPoint files

commit:ac7c22a
author:Dan Stillman
date:2017-07-30 13:04 (JST)

This also adds a mechanism for indicating that DB userdata upgrades after a certain version are minor and shouldn’t show “Upgrading database…” or create a pre-upgrade backup.


Fix logged errors and debug messages in timeline

commit:9652b9f
author:Dan Stillman
date:2017-07-30 11:16 (JST)

Default month/day to 01 in Timeline if missing

commit:168e4e4
author:Dan Stillman
date:2017-07-30 11:13 (JST)

This causes any item with just a year to show up at the start of the year (instead of just not showing up, which I think was the case before). Unfortunately they can then go out of view, and it’s not possible to scroll to view more, though that could probably be fixed.


Hide broken Timeline copyright image (listed in About pane anyway)

commit:fba412f
author:Dan Stillman
date:2017-07-30 11:13 (JST)

Fix Zotero.Utilities.Internal.getAsyncInputStream(), used by Timeline

commit:23d4992
author:Dan Stillman
date:2017-07-30 11:11 (JST)

Fix external zotero:// links

commit:4c9f389
author:Dan Stillman
date:2017-07-30 06:13 (JST)

Update proxy authentication URLs

commit:a6564e9
author:Dan Stillman
date:2017-07-29 09:21 (JST)

And try all, since it doesn’t do any of this unless there’s a PAC file, it’s not actually a network request unless the site should be proxied, and it should only make a single HEAD request unless a previous one fails.

There’s a possibility some proxies are limited to HTTP, in which case changing these to HTTPS might stop this from working. If so, we’d need to add back HTTP addresses.

Closes #1273


Update locales from Transifex

commit:ae22ce7
author:Dan Stillman
date:2017-07-29 08:34 (JST)

Remove prompt when adding style manually

commit:884d03b
author:Dan Stillman
date:2017-07-29 07:45 (JST)

(And prompt was showing “(null)”)


Merge new English strings

commit:34b99fb
author:Dan Stillman
date:2017-07-28 15:18 (JST)

Update Quick Copy menu options based on current settings and URL

commit:d252a09
author:Dan Stillman
date:2017-07-27 15:29 (JST)

Show “Copy Citation” and “Copy Bibliography” when a bib format is selected and “Copy as BibTeX”, etc., when an export is selected. If a site-specific setting is in effect from the last active URL, use that instead.

If no regular items are selected in bib mode, the menu options are disabled.

This also now filters non-regular items out when in bib mode – before if you selected a combination it would include a bunch of ‘n.d.’ lines.

Closes #1155, Disable Copy Citation menu option when a translator is selected for Quick Copy


Fix crash switching from Notes tab to feed item

commit:72fbee5
author:Dan Stillman
date:2017-07-27 13:11 (JST)

Consider fulltextItems with SYNC_STATE_MISSING as unindexed

commit:c110e64
author:Dan Stillman
date:2017-07-26 19:07 (JST)

The items will still match full-text word searches, but they won’t match phrase searches (because those require cache files for non-text attachments) and the full-text won’t sync to other computers, so they should really be reindexed.


Don’t keep looking for unsynced full-text content that isn’t available

commit:67ccb63
author:Dan Stillman
date:2017-07-26 18:39 (JST)

This can happen if cache files are deleted for PDF attachments or if text files are missing.


Switch to OS.File for most full-text file access

commit:10637ca
author:Dan Stillman
date:2017-07-26 18:38 (JST)

Fix various problems with fulltextContent searches

commit:61f8a2c
author:Dan Stillman
date:2017-07-26 18:35 (JST)

Including finding items in the wrong library and not finding any items when paired with the checkboxes in ANY mode


Restore auto-expanding of search matches except in My Publications

commit:3637163
author:Dan Stillman
date:2017-07-26 18:33 (JST)

Saved searches and the trash should automatically expand items to show matching child items, but that was broken in d47275210.


Remove non-matching parent items when deleting items from trash

commit:46531a4
author:Dan Stillman
date:2017-07-26 18:31 (JST)

Fixes #866, Trash doesn’t refresh properly when emptying deleted attachments


Log a few more lines during the word plugin installation

commit:81d5618
author:Adomas Venčkauskas
date:2017-07-26 15:20 (JST)

Add intl.accept_languages from Mozilla language packs

commit:e475b22
author:Dan Stillman
date:2017-07-26 05:27 (JST)

Allow clearing global prefs

commit:d8b2014
author:Dan Stillman
date:2017-07-26 04:44 (JST)

Update locales from Transifex

commit:c6e4722
author:Dan Stillman
date:2017-07-26 04:32 (JST)

Fix PluralForm support

commit:521f291
author:Dan Stillman
date:2017-07-26 04:20 (JST)

The library was using the plural rule defined in the built-in intl.properties, but that was always en-US in the standalone app.


Disable debug output logging test for now

commit:c223417
author:Dan Stillman
date:2017-07-25 16:24 (JST)

This should be tested, but we run tests in Firefox, and this doesn’t exist in Firefox… Easiest option is probably to add the submenu to the Firefox menus for the purposes of testing.


Merge new English strings

commit:3bb8b5d
author:Dan Stillman
date:2017-07-25 16:08 (JST)

Remove line from Report Errors about messages possibly unrelated to Zotero

commit:d01366a
author:Dan Stillman
date:2017-07-25 15:40 (JST)

Move debug output logging to the Help menu

commit:c2bb4ac
author:Dan Stillman
date:2017-07-25 15:36 (JST)

Adds a submenu for quickly generating and submitting debug output, with a button to copy the Debug ID to the clipboard and a one-click option to restart with logging enabled. Debug output can also now be viewed in real-time using the new debug output viewer window (previously available only via a command-line flag).

The locale switcher has moved to the top of the Advanced prefpane (where Debug Output Logging used to go) in a Miscellaneous section, and there’s a new “Advanced Configuration” section (mirroring Thunderbird) at the bottom for “Config Editor”.

Closes #1108


Debug output viewer tweaks

commit:e3947e7
author:Dan Stillman
date:2017-07-25 15:30 (JST)
  • Decrease font size
  • Do a better job of pinning to bottom
  • Disable submit button when clearing output
  • Filter ANSI color codes from slow lines

“Submit Feedback…” -> “Discussion Forums”

commit:eb1cecf
author:Dan Stillman
date:2017-07-25 15:30 (JST)

Deprecate Zotero.Utilities.Internal.quitZotero() in favor of quit()

commit:a959436
author:Dan Stillman
date:2017-07-25 15:29 (JST)

Don’t omit first line in debug output when submitting

commit:695dd4e
author:Dan Stillman
date:2017-07-25 11:49 (JST)

Merge branch ‘jurism-5.0-dev’ into jurism-5.0

commit:25ffd47
author:Frank Bennett
date:2017-07-25 08:55 (JST)

Remove legacy language switcher code, tidy up language pref panel

commit:69f4e81
author:Frank Bennett
date:2017-07-25 08:54 (JST)

Update locales following merge

commit:53b979b
author:Frank Bennett
date:2017-07-25 06:12 (JST)

Merge changes from upstream Zotero

commit:a881067
author:Frank Bennett
date:2017-07-25 06:09 (JST)

Avoid sync error on removal of creator with multi data

commit:af99e6d
author:Frank Bennett
date:2017-07-25 05:59 (JST)

Update version

commit:9a8ab52
author:Dan Stillman
date:2017-07-24 22:14 (JST)

Update submodules

commit:6ae2b58
author:Dan Stillman
date:2017-07-24 21:59 (JST)

Update locales from Transifex

commit:d5759e3
author:Dan Stillman
date:2017-07-24 21:58 (JST)

Fix a whole mess of issues with data directory migration

commit:34d039b
author:Dan Stillman
date:2017-07-24 21:38 (JST)
  • If an error occurred while moving the database file, the data directory could end up pointing to the new, empty directory after a restart
  • The error message for a full failure was missing the second half that actually explained that you were supposed to move the data directory
  • The check for different-drive migrations didn’t work if the new directory didn’t exist (at least on macOS), swallowed some errors, and interfered with manual migrations from the prefs
  • The manual migration button would say that the new directory wasn’t empty even if it just contained .DS_Store
  • Don’t show “Database migration in progress” after not restarting after a migration failure

Additionally, after a full failure the migration is now attempted on every restart and displays a warning each time, since otherwise people will never move their directories out of the Firefox profile (which is when it’s going to fail the most, due to security software).


Use proper locale format for dates in items list

commit:05ea309
author:Dan Stillman
date:2017-07-24 04:00 (JST)

2addf6b27b fixed the date order used when automatic locale detection was enabled, but this fixes the format (e.g., dots instead of slashes). It should now match the item pane. I’m not sure why we weren’t doing this before, but hopefully we didn’t have a good reason.


Update locales from Transifex

commit:a9f0096
author:Dan Stillman
date:2017-07-23 14:11 (JST)

Increase font size and decrease style list height in doc prefs

commit:db496e1
author:Dan Stillman
date:2017-07-23 13:54 (JST)

On macOS this shows all default styles without a scroll bar.


Use HTTPS for Google Scholar and CrossRef lookup engines

commit:073d273
author:Dan Stillman
date:2017-07-23 13:45 (JST)

TODO: Update existing engines


Use HTTPS for Google Scholar in Retrieve Metadata for PDF

commit:ef71a2c
author:Dan Stillman
date:2017-07-23 13:44 (JST)

Add some additional logging to docs plugin installer

commit:0ceb5ec
author:Adomas Venčkauskas
date:2017-07-22 23:28 (JST)

Fix auto-syncing of unchecked groups after object change

commit:2252158
author:Dan Stillman
date:2017-07-22 08:39 (JST)

Fix revealing parent directory of missing file

commit:6d2c72f
author:Dan Stillman
date:2017-07-22 07:33 (JST)

Updates Zotero.File.getClosestDirectory() to take a path rather than an nsIFile


Fix broken WebDAV orphaned-file purging after 39a8e8fb0c3

commit:b033ded
author:Dan Stillman
date:2017-07-21 21:39 (JST)

Update non-English locales

commit:efe8b65
author:Dan Stillman
date:2017-07-21 20:53 (JST)

Rename/reorganize Advanced prefs buttons

commit:faecefa
author:Dan Stillman
date:2017-07-21 20:47 (JST)
  • Move csledit and cslpreview to a Tools section of the Cite pane as Style Editor and Style Preview
  • Rename “Open about:config” to “Config Editor”
  • Hide about:memory unless devtools.errorconsole.enabled is enabled, which isn’t particularly appropriate and maybe we can find something better, but about:memory doesn’t really need to be visible by default

Closes #1264


Add locale switcher to Advanced prefs

commit:33b4082
author:Dan Stillman
date:2017-07-21 18:30 (JST)

Closes https://www.zotero.org/trac/ticket/1733 (!)


Get Zotero.locale from loaded locale, not from pref

commit:2addf6b
author:Dan Stillman
date:2017-07-21 18:27 (JST)

It was previously set from general.useragent.locale, but that’s not used by default, meaning that date interpretation and some other things might have been incorrect for everyone who didn’t set a locale explicitly and toggle matchOS…


Remove reference to Actions menu (to Report Error)

commit:2bd3aa9
author:gracile-fr
date:2017-07-21 20:12 (JST)

“Report Errors” menu item was in Actions (gear) menu, which has been hidden in 5.0 (cf. 82292eef77701c5f6eb19ec4b65aee0e7ebdbf30). It is now accessible from the Help menu. Adjust Report Error instructions accordingly.


Report automaticSnapshots pref to connector.

commit:40c84ec
author:Adomas Venčkauskas
date:2017-07-21 17:36 (JST)

Part of zotero/zotero-connectors#151


Send Content-Type: text/xml header for WebDAV PROPFIND

commit:39a8e8f
author:Dan Stillman
date:2017-07-21 17:05 (JST)

Test for tag selector search

commit:316a6f9
author:Dan Stillman
date:2017-07-21 07:24 (JST)

Update version

commit:80c70d9
author:Dan Stillman
date:2017-07-21 07:25 (JST)

Fix tag selector search (broken in 6de7fdedf)

commit:a7be544
author:Dan Stillman
date:2017-07-21 05:51 (JST)

Update version

commit:701a3d7
author:Dan Stillman
date:2017-07-20 18:39 (JST)

Take tag selector out of the tab order, for now

commit:6de7fde
author:Dan Stillman
date:2017-07-20 15:59 (JST)

This restores the 4.0 behavior. It’s not ideal, but neither is having to tab through thousands of items to get to the items pane (unless you toggle the tag selector closed first). Hopefully we can come up with a better solution to make the tags accessible.


Update locales from Transifex

commit:c39bdaa
author:Dan Stillman
date:2017-07-20 15:55 (JST)

Fix error on connector ping before site-specific Quick Copy load

commit:cbc05ba
author:Dan Stillman
date:2017-07-19 18:30 (JST)

Tweak .gitignore

commit:e7f9877
author:Frank Bennett
date:2017-07-20 00:12 (JST)

Update chrome.manifest

commit:137fc64
author:Frank Bennett
date:2017-07-20 00:12 (JST)

Adjust connector server test for ece3491e2

commit:84c1367
author:Adomas Venčkauskas
date:2017-07-19 17:55 (JST)

Connector server: respond with collection editability status

commit:ece3491
author:Adomas Venčkauskas
date:2017-07-18 23:13 (JST)

Fix Quick Copy tests after 6d265f448f

commit:cd35962
author:Dan Stillman
date:2017-07-19 17:36 (JST)

Update locales from Transifex

commit:97d46b7
author:Dan Stillman
date:2017-07-19 17:08 (JST)

Alter Quick Copy preferences text

commit:a158e8a
author:Dan Stillman
date:2017-07-19 16:52 (JST)

Closes #1022

Could try to explain site-specific settings, but it’s somewhat complicated (requires the Zotero Connector, uses the last active tab regardless of drag destination), so maybe enough to explain on the linked documentation page.


Sort export translators in Quick Copy settings drop-downs

commit:b3ce918
author:Dan Stillman
date:2017-07-19 16:39 (JST)

Restore site-specific Quick Copy settings

commit:6d265f4
author:Dan Stillman
date:2017-07-19 16:38 (JST)

Using the last URL passed by a connector

Closes https://github.com/zotero/zotero-connectors/issues/145


Clear attachment data change marker when loading primary data

commit:2928752
author:Dan Stillman
date:2017-07-19 07:50 (JST)

Fixes a regression from ef7da3486a4 in which attachment data still shows as changed after a save.


Simplify an array check

commit:cff84a7
author:Dan Stillman
date:2017-07-19 06:13 (JST)

Optimistic updates for item tags box

commit:df353bd
author:Dan Stillman
date:2017-07-19 06:09 (JST)

Add/update/remove rows immediately and save after. If there’s an error during saving, reload the pane.


New state-handling approach for item tag changes

commit:ef7da34
author:Dan Stillman
date:2017-07-17 07:15 (JST)

If this works out I think we’ll want to use this approach for all data layer changes.

Previously, an unsaved change on an object would update its state immediately, which was fine for synchronous code but breaks down if a save involves multiple asynchronous calls, because modifying state after the relevant data has been saved to the DB but before the _changed object has been cleared would mean that new changes would be lost. Now, changes are written to _changedData, and a get for the data first checks _changedData before checking the state property (e.g., _tags) directly. The changedData property is cleared as it’s written, and once the object is saved, the reload updates the state property with the new data.


Allow an array of strings in Zotero.Item::setTags()

commit:09a859d
author:Dan Stillman
date:2017-07-19 06:14 (JST)

New tags will all be of type 0 (manual)


Fix use of multiple search translators

commit:3715c8d
author:Dan Stillman
date:2017-07-18 20:07 (JST)

It was stopping after the first translator, which meant that some ISBN lookups failed if the ISBN wasn’t in Library of Congress.

Regression from 6da0845f4b, which hopefully didn’t have a good reason for this


Move Tools -> Options to Edit -> Preferences on Windows

commit:5268060
author:Dan Stillman
date:2017-07-18 09:23 (JST)

Closes #1167


Fix tag selector font on Windows

commit:76030d2
author:Dan Stillman
date:2017-07-18 09:04 (JST)

Add connector endpoint to retrieve proxies. Closes #1265

commit:6d7dcc4
author:Adomas Venčkauskas
date:2017-07-18 16:25 (JST)

Update version

commit:322b20f
author:Dan Stillman
date:2017-07-18 07:41 (JST)

Update translators

commit:94a3921
author:Dan Stillman
date:2017-07-18 07:25 (JST)

Update locales from Transifex

commit:cf5a943
author:Dan Stillman
date:2017-07-18 07:23 (JST)

Fix calculation of last WebDAV orphaned-file-purge time

commit:78dd1e1
author:Dan Stillman
date:2017-07-18 05:52 (JST)

Purging was happening after every download.


Add “Remove All Tags…” option to item tags box context menu

commit:ba514b8
author:Dan Stillman
date:2017-07-18 05:32 (JST)

Increase default window size to 1000x600

commit:918ae23
author:Dan Stillman
date:2017-07-18 05:28 (JST)

(Plus a little, I think)


Add alignment menu to note context menu that restores justification option

commit:b0c1a9a
author:Dan Stillman
date:2017-07-17 13:12 (JST)

(Even if it’s generally a bad idea without hyphenation)

Also adds unused code that could replace the three alignment buttons in the toolbar with a split-button menu with all four options. We could use this if we needed more space and didn’t think people would mind the extra click when switching between left and center.


Update locales following merge

commit:a3fb70f
author:Frank Bennett
date:2017-07-16 18:36 (JST)

Merge from upstream Zotero

commit:a49f0c9
author:Frank Bennett
date:2017-07-16 18:22 (JST)

Revert -dev in build script

commit:ee081aa
author:Frank Bennett
date:2017-07-16 16:59 (JST)

Fix an integration.js typo. Closes #1263

commit:f829e4d
author:Adomas Venčkauskas
date:2017-07-14 19:40 (JST)

Update locales from Transifex

commit:7ef7a84
author:Dan Stillman
date:2017-07-14 18:12 (JST)

Fix collection context-menu options broken in 02774ac6f

commit:0f965b0
author:Dan Stillman
date:2017-07-14 14:06 (JST)

E.g., selective sync


Fix restoring after closing from full-screen mode on macOS

commit:57881ff
author:Dan Stillman
date:2017-07-14 07:27 (JST)

Prevent infinite loop if search points to itself

commit:ea513ed
author:Dan Stillman
date:2017-07-14 07:07 (JST)

“Report Errors to Zotero…” -> “Report Errors…”

commit:0513cd0
author:Dan Stillman
date:2017-07-14 06:41 (JST)

Update version

commit:b46a2fc
author:Dan Stillman
date:2017-07-14 06:03 (JST)

Fix startup error from empty ‘collection’ search condition

commit:0c49350
author:Dan Stillman
date:2017-07-14 05:10 (JST)

Update locales from Transifex

commit:542d68c
author:Dan Stillman
date:2017-07-13 16:38 (JST)

Fix #1260, Windows Application (menu) key doesn’t work in items pane

commit:df24917
author:Dan Stillman
date:2017-07-13 16:26 (JST)

Log URL for snapshot save timeouts

commit:2d8132b
author:Dan Stillman
date:2017-07-13 14:28 (JST)

Fix crash from tag name collision with Object properties in tag selector

commit:1247896
author:Dan Stillman
date:2017-07-13 14:16 (JST)

Use DOM_VK_

  • codes in itemTreeView keypress listener
commit:4ffbf6f
author:Dan Stillman
date:2017-07-13 08:54 (JST)

Update version

commit:d0eb1c8
author:Dan Stillman
date:2017-07-13 08:00 (JST)

Use getService() for another protocol handler call

commit:ae19ffc
author:Dan Stillman
date:2017-07-13 07:59 (JST)

Follow-up to dd5d3a8668e – not sure if this one matters, but probably can’t hurt


Fix blank window when opening ZotFile’s zotero://open-pdf links

commit:dd5d3a8
author:Dan Stillman
date:2017-07-13 07:25 (JST)

Fixes https://github.com/jlegewie/zotfile/issues/272


Fix id-not-an-integer warning from Show in Library

commit:752e25e
author:Dan Stillman
date:2017-07-13 04:44 (JST)

Fix collection-menu selection via right-click->drag->release or keyboard

commit:02774ac
author:Dan Stillman
date:2017-07-13 04:43 (JST)

Fix ‘too many terms in compound SELECT’ sync error

commit:aad12db
author:Dan Stillman
date:2017-07-12 17:20 (JST)

Fix alignment of “What’s New” in About window

commit:8f2508e
author:Dan Stillman
date:2017-07-12 16:38 (JST)

Update version

commit:63c6972
author:Dan Stillman
date:2017-07-12 16:27 (JST)

Update locales from Transifex

commit:e841d62
author:Dan Stillman
date:2017-07-12 16:27 (JST)

Fix file sync error on Windows from attachment paths with invalid characters

commit:fd2ba1d
author:Dan Stillman
date:2017-07-12 15:58 (JST)

We filter these now, but upgraded databases with bad paths could still exist and cause errors.


Add unused Zotero.Prefs.resetBranch()

commit:a62161d
author:Dan Stillman
date:2017-07-12 14:20 (JST)

I wrote this for account unlinking (since nsIPrefBranch.resetBranch() isn’t implemented) but decided we didn’t want to delete all prefs for that.


Remove unused skipDefaultData property

commit:a7021f8
author:Dan Stillman
date:2017-07-12 14:20 (JST)

Avoid log message about json.collections being unknown after e683b2be0

commit:efae707
author:Dan Stillman
date:2017-07-12 14:18 (JST)

Fix potential error loading support links

commit:d1d6218
author:Dan Stillman
date:2017-07-12 14:17 (JST)

From ZOTERO_CONFIG not being defined. I can’t reproduce this, but I’ve seen it in the logs.


Fix error on account unlink, and delete more files

commit:62fa86a
author:Dan Stillman
date:2017-07-12 14:16 (JST)

Delete everything from data directory except for PDF tools


Fix #1256, Report saving is broken

commit:d242182
author:Dan Stillman
date:2017-07-11 19:14 (JST)

Update version to 5.0.1

commit:9bbef84
author:Dan Stillman
date:2017-07-11 18:22 (JST)

Update submodule

commit:f61cf08
author:Dan Stillman
date:2017-07-11 17:56 (JST)

Update locales from Transifex

commit:b53e5b9
author:Dan Stillman
date:2017-07-11 17:54 (JST)

Zotero.Item::_collections is always an array

commit:a982bd0
author:Dan Stillman
date:2017-07-11 17:44 (JST)

Fix “destFile is not defined” file sync error

commit:18f3c2c
author:Dan Stillman
date:2017-07-11 17:37 (JST)

Remove debug lines

commit:375b434
author:Dan Stillman
date:2017-07-11 17:29 (JST)

Batch object deletions during syncing

commit:701a46b
author:Dan Stillman
date:2017-07-11 17:28 (JST)

Try harder to prevent sync-in-progress messages

commit:fd7c2a6
author:Dan Stillman
date:2017-07-11 15:42 (JST)

Fix array length check in Item.setType()

commit:c701f34
author:Dan Stillman
date:2017-07-11 15:41 (JST)

Fix a potential sync error with child attachments

commit:e683b2b
author:Dan Stillman
date:2017-07-11 14:22 (JST)

If a standalone attachment existed in a collection and then was added to a parent (e.g., via Create Parent Item), and attachment metadata was also changed at the same time (e.g., due to file syncing), the ‘collection item must be top level’ trigger could throw on another syncing computer. To work around this, remove collections first, then make changes to the parentItemID columns, and then add new collections.


Increase snapshot save timeout to 30 seconds

commit:3272387
author:Dan Stillman
date:2017-07-10 12:29 (JST)

We should maybe have a shorter timeout in the connector to show an error and avoid showing the save-to-server dialog, but let’s err on the side of not cancelling saves.


Cancel snapshot saves after 15 seconds

commit:32dedc6
author:Dan Stillman
date:2017-07-10 12:05 (JST)

Otherwise a save could go on forever and the connector will never show an error, and if you quit Zotero the connector will show the save-to-server dialog (though the connector should have its own timeout).


Vacuum database automatically on successful integrity check

commit:e551777
author:Dan Stillman
date:2017-05-30 10:25 (JST)

Firefox does this for Places, so we might as well too.


Update locales from Transifex

commit:6ffd7b1
author:Dan Stillman
date:2017-07-10 05:40 (JST)

Fix Firefox 55 breakage (and remove unnecessary locale lookups)

commit:55b2dc3
author:Dan Stillman
date:2017-07-09 19:56 (JST)

We were manually looking up the current locale in various places and passing it to nsIStringBundleService::createBundle(), but that hasn’t even been a supported argument for years. (I assume it was a long time ago?)


Allow dragging onto welcome text

commit:59edca7
author:Dan Stillman
date:2017-07-09 18:49 (JST)

Make About window narrower

commit:9151246
author:Dan Stillman
date:2017-07-09 10:31 (JST)

Update non-English strings

commit:2ca10b3
author:Dan Stillman
date:2017-07-09 08:14 (JST)

Update About dialog

commit:a7e2e73
author:Dan Stillman
date:2017-07-09 08:06 (JST)
  • Replace Developers section with text that links to RRCHNM, the credits

page, and Get Involved. - Remove dedicated zotero.org link - Only show link underlines on hover


Update locales from Transifex

commit:73ac743
author:Dan Stillman
date:2017-07-09 06:49 (JST)

Update translators

commit:e5972b7
author:Dan Stillman
date:2017-07-09 06:25 (JST)

Additional checks for stopped sync

commit:2ba773d
author:Dan Stillman
date:2017-07-08 08:05 (JST)

Update locales from Transifex

commit:043c0ac
author:Dan Stillman
date:2017-07-08 07:29 (JST)

Add “Delete Automatic Tags in This Library…” option to tag selector menu

commit:de3b47f
author:Dan Stillman
date:2017-07-08 07:14 (JST)

I think it might be worth having a tag management window that lets you view tags as a grid, sort by column (e.g., type), select ranges, delete, consolidate, etc., but until then, this fulfills a popular request.


Use spread operator in flattenArguments

commit:941ae54
author:Dan Stillman
date:2017-07-08 07:18 (JST)

Allow single string in Zotero.Utilities.pluralize()

commit:f2af774
author:Dan Stillman
date:2017-07-08 07:18 (JST)

Zotero.Utilities.pluralize(5, ‘tag’) will produce ‘tags’ automatically


Fix full-text sync tests after 1da18e4ca79

commit:e2d7c7e
author:Dan Stillman
date:2017-07-07 19:23 (JST)

Update 2x icon styles

commit:c55cacf
author:Dan Stillman
date:2017-07-07 18:21 (JST)

Log errors from Zotero.serial()

commit:3b2d7eb
author:Dan Stillman
date:2017-07-07 18:20 (JST)

And output errors in concurrentCaller if not otherwise logged


Update deprecated openPreferences() call

commit:71fb054
author:Dan Stillman
date:2017-07-07 18:20 (JST)

Update non-English strings

commit:cb913ff
author:Dan Stillman
date:2017-07-07 18:30 (JST)

Add “Stop Sync” button

commit:1da18e4
author:Dan Stillman
date:2017-07-07 18:18 (JST)

Stops all syncing (not just file syncing like in 4.0) as soon as possible.


Update non-English strings

commit:7729dca
author:Dan Stillman
date:2017-07-07 16:40 (JST)

Add intro text to middle pane when My Library is empty

commit:b07fdc6
author:Dan Stillman
date:2017-07-07 16:20 (JST)

This replaces the Quick Start Guide item in earlier versions.

Also increases size of My Publications intro text when the window is wider.


Moving Utilities.itemToServerJSON() to the connector codebase

commit:1ddb380
author:Adomas Venčkauskas
date:2017-07-06 19:37 (JST)

See Zotero.Item.toJSON() for similar functionality


Use ‘async’ configOptions property to indicate promisified translators

commit:f7c1c56
author:Dan Stillman
date:2017-07-06 04:25 (JST)

Instead of >”2017-07-05”

Addresses https://github.com/zotero/translators/issues/1353


Fix error in export options window if translator has no options

commit:5ff5ea8
author:Dan Stillman
date:2017-07-06 04:25 (JST)

Fix overlapping lines in attachment box with empty title

commit:53c3f62
author:Dan Stillman
date:2017-07-06 00:33 (JST)

Make 909b4b31c80 apply to search translators too, and fix tests

commit:198bd70
author:Dan Stillman
date:2017-07-05 22:15 (JST)

Addresses https://github.com/zotero/translators/issues/1353


Assume import translators updated after today are async

commit:909b4b3
author:Dan Stillman
date:2017-07-05 21:52 (JST)

See https://github.com/zotero/translators/issues/1353 for details.

minVersion is problematic for various reasons, so this is safer.


Do a manual check from the repo when enabling auto translator/style updates

commit:d73fc63
author:Dan Stillman
date:2017-07-05 18:45 (JST)

Fix streaming server connection when auto-sync is on with no credentials

commit:d40822c
author:Dan Stillman
date:2017-07-05 18:45 (JST)

Update translators

commit:dc71af9
author:Dan Stillman
date:2017-07-05 18:18 (JST)

Update locales from Transifex

commit:22e99a4
author:Dan Stillman
date:2017-07-05 18:17 (JST)

Update translators/styles at startup and on push notifications

commit:86cf7cb
author:Dan Stillman
date:2017-07-05 07:03 (JST)

Previously, if a translator or style was fixed, people didn’t get the fix until their client checked the repository for updates, which could take up to 24 hours. Now, in addition to checking once a day, we check every time Zotero is started and also when we receive a notification from the streaming server, which happens immediately after a translators or style is updated on GitHub. To avoid DDoSing ourselves, the notification includes a random delay (within a given period) before the update is triggered by the client.

The streaming server connection is now made when either “Automatically check for updated translators and styles” or “Sync automatically” is enabled. It can be disabled via the extensions.zotero.streaming.enabled pref.


Update locales from Transifex

commit:b476c7c
author:Dan Stillman
date:2017-07-03 16:11 (JST)

Update submodules

commit:7769b5d
author:Dan Stillman
date:2017-07-03 16:03 (JST)

Fix WebSocket reconnect delay

commit:c867b3b
author:Dan Stillman
date:2017-07-02 14:44 (JST)

Only reset delay generator after regular message, not on connect, because a subscription failure happens after a connect. Also cancel reconnect if auto-sync is disabled during the failure delay.


Only skip retry for WebSocket errors between 4400 and 4499

commit:2efd712
author:Dan Stillman
date:2017-07-02 14:32 (JST)

Update locales from Transifex

commit:72feaab
author:Dan Stillman
date:2017-07-01 20:07 (JST)

Clean up Sync -> Reset pane

commit:dc89cfb
author:Dan Stillman
date:2017-07-01 19:58 (JST)
  • Hide radio buttons for now, since there’s only one option in each

section - Tweak text for file sync history reset


Add Sync.Storage.Local.updateSyncStates()

commit:88088c6
author:Dan Stillman
date:2017-07-01 19:26 (JST)

This speeds up updating of sync states, particularly after resetting file sync history.


Don’t calculate total file size for every uploaded attachment

commit:b72f1c2
author:Dan Stillman
date:2017-07-01 19:22 (JST)

This required checking the file size of every file (including auxiliary snapshot files) in every attachment to be uploaded, and it was an estimate anyway, because snapshots are compressed, so we kept track of the compression ratio, but there was no particular reason to think later files would have the same ratio… In any case, we’re not currently displaying file sync progress in 5.0 anyway, and while we should, we can probably just show a count of attachments remaining.


Add .contentType and .charset options for importFromFile()

commit:9a3ff2d
author:Dan Stillman
date:2017-07-01 19:20 (JST)

And use them in new importTextAttachment() and importHTMLAttachment() test support functions. These can be used to avoid needing a hidden browser for determining the character set of the imported text documents.


Automatically run JS build process before tests if not running

commit:b1fad5a
author:Dan Stillman
date:2017-07-01 19:28 (JST)

Close directory iterator in Attachments.hasMultipleFiles()

commit:b633038
author:Dan Stillman
date:2017-07-01 07:08 (JST)

This was leaving a file descriptor to the directory open during file syncing.


Don’t leave file descriptor open in md5Async()

commit:22eab3e
author:Dan Stillman
date:2017-07-01 06:54 (JST)

This could cause “Too many open files” errors during file syncing


Detect full disk during data migration on Windows (hopefully)

commit:536d725
author:Dan Stillman
date:2017-07-01 05:59 (JST)

Fix “not a directory” file sync error

commit:010bf3b
author:Dan Stillman
date:2017-07-01 05:59 (JST)

Update non-English strings

commit:16b2e82
author:Dan Stillman
date:2017-06-29 17:11 (JST)

Move connector install option to Tools menu

commit:aca774e
author:Dan Stillman
date:2017-06-29 16:50 (JST)

And rename from “Install Browser Connectors…” to “Install Browser Connector”


Update non-English strings

commit:2119b5a
author:Dan Stillman
date:2017-06-28 05:26 (JST)

“Install Browser Extensions” -> “Install Browser Connectors”

commit:f6ac173
author:Dan Stillman
date:2017-06-28 05:23 (JST)

And change link from /extensions to /download/connectors


Merge new English string

commit:a56af4a
author:Dan Stillman
date:2017-06-27 14:10 (JST)

Show error and doc prefs if style can’t be found or retrieved

commit:9b54ca9
author:Dan Stillman
date:2017-06-27 14:09 (JST)

Previously a 404 downloading the file would prevent opening the doc prefs window.


Add .SOURCE string to version in install.rdf

commit:db56acf
author:Frank Bennett
date:2017-06-27 13:19 (JST)

Don’t enforce Host header in translation server

commit:a15261b
author:Dan Stillman
date:2017-06-27 08:01 (JST)

Fixes #1251 Fixes zotero/translation-server#48


Update locales from Transifex

commit:b2eea91
author:Dan Stillman
date:2017-06-27 08:00 (JST)

Add “Install Browser Extensions…” menu option

commit:1d56497
author:Dan Stillman
date:2017-06-27 07:49 (JST)

Allow Zotero.Server requests with Host: localhost

commit:9372979
author:Dan Stillman
date:2017-06-26 20:52 (JST)

Previously only Host: 127.0.0.1 was allowed. (The check prevents a DNS rebinding attack.)

This allows requests to translation-server using localhost (zotero/translation-server#48).

Fixes #125


Fix permissions errors in child translators in translation-server

commit:df22169
author:Dan Stillman
date:2017-06-26 20:19 (JST)

Fix a debug log line

commit:2414ec6
author:Adomas Venčkauskas
date:2017-06-26 15:49 (JST)

Merge branch ‘jurism-5.0-dev’ into jurism-5.0

commit:f21f89e
author:Frank Bennett
date:2017-06-26 12:48 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:5ec969c
author:Frank Bennett
date:2017-06-26 12:47 (JST)

Fix signatures on itemToCSLJSON

commit:bb2004c
author:Frank Bennett
date:2017-06-26 12:46 (JST)

Persist export format selection

commit:9a87a69
author:Frank Bennett
date:2017-06-26 08:13 (JST)

Update translators

commit:af84cde
author:Frank Bennett
date:2017-06-26 08:12 (JST)

Partial fix for CSL JSON export in translation-server

commit:56f9f04
author:Dan Stillman
date:2017-06-25 17:38 (JST)

Zotero.Item doesn’t exist in translation-server

Addresses zotero/translation-server#12


Fix JS compiling in watch mode

commit:e9a80cb
author:Dan Stillman
date:2017-06-25 08:24 (JST)

Support false as deprecated translate() argument

commit:145a45e
author:Dan Stillman
date:2017-06-25 08:24 (JST)

Check for Zotero.Prefs.getAsync() explicitly, not with isConnector

commit:8f63a5e
author:Dan Stillman
date:2017-06-25 08:23 (JST)

translation-server doesn’t have Zotero.Prefs.getAsync() and isn’t a connector


Update submodules

commit:5aaefff
author:Dan Stillman
date:2017-06-24 14:25 (JST)

Update citeproc-js to 1.1.171

commit:2ab46d3
author:Dan Stillman
date:2017-06-24 14:24 (JST)

Fix infinite loop restoring from trash if item has itself as relation

commit:d8f8d8a
author:Dan Stillman
date:2017-06-24 14:22 (JST)

Remove some code that’s unnecessary now that we’re Fx52+ everywhere

commit:e89778c
author:Dan Stillman
date:2017-06-23 17:59 (JST)

Fix “Generate Report from Collection” when sorting by creator or date

commit:ef1715e
author:Dan Stillman
date:2017-06-22 18:48 (JST)

“A new database file has been created” -> “A new database has been created”

commit:92435f3
author:Dan Stillman
date:2017-06-22 06:03 (JST)

Tweak incompatible-DB error text

commit:79b98dd
author:Dan Stillman
date:2017-06-22 06:02 (JST)

Fix for some child items not showing up

commit:f2cc220
author:Dan Stillman
date:2017-06-21 19:50 (JST)

https://forums.zotero.org/discussion/66140/5-0-beta-missing-item-attachments


Update Travis to Firefox 54.0 and 52.0.3

commit:e825781
author:Dan Stillman
date:2017-06-21 14:23 (JST)

Windows uses 52.2.0esr, but we need an unbranded build, and there don’t seem to be unbranded builds of the ESR.


Add build/ directory to Travis cache

commit:d2400de
author:Dan Stillman
date:2017-06-21 14:23 (JST)

Merge new English strings

commit:38652f9
author:Dan Stillman
date:2017-06-21 12:12 (JST)

Update broken string in ancient-database dialog

commit:abf08de
author:Dan Stillman
date:2017-06-21 11:54 (JST)

Update translators

commit:4419348
author:Frank Bennett
date:2017-06-21 08:33 (JST)

Better build process (#1248)

commit:b53fabb
author:Tom Najdek
date:2017-06-21 08:18 (JST)
  • Remove gulp, replace with custom scripts
  • Symlink entire dirs where possible (fixes #1232)
  • Significantly speed up subsequent builds (fixes #1238)
  • Watch process now observes new/removed files, not only changed
  • Add ignoreMask, exclude all files with names starting with a #
  • Better logging during builds
  • Update travis.yml to use new, non-gulp-based build

Fix error from f3b461ae1d when no duplicate items found

commit:3259b63
author:Dan Stillman
date:2017-06-20 18:58 (JST)

Fix getAsync() integer warning when highlighting item collections

commit:041f793
author:Dan Stillman
date:2017-06-20 18:39 (JST)

Don’t use DB transaction when loading Duplicates Items

commit:f3b461a
author:Dan Stillman
date:2017-06-20 18:35 (JST)

This should help avoid some timeouts when clicking into that view.


Don’t schedule feed checks during tests

commit:a2d874c
author:Dan Stillman
date:2017-06-20 13:51 (JST)

Tests create lots of fake feeds with invalid URLs, so auto-updating would otherwise hang and block the explicit feed updates done by other tests.


Add -e flag to runtests.sh to stop tests after a given file

commit:c11f106
author:Dan Stillman
date:2017-06-20 13:47 (JST)

This is useful when trying to debug an error that only happens after a number of other tests have run – specify -e and run tests from either an earlier file with -s or from the beginning.


Refactor Connector.callMethod calls to use the promisified form

commit:dcfddac
author:Adomas Venčkauskas
date:2017-06-19 18:18 (JST)

Temporary checkin of modded build.sh

commit:abb3983
author:Frank Bennett
date:2017-06-19 16:25 (JST)

Fix legacy syntax in Juris-M code.

commit:f791618
author:Frank Bennett
date:2017-06-19 16:17 (JST)

Update locales from upstream Zotero

commit:28de8fc
author:Frank Bennett
date:2017-06-19 16:16 (JST)

Don’t run feeds update until after schema update promise

commit:7c020da
author:Dan Stillman
date:2017-06-19 13:53 (JST)

And tweak feed scheduling in general


Don’t initialize DB backup idle observer until after schema init

commit:1372949
author:Dan Stillman
date:2017-06-19 13:49 (JST)

Disable reset translators/styles buttons while in progress

commit:b590c43
author:Dan Stillman
date:2017-06-19 13:43 (JST)

We should have a better progress notification, but this is better than nothing.


Additional prefs in tests to bypass Telemetry prompt

commit:26145c3
author:Dan Stillman
date:2017-06-19 13:42 (JST)

Maybe fix browser test failures by preloading translators

commit:1a0f125
author:Dan Stillman
date:2017-06-19 13:40 (JST)

Retry objects from sync queue on first sync of session and manual sync

commit:444d779
author:Dan Stillman
date:2017-06-19 04:37 (JST)

Previously they were retried only on a backoff schedule and after a client upgrade, but that would make it difficult to report errors (because you’d see the error but it would then go away if you clicked Sync again).


Add getKeys() method to API Client

commit:15a0f3b
author:Dan Stillman
date:2017-06-18 21:42 (JST)

Restore locally deleted collections and searches that changed remotely

commit:47741e7
author:Dan Stillman
date:2017-06-18 18:49 (JST)

Also restore items that were in the collections


“Zotero Standalone” -> “Zotero” in a couple messages

commit:24b43ae
author:Dan Stillman
date:2017-06-18 12:05 (JST)

On missing data dir, remove “Restart Later” for “Use Default” option

commit:6144c8f
author:Dan Stillman
date:2017-06-18 11:30 (JST)

Missing data directory tweaks

commit:13283b0
author:Dan Stillman
date:2017-06-18 11:14 (JST)
  • Fix “Locate” button
  • Don’t offer “Restart Later” option after selecting new location
  • Show “Quit” instead of “OK”

Merge from upstream Zotero

commit:cf057db
author:Frank Bennett
date:2017-06-18 08:19 (JST)

Update jurisdiction (add QB)

commit:2a4b750
author:Frank Bennett
date:2017-06-17 07:12 (JST)

Never auto-select new groups, since they always come from syncs

commit:859c506
author:Dan Stillman
date:2017-06-16 18:56 (JST)

Fixes test failure from 2e74cd7831


Don’t select new feeds or groups during sync

commit:2e74cd7
author:Dan Stillman
date:2017-06-16 18:40 (JST)

Remove Zotero_Browser tests for new Firefox windows

commit:6904183
author:Dan Stillman
date:2017-06-16 17:52 (JST)

I’m not sure if we need the browser tests at all – we still translate some things via hidden browsers, and I’m not sure what we have that tests that – but we definitely don’t need to test saving before the Zotero pane is opened.


Disable full-text content processor during sync and on pref off

commit:c6cb469
author:Dan Stillman
date:2017-06-16 17:49 (JST)

Turning off full-text content syncing now stops the background processor


Fix skipClientDateModifiedUpdate DataObject save option

commit:2f93065
author:Dan Stillman
date:2017-06-16 14:56 (JST)

Fix one cause of “operation timed out” during sync

commit:8de0b02
author:Dan Stillman
date:2017-06-16 14:50 (JST)

Remove some unnecessary transactions in Sync.Data.Local


Bail on error in Travis

commit:3e0ab63
author:Dan Stillman
date:2017-06-16 07:55 (JST)

I think it’s more useful to see that tests failed sooner than to see all errors from a test run, particularly since earlier failures often cause meaningless later failures anyway. And since spurious failures are fairly common, this will also let us restart tests more quickly without searching for “[FAIL]” in the output while it’s running.

This does mean that, if there’s a legitimate test failure you overlooked, it might be worth running tests locally after fixing it to make sure there aren’t other instances of the problem that can be fixed at the same time.


Try to reduce impact of full-text content processor

commit:5c45652
author:Dan Stillman
date:2017-06-16 07:22 (JST)
  • Don’t start checking for idle until UI is ready + 30 seconds
  • Increase idle delay from 5 seconds to 30 seconds
  • Increase interval from 100 ms to 200 ms

Add encrypted AWS_SECRET_ACCESS_KEY to Travis config

commit:0d592a9
author:Dan Stillman
date:2017-06-16 05:27 (JST)

Follow-up to c25d6bf4692


Deploy before running tests (#1246)

commit:384ce23
author:Martynas Bagdonas
date:2017-06-15 23:39 (JST)

Move start page URL to config

commit:97bac9f
author:Dan Stillman
date:2017-06-15 15:39 (JST)

Fix “o is undefined” sync error

commit:d9eb8ff
author:Dan Stillman
date:2017-06-14 20:52 (JST)

Disable debug output for Zotero.Date.strToDate()

commit:1bb6217
author:Dan Stillman
date:2017-06-14 15:58 (JST)

Too messy, and unlikely that we need it in submitted output


Ignore note markup conflicts without cache when text content matches

commit:4032edc
author:Dan Stillman
date:2017-06-14 15:35 (JST)

Close prefs window after WebDAV Verify Server tests

commit:3ebc238
author:Dan Stillman
date:2017-06-14 16:36 (JST)

Fix incorrect purging of files on WebDAV

commit:ccb3035
author:Dan Stillman
date:2017-06-14 16:18 (JST)

Don’t repeat filenames in results from WebDAV _deleteStorageFiles()

commit:700aa53
author:Dan Stillman
date:2017-06-14 15:59 (JST)

Only purge orphaned WebDAV files if downloads completed successfully

commit:db6e984
author:Dan Stillman
date:2017-06-14 13:41 (JST)

Sort groups in Libraries to Sync window

commit:d2d5896
author:Dan Stillman
date:2017-06-14 10:30 (JST)

Update package.json and package-lock.json

commit:7dd9cee
author:Dan Stillman
date:2017-06-14 07:04 (JST)

Update locales from Transifex

commit:88089e2
author:Dan Stillman
date:2017-06-14 07:03 (JST)

Merge pull request #1245 from adomasven:feature/prompt-different-drive-migration

commit:5e4d3a3
author:Dan Stillman
date:2017-06-14 06:17 (JST)

Don’t auto-migrate data dir if target on a different drive


Don’t auto-migrate data dir if target on a different drive

commit:a17b486
author:Adomas Venčkauskas
date:2017-06-12 20:14 (JST)

See https://forums.zotero.org/discussion/comment/277632/#Comment_277632


Fix typo in config.js

commit:3601cdd
author:Frank Bennett
date:2017-06-12 19:39 (JST)

Merge changes from upstream Zotero master

commit:1d797b4
author:Frank Bennett
date:2017-06-12 15:21 (JST)

Update jurisdiction data

commit:2e6528c
author:Frank Bennett
date:2017-06-12 14:42 (JST)

Updates for submodules

commit:f239ddc
author:Frank Bennett
date:2017-06-12 07:21 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:854ddc3
author:Frank Bennett
date:2017-06-11 16:23 (JST)

Update translators

commit:737c349
author:Frank Bennett
date:2017-06-11 16:22 (JST)

Better logging when revealing attachment in filesystem

commit:98544ed
author:Dan Stillman
date:2017-06-09 03:10 (JST)

Better logging for getAsync() non-integer errors

commit:8913178
author:Dan Stillman
date:2017-06-09 03:10 (JST)

Merge pull request #1243 from tnajdek/master

commit:0495f29
author:Dan Stillman
date:2017-06-08 01:37 (JST)

Fix a problem with race condition during builds


Symlink task should not have clean task as pre-requisite

commit:3a6776f
author:Tom Najdek
date:2017-06-08 01:32 (JST)

Fix context menu options for multi-item selection (broken in 5d16352f57)

commit:b5424b4
author:Dan Stillman
date:2017-06-08 00:50 (JST)

Update submodules

commit:718a0dd
author:Frank Bennett
date:2017-06-06 21:55 (JST)

Upload Travis ZIPs to subdirectory of download bucket

commit:ad37741
author:Dan Stillman
date:2017-06-06 17:59 (JST)

Update translators

commit:d81e463
author:Dan Stillman
date:2017-06-06 17:37 (JST)

Update citeproc-js to 1.1.170

commit:75ddd87
author:Dan Stillman
date:2017-06-06 17:35 (JST)

Add package-lock.json

commit:d9a8502
author:Dan Stillman
date:2017-06-06 17:29 (JST)

Make uploaded build ZIPs publicly readable

commit:a80d29d
author:Dan Stillman
date:2017-06-06 17:28 (JST)

Tweak build for CL

commit:6270afa
author:fbennett
date:2017-06-06 16:57 (JST)

Travis deployment updates

commit:294102b
author:Dan Stillman
date:2017-06-06 15:41 (JST)

Use commit hash as ZIP filename and only build on release channel


Merge pull request #1240 from tnajdek/master

commit:98f1ac5
author:Dan Stillman
date:2017-06-06 15:18 (JST)

Tweaks to make build work on Windows


Relax last-sync-time check in sync runner test

commit:cd6079d
author:Dan Stillman
date:2017-06-06 15:14 (JST)

Upload ZIP of build files to S3 after successful Travis run

commit:dcb3d74
author:Dan Stillman
date:2017-06-06 14:52 (JST)

Ignore all bluebird files when processing during the build

commit:4ca3cf1
author:Tom Najdek
date:2017-06-04 02:25 (JST)

Tweak test runner to work in MSYS environment on Windows

commit:e86bbfb
author:Tom Najdek
date:2017-06-04 01:54 (JST)

On Windows, copy files instead of symlinking

commit:e207124
author:Tom Najdek
date:2017-06-04 01:48 (JST)

Add support for glob in babel-worker ignored paths

commit:c335099
author:Tom Najdek
date:2017-06-04 00:50 (JST)
  • Also fixes an issue with handling paths on Windows

Translators tweak

commit:fd90e39
author:Frank Bennett
date:2017-06-06 12:27 (JST)

Ensure build process exits with non-zero result on failure

commit:f98ccde
author:Tom Najdek
date:2017-06-02 22:18 (JST)
  • During build, error is printed out with stack and process exits
  • During development, initial build behaves as above, however when watching files, errors are displayed but watch process does not exit allowing fixes without a complete rebuild.

Temporarily disable test for non-integer getAsync()

commit:b79ecfb
author:Dan Stillman
date:2017-06-05 16:00 (JST)

Make non-integer id passed to getAsync() non-fatal for now

commit:71d636e
author:Dan Stillman
date:2017-06-05 10:35 (JST)

Follow-up to 4e1937680f7


Fix report generation after 4e1937680f7

commit:653f041
author:Dan Stillman
date:2017-06-05 10:33 (JST)

Update citeproc-js

commit:494683c
author:fbennett
date:2017-06-04 18:37 (JST)

Protect against invalid creators embedded in documents (avoid breaking extraction)

commit:35da4b0
author:fbennett
date:2017-06-04 18:35 (JST)

Fix logging of unhandled promise rejections

commit:47f7f3a
author:Dan Stillman
date:2017-06-02 23:37 (JST)

Fix separate note window (regression from 4e1937680f)

commit:4b0e2a9
author:Dan Stillman
date:2017-06-02 23:36 (JST)

Add alternative to padStart for test in Fx45

commit:898a1dc
author:Dan Stillman
date:2017-06-02 05:44 (JST)

Add explicit npm i

commit:53842ad
author:Dan Stillman
date:2017-06-02 05:08 (JST)

(Travis might call this automatically before ‘script’, but we need it before ‘gulp build’, and we don’t want to do ‘gulp build’ in ‘script’, because the output isn’t relevant and if it fails there’s no need to run the tests.)


Use Node.js mode on Travis

commit:595ab59
author:Dan Stillman
date:2017-06-02 05:02 (JST)

Fix Firefox 54 download on Travis

commit:140217d
author:Dan Stillman
date:2017-06-02 04:46 (JST)

Remove sinon-as-promised from package.json

commit:201af23
author:Dan Stillman
date:2017-06-02 04:44 (JST)

Switch to Firefox 54 Beta on Travis

commit:6c9f386
author:Dan Stillman
date:2017-06-02 04:34 (JST)

Run build step before running tests on Travis

commit:d889d26
author:Dan Stillman
date:2017-06-02 04:34 (JST)

Fix some breakage from 013dc958b3

commit:05ff16c
author:Dan Stillman
date:2017-06-02 04:33 (JST)

Update some Sinon reset() calls

commit:ede03f4
author:Dan Stillman
date:2017-06-02 04:30 (JST)

In Sinon 2, reset() now resets both behavior and history, so if a stub specifies behavior and we want to use it again, we have to call resetHistory().


Enable retainLines in Babel config

commit:522391b
author:Dan Stillman
date:2017-06-02 04:23 (JST)

Addresses #1235 (maybe sufficiently, depending on how much we care about wacky code in the builds)


Merge pull request #1239 from tnajdek/master

commit:04db119
author:Dan Stillman
date:2017-06-02 04:38 (JST)

Enable running tests against babelized code in build/dir


Tweak test syntax that breaks with current version of chai-as-promised

commit:a59b78e
author:Tom Najdek
date:2017-06-01 01:20 (JST)
  • Second parameter should be an optional message, however is treated as a string that should be contained in the error message

Remove “Error:” expected in error messages.

commit:4ec6925
author:Tom Najdek
date:2017-06-01 00:52 (JST)
  • “Error:” seems to have been injected into the message by Bluebird, but that’s no longer the case

Modernize sinon.stub() calls

commit:063e13e
author:Tom Najdek
date:2017-06-01 00:44 (JST)

Add a shutdown hook in Zotero.Prefs to unregister observer

commit:506b358
author:Tom Najdek
date:2017-06-01 00:36 (JST)
  • Without this, preference change observers stack, triggering multiple times if Zotero is re-initialized multiple times within the same browser instance (like in tests)

Re-introduce custom implementation of setTimeout

commit:aa6037c
author:Tom Najdek
date:2017-06-01 00:32 (JST)
  • Resolves issues with some tests failing

Support generators in tests via coMocha, instead of custom code

commit:289b049
author:Tom Najdek
date:2017-06-01 00:30 (JST)
  • coMocha offers better error stack trace

Fixes and tweaks to make tests work with babelized code

commit:14bf318
author:Tom Najdek
date:2017-06-01 00:28 (JST)
  • Use mocha, chai & sinon from the npm. As of sinon 2.0 sinon-as-promised is no longer required so it is removed
  • Tweak code to re-use the same loader with the same environment throghout the code
  • Introduce browserify step for testing tools that only provide node-compatible libraries (sinon, chai-as-promised)
  • Introduce copy step for test data to resolve multiple issues with tests depending on files not being symlinks
  • Re-introduce custom implementation of setTimeout to resolve issues with few tests
  • Re-introduce custom Bluebird Promises config & monkey patch

Run tests from build dir

commit:748c302
author:Dan Stillman
date:2017-05-24 14:01 (JST)

Remove stray code line

commit:ad2cee2
author:fbennett
date:2017-05-31 17:25 (JST)

Protect against empty authors the creep through

commit:fe85f02
author:fbennett
date:2017-05-31 17:07 (JST)

Protect against empty creators in multi segments

commit:0c1ed96
author:fbennett
date:2017-05-31 16:48 (JST)

Update submodules

commit:aba2d7b
author:fbennett
date:2017-05-31 16:15 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:b02c03c
author:fbennett
date:2017-05-31 16:08 (JST)

Protect against empty creator with no multi segment

commit:996ff61
author:fbennett
date:2017-05-31 16:08 (JST)

Log Zotero.alert() calls to the terminal

commit:a55852e
author:Dan Stillman
date:2017-05-31 13:43 (JST)

Fix auto-restore of automatic backup on DB corruption error

commit:61452a8
author:Dan Stillman
date:2017-05-31 13:42 (JST)

Restore cleaner error and item-selection button for note-too-long error

commit:013dc95
author:Dan Stillman
date:2017-05-31 13:07 (JST)

Don’t show “Remove Item from Collection” for child items

commit:5d16352
author:Dan Stillman
date:2017-05-28 07:38 (JST)

Test forthcoming once tests are working again


Don’t break getLocaleCollation() in Firefox <54 (after a73b2403b)

commit:aa05920
author:Dan Stillman
date:2017-05-27 18:37 (JST)

Update help URLs and move to config file

commit:d6c36ae
author:Dan Stillman
date:2017-05-27 08:10 (JST)

Fix getLocaleCollation() in Firefox 54

commit:a73b240
author:Dan Stillman
date:2017-05-27 18:29 (JST)

Avoid exit on test error

commit:df2f97d
author:Frank Bennett
date:2017-05-27 08:35 (JST)

Update styles

commit:ae36b1e
author:Frank Bennett
date:2017-05-27 08:24 (JST)

Use gfind if available (for Mac OS)

commit:24c6bc4
author:Frank Bennett
date:2017-05-27 08:20 (JST)

Additional locale service updates for Firefox 54 compatibility

commit:d5a8a34
author:Dan Stillman
date:2017-05-26 14:37 (JST)

Follow-up to 0ac37ab65a4


Fix crashing for some actions in duplicate items

commit:7fc188b
author:Dan Stillman
date:2017-05-25 07:20 (JST)

Necessary after more strict error handling in c4411e1ad3e


Increase gulp.watch() interval to decrease CPU usage

commit:8f116f6
author:Dan Stillman
date:2017-05-25 06:59 (JST)

This brings idle CPU usage down to 1.5% from 14% for me.


Restore logging of unhandled errors from Bluebird (since 9aa057edee)

commit:8bc76dd
author:Dan Stillman
date:2017-05-25 06:47 (JST)

Convert non-standard octal escape sequences to hex in test runner

commit:1e45928
author:Dan Stillman
date:2017-05-24 14:12 (JST)

Add example async/await to test Babel transform

commit:aa321f3
author:Dan Stillman
date:2017-05-24 13:59 (JST)

Move require() into ZoteroContext and fix Bluebird module path

commit:6afc58a
author:Dan Stillman
date:2017-05-24 13:58 (JST)

Update citeproc-js to 1.1.169

commit:319edae
author:Dan Stillman
date:2017-05-24 06:39 (JST)

Display relative path to files in build output

commit:79ed9e8
author:Dan Stillman
date:2017-05-24 06:25 (JST)

Not just filenames


Merge pull request #1230 from tnajdek/babel

commit:9cd0c5a
author:Dan Stillman
date:2017-05-24 06:00 (JST)

Introduce a build system


Introduce a build system

commit:9aa057e
author:Tom Najdek
date:2017-05-23 08:01 (JST)
  • Add a multi-process, gulp-based build system to support es6 features, async/await, jsx and scss
  • Add a package.json to support dependency management and allow starting the build process via npm
  • Replace embedded Bluebird library with npm-installed one
  • Add react, react-dom and web-library
  • Introduce a custom require() loader in include.js as well as a minimal local require() implementation in various other places

Rebrand in about.xul

commit:5d2834d
author:fbennett
date:2017-05-23 15:34 (JST)

Rebrand in en-US locale

commit:85301f3
author:fbennett
date:2017-05-23 15:33 (JST)

Avoid a warning from a storageRequest test from the item not existing

commit:c0f7f60
author:Dan Stillman
date:2017-05-23 15:11 (JST)

Convert some object ids from strings to integers after 4e1937680

commit:e1fb28f
author:Dan Stillman
date:2017-05-23 15:10 (JST)

Throw error if non-number is passed to Zotero.DataObjects.getAsync()

commit:4e19376
author:Dan Stillman
date:2017-05-23 15:04 (JST)

Previously, if an id was psased as a string and the id existed in the cache, an error wouldn’t be thrown, but if there id wasn’t in the cache (e.g., because it was in an unloaded library) it would. This requires an integer in all cases.

Note that, among other things, any code that gets ids from object keys will need to convert them to integers before passing to getAsync().


Update translators

commit:a550f94
author:fbennett
date:2017-05-23 15:02 (JST)

Change repository URL

commit:1db0845
author:fbennett
date:2017-05-23 14:40 (JST)

Skip edit check if skipAll is passed to object save

commit:265df6d
author:Dan Stillman
date:2017-05-23 06:29 (JST)

Firefox 54 compatiblity for locale service

commit:0ac37ab
author:Dan Stillman
date:2017-05-22 19:04 (JST)

Services.locale.getApplicationLocale() -> getAppLocale() (nsILocaleService -> mozILocaleService)

It’s possible this will fix some of the locale resolution problems in Standalone:

“This is actually a meaningful change because the old one was actually using OS locale for platforms other than Windows. The new one is using the app locale for all platforms.” [1]

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1346674#c0


Firefox 54 compatibility: File.createFromFileName() returns a promise

commit:1b8704f
author:Dan Stillman
date:2017-05-22 19:04 (JST)

Firefox 54 compatibility: rename “new” and “delete” XBL methods

commit:a3eea03
author:Dan Stillman
date:2017-05-22 19:03 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:fa4e791
author:fbennett
date:2017-05-21 23:09 (JST)

Adjustments to port number

commit:33de9a6
author:fbennett
date:2017-05-21 21:46 (JST)

Shift comms port from 23119 to 24119 for Juris-M

commit:d28d535
author:fbennett
date:2017-05-21 21:37 (JST)

Update locales from upstream Zotero

commit:c019f8b
author:fbennett
date:2017-05-21 16:42 (JST)

Merge from upstream Zotero

commit:b00e675
author:fbennett
date:2017-05-21 16:40 (JST)

Fix refresh when opening related-item box in note editor

commit:ddc9989
author:Dan Stillman
date:2017-05-20 01:01 (JST)

Make a missing related item not fatal

commit:1cbc244
author:Dan Stillman
date:2017-05-20 00:21 (JST)

Since item relations are synced with individual items, an item can exist before the item it’s related to has been downloaded.


Remove related-item relations when deleting item

commit:fc4eb53
author:Dan Stillman
date:2017-05-19 21:30 (JST)

Remove reference to ‘publications’ library type in URI.getLibraryPath()

commit:8edd883
author:Dan Stillman
date:2017-05-19 21:19 (JST)

Add Zotero.URI.getURIItemLibraryKeyFromDB()

commit:90a27f8
author:Dan Stillman
date:2017-05-19 21:09 (JST)

Allows getting libraryID and key without relying on library data being loaded (e.g., at startup)


Allow functions for testing and repair in DB integrity checks

commit:5873e55
author:Dan Stillman
date:2017-05-19 20:08 (JST)

This can be used for things that can’t be checked or repaired with SQL alone, or that are too difficult to do that way.


Use COUNT(

*) > 1 for DB integrity check queries

commit:caf61be
author:Dan Stillman
date:2017-05-19 19:33 (JST)

Update citeproc-js to 1.1.167

commit:cf12543
author:Dan Stillman
date:2017-05-19 17:51 (JST)

Merge locales from Transifex

commit:74fe4b3
author:Dan Stillman
date:2017-05-18 10:38 (JST)

Update localized string name

commit:05dcc11
author:Dan Stillman
date:2017-05-18 10:29 (JST)

Most localizations still say “Firefox” for this string, so this will clear those.


Add item sanity check to note editor

commit:d9fbccc
author:Dan Stillman
date:2017-05-18 10:25 (JST)

When refreshing the note editor, store the associated itemID on the textbox, and check it when saving to make sure it’s for the expected note. This might prevent weird situations (which I can’t reproduce, but there was a report in the forums [1]) where something goes wrong and the note doesn’t refresh when selecting a new item, and then one note’s content is saved over another’s.

[1] https://forums.zotero.org/discussion/65708/


Crash app if there’s an error selecting an item

commit:c4411e1
author:Dan Stillman
date:2017-05-18 10:29 (JST)

Fix wrong localization arg passing

commit:182cf67
author:Adomas Venčkauskas
date:2017-05-16 00:26 (JST)

Unsaved conflict from upstream merge

commit:29d14f3
author:fbennett
date:2017-05-14 19:51 (JST)

Test for e1986b460e (export with empty attachment path)

commit:f12ae67
author:Dan Stillman
date:2017-05-14 18:26 (JST)

Use proper alerts for export errors

commit:7e95f8f
author:Dan Stillman
date:2017-05-14 18:07 (JST)

Fix failed export due to missing attachment path

commit:e1986b4
author:Dan Stillman
date:2017-05-14 18:06 (JST)

Update csl files

commit:5966c31
author:fbennett
date:2017-05-14 14:37 (JST)

Locale updates from upstream Zotero

commit:040999d
author:fbennett
date:2017-05-14 14:36 (JST)

Merge changes from upstream Zotero

commit:7cbb2de
author:fbennett
date:2017-05-14 14:32 (JST)

Fix clobbering of firstName field when multiple words entered in lastName field

commit:32f0c2c
author:fbennett
date:2017-05-14 10:42 (JST)

Revert changes protecting against missing-collection sync errors

commit:93e77bb
author:fbennett
date:2017-05-14 08:52 (JST)

Move variants with headline values when deleting creators

commit:943ad5f
author:fbennett
date:2017-05-14 08:51 (JST)

UI fixes for read-only notes

commit:eb42152
author:Dan Stillman
date:2017-05-13 08:59 (JST)
  • Don’t show toolbar in read-only note editor
  • Get rid of “undefined” button in CR window
  • Better padding/alignment in CR window

Better debug logging for CR error

commit:be7cc45
author:Dan Stillman
date:2017-05-13 06:53 (JST)

Remove accidental ‘false’ in 20121b9b9

commit:a92d469
author:Dan Stillman
date:2017-05-12 19:15 (JST)

Fix tag selector tests (broken in 5963c02db)

commit:20121b9
author:Dan Stillman
date:2017-05-12 19:13 (JST)

Fix “Display All Tags in This Library” (broken in fe186333b)

commit:5963c02
author:Dan Stillman
date:2017-05-12 18:37 (JST)

Better approach to opening files after on-demand downloads

commit:9de6a55
author:Dan Stillman
date:2017-05-11 14:25 (JST)

Follow-up to 44507ce20b


Don’t show Modified if attachment is missing

commit:b3acb12
author:Dan Stillman
date:2017-05-11 14:07 (JST)

Prevent conflicting file downloads on double double-click

commit:44507ce
author:Dan Stillman
date:2017-05-11 14:05 (JST)

Fix access date without time coming from sync

commit:60810ea
author:Dan Stillman
date:2017-05-11 13:44 (JST)

Fix attachment download progress pies

commit:a207e38
author:Dan Stillman
date:2017-05-11 11:48 (JST)

Avoid error. Differs from Zotero. Maybe not a good idea. But seems relatively safe.

commit:1c755c6
author:fbennett
date:2017-05-10 16:44 (JST)

Display connection error when linking sync account

commit:5b5da41
author:Dan Stillman
date:2017-05-10 15:32 (JST)

Fix whitespace and description in build_typeSchemaData.html

commit:b60fdac
author:Dan Stillman
date:2017-05-09 07:51 (JST)

Load polyfill in tests for Object.values() support in Fx45

commit:12e7046
author:Dan Stillman
date:2017-05-09 07:45 (JST)

Remove unneeded connector files, update connectorTypeSchemaData.js

commit:e1f09d4
author:Adomas Venčkauskas
date:2017-05-08 20:38 (JST)

Addresses zotero/zotero-connectors#121


Make itemFromCSLJSON independent of Zotero.Item existance.

commit:dbeecb9
author:Adomas Venčkauskas
date:2017-05-07 23:05 (JST)

Addresses !zotero/zotero-connectors#121”


Fix doc.prefs.noteType handling with NaN values

commit:746171a
author:Adomas Venčkauskas
date:2017-05-08 15:23 (JST)

Update submodules

commit:12e7b7b
author:Dan Stillman
date:2017-05-08 13:14 (JST)

Update locales from Transifex

commit:6fa84a5
author:Dan Stillman
date:2017-05-08 13:12 (JST)

Remove extra argument in removeAttribute()

commit:c0a4771
author:Dan Stillman
date:2017-05-08 12:45 (JST)

Optimize items list refreshing

commit:4273f14
author:Dan Stillman
date:2017-05-08 12:36 (JST)

When refreshing, keep the previous list intact, removing only the items that aren’t in the new list and sorting only the newly added items.


Update citeproc-js to 1.1.165

commit:5685710
author:fbennett
date:2017-05-08 06:55 (JST)

Update locales from upstream Zotero

commit:bbfb833
author:fbennett
date:2017-05-07 23:07 (JST)

Update from upstream Zotero

commit:a3145eb
author:fbennett
date:2017-05-07 23:04 (JST)

Fix entering date without time into Accessed

commit:e0e2222
author:Dan Stillman
date:2017-05-06 06:57 (JST)

https://forums.zotero.org/discussion/65560/5-0-beta-accessed-field-changes-dates


Potential bugfixery for #1218

commit:b679ada
author:Adomas Venčkauskas
date:2017-05-05 20:51 (JST)

Update citeproc-js to 1.1.165

commit:7a51f5e
author:Dan Stillman
date:2017-05-05 18:20 (JST)

Update locales from Transifex

commit:4ef3910
author:Dan Stillman
date:2017-05-05 18:14 (JST)

A couple more changes to document prefs dialog

commit:b80cdb2
author:Adomas Venčkauskas
date:2017-05-05 16:51 (JST)

Remove debugging

commit:43d12ee
author:Dan Stillman
date:2017-05-05 16:27 (JST)

Still process downloads if uploads fail for a library

commit:40da5f6
author:Dan Stillman
date:2017-05-05 16:26 (JST)

Better debug output for objects in sync queue skipped for uploading

commit:021cfa8
author:Dan Stillman
date:2017-05-05 14:38 (JST)

Clean up some comments and debug lines

commit:2f0391f
author:Dan Stillman
date:2017-05-05 14:05 (JST)

Remove objects from sync queue if missing from response

commit:a1bd2ba
author:Dan Stillman
date:2017-05-05 14:02 (JST)

While objects in the sync queue that fail to save should remain in the queue, objects that just don’t exist remotely need to be removed, or else they’ll be retried forever.


Use coroutine() in Zotero.Sync.Data.Engine::_downloadObjects()

commit:ad9c2ed
author:Dan Stillman
date:2017-05-05 13:29 (JST)

Fix background/stopOnError options for sync engine tests

commit:7a839e1
author:Dan Stillman
date:2017-05-05 13:26 (JST)

Add Zotero.Utilities.pluralize()

commit:b30e168
author:Dan Stillman
date:2017-05-05 13:19 (JST)

This makes it a little easier to use the proper plural form of a word. Currently this only supports English forms and is used only in debug output. For proper plural form support, use PluralForm.jsm.


Use Set for arrayUnique

commit:397ea58
author:Dan Stillman
date:2017-05-05 13:18 (JST)

Prevent items in group libraries from being added to My Publications

commit:2eef170
author:Dan Stillman
date:2017-05-05 10:18 (JST)

And remove existing group items that have been added


Ignore drags to tag selector background

commit:3561864
author:Dan Stillman
date:2017-05-05 02:51 (JST)

This was causing tags to be created with the text of all tags.


Make file sync timestamp comparison a little more lenient

commit:697937a
author:Dan Stillman
date:2017-05-04 15:04 (JST)

There was a report [1] of slow file syncing that showed all file timestamps being reported as ending with 020 (e.g., 1436492361020). The previous code assumed that systems without millisecond precision would report as whole seconds, so the timestamp checks weren’t matching and it was moving on to hash-based checks (which seemed to be taking a very long time, but that’s another matter). This changes the comparison so that, as long as both timestamps floor to the same whole second, they’ll be considered equal.

[1] https://forums.zotero.org/discussion/65515/5-0-beta-sync-problem


Fix bad grammar in file format notice

commit:c443559
author:Adomas Venčkauskas
date:2017-05-03 23:05 (JST)

Update citeproc instances in Integration on Styles.reinit

commit:8f19d1f
author:Adomas Venčkauskas
date:2017-05-03 20:35 (JST)

Closes zotero/zotero-word-for-windows-integration#34


Write sessionID into the doc on new session creation

commit:37fa0c2
author:Adomas Venčkauskas
date:2017-05-03 20:34 (JST)

Remove obsolete styles related code

commit:6336a30
author:Adomas Venčkauskas
date:2017-05-03 20:00 (JST)

Merge pull request #1222 from adomasven/feature/document-preferences-cleanup

commit:7d79865
author:Adomas Ven
date:2017-05-03 19:09 (JST)

Document preferences cleanup


Reduce text in document preferences, increase style list height

commit:5a55a82
author:Adomas Venčkauskas
date:2017-05-02 23:23 (JST)

Closes zotero/zotero-word-for-windows-integration#30


Fix missing paren from 5b0b8744351

commit:b2d91af
author:Dan Stillman
date:2017-05-03 17:47 (JST)

Simplify deleteCacheObjectVersions() query

commit:2588a0a
author:Dan Stillman
date:2017-05-03 16:54 (JST)

Purge old objects in sync cache after upload

commit:5b0b874
author:Dan Stillman
date:2017-05-03 16:43 (JST)

Fix syncing of related item removal

commit:aa1fc01
author:Dan Stillman
date:2017-05-03 09:15 (JST)

Additional debugging for sync issue

commit:5f819b7
author:Dan Stillman
date:2017-05-03 06:29 (JST)

Debugging for sync issue

commit:4502b5e
author:Dan Stillman
date:2017-05-03 05:56 (JST)

Remove store references in document option. Closes #1216

commit:3c19bbf
author:Adomas Venčkauskas
date:2017-05-02 22:29 (JST)

Fix test breakage from a76493f60

commit:5e3c7bf
author:Adomas Venčkauskas
date:2017-05-02 21:09 (JST)

Fix noteType type issues when talking to js-ctypes libs

commit:a76493f
author:Adomas Venčkauskas
date:2017-05-02 20:44 (JST)

Reported https://forums.zotero.org/discussion/65496/zotero-5-185-bug-cant-insert-field


integrationTests.js -> integrationTest.js

commit:32b1769
author:Dan Stillman
date:2017-04-28 17:12 (JST)

Fix error with citations not in library (since f3ceb7f66)

commit:9e1533c
author:Dan Stillman
date:2017-04-28 17:07 (JST)

Recover from a remotely missing parent collection

commit:fe88530
author:Dan Stillman
date:2017-04-28 16:18 (JST)

Don’t update various primary fields unnecessarily during save

commit:2db41b0
author:Dan Stillman
date:2017-04-28 11:25 (JST)

Schema update step to remove linked files from My Publications

commit:7bd8f47
author:Dan Stillman
date:2017-04-28 04:25 (JST)

Disallow inPublications for linked-file attachments

commit:9bd01af
author:Dan Stillman
date:2017-04-28 04:33 (JST)

Don’t show Show/Hide button in My Publications for linked files

commit:d715197
author:Dan Stillman
date:2017-04-27 16:57 (JST)

Revert accidental stopOnError change in 2bf53824

commit:8dacf44
author:Adomas Venčkauskas
date:2017-04-27 17:46 (JST)

Log errors from syncRunner concurrent caller

commit:2bf5382
author:Adomas Venčkauskas
date:2017-04-27 17:40 (JST)

Fix “text is not defined” error during full-text content sync

commit:d527c34
author:Dan Stillman
date:2017-04-26 15:44 (JST)

Merge pull request #1218 from adomasven/feature/JSON-pref-docs

commit:696e828
author:Dan Stillman
date:2017-04-23 11:54 (JST)

Feature/json pref docs


Fix broken integration test in a8d0110e

commit:7661f71
author:Adomas Venčkauskas
date:2017-04-21 17:11 (JST)

Fix indexing of synced full-text content

commit:21a3bf8
author:Dan Stillman
date:2017-04-21 15:59 (JST)

Restore Jurism-M code line to forestall extraneous showEditor()

commit:7f8d7ab
author:fbennett
date:2017-04-21 07:38 (JST)

Merge pull request #1219 from adomasven:fix/htmlSpecialChars

commit:b077e1c
author:Dan Stillman
date:2017-04-21 02:13 (JST)

Do not return empty string only for 0 arg to #htmlSpecialChars


Add a deprecation warning to non-string params for #htmlSpecialChars

commit:a8d0110
author:Adomas Venčkauskas
date:2017-04-20 19:33 (JST)

Revert change from ff74e0ff


Prepare 5.0 to handle JSON doc prefs

commit:bbec11e
author:Adomas Venčkauskas
date:2017-04-20 21:29 (JST)

Fix DocumentData serialization hairiness due to #htmlSpecialChars

commit:e272465
author:Adomas Venčkauskas
date:2017-04-20 19:39 (JST)

Add tests


Collapse My Publications when first opened

commit:d472752
author:Dan Stillman
date:2017-04-20 10:48 (JST)

Child items marked as visible are technically search matches, so we have to take extra steps to keep the parents from being auto-expanded.


Fix width of note link toolbar

commit:850a9bb
author:Dan Stillman
date:2017-04-20 08:35 (JST)

Load object data when looking up integration items

commit:f3ceb7f
author:Dan Stillman
date:2017-04-19 17:24 (JST)

Item data may not have been loaded for a library when requesting an item from a document (e.g., for Refresh), so we need to load all data for requested items to avoid unloaded-data errors. (Data isn’t loaded if it’s already been loaded, so hopefully this doesn’t slow things down too much.)


Clear inPublications in PATCH JSON with false, not empty string

commit:ab2bedc
author:Dan Stillman
date:2017-04-19 16:18 (JST)

Add settings table flag to auto-repair database on startup

commit:c03a0df
author:Dan Stillman
date:2017-04-18 16:33 (JST)

This will allow the DB Repair Tool to only recreate the file and leave schema knowledge to the client.

Addresses #895


Retry library sync on 409 error

commit:698eb33
author:Dan Stillman
date:2017-04-18 14:44 (JST)

Closes #928


Do not return empty string for falsy arguments in Utilities.htmlSpecialChars

commit:ff74e0f
author:Adomas Venčkauskas
date:2017-04-18 22:21 (JST)

Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0

commit:2c6c4d2
author:fbennett
date:2017-04-18 17:39 (JST)

Fix JM-specific bugs in integration following Zotero merge

commit:1e905e2
author:fbennett
date:2017-04-18 17:38 (JST)

Update locales from upstream Zotero

commit:9845802
author:fbennett
date:2017-04-18 10:55 (JST)

Merge changes from upstream Zotero

commit:97b5132
author:fbennett
date:2017-04-18 10:52 (JST)

Don’t include items in My Publications in Unfiled Items

commit:de7b56b
author:Dan Stillman
date:2017-04-18 10:34 (JST)

Remove stray console.log() calls in citeproc-js

commit:2160b1c
author:Dan Stillman
date:2017-04-18 02:56 (JST)

This is breaking bibliography output for some citations.


Close #932, Disable file dragging into My Publications

commit:8a7d405
author:Dan Stillman
date:2017-04-16 16:35 (JST)

Already disabled for collections pane, now for items pane


Restore ability to paste images in notes, for now

commit:d0b1a45
author:Dan Stillman
date:2017-04-16 15:40 (JST)

Allow this to continue working until we have a better solution that keeps data URIs out of note markup and is counted against file quota. Syncing most notes with embedded images will still result in a note-too-long error.

Closes #1209


Update tests after citeproc-js upgrade to match output

commit:b3277de
author:Dan Stillman
date:2017-04-15 17:34 (JST)

Unescape HTML in API upload errors

commit:58f4dc3
author:Dan Stillman
date:2017-04-15 11:54 (JST)

Make 404 handling for uploaded objects permanent

commit:0920e25
author:Dan Stillman
date:2017-04-15 11:49 (JST)

Related to https://github.com/zotero/dataserver/commit/aafda6d835


Update locales from Transifex

commit:e4bc715
author:Dan Stillman
date:2017-04-15 11:00 (JST)

Update submodules

commit:a2f11f5
author:Dan Stillman
date:2017-04-15 10:59 (JST)

Update citeproc-js to 1.1.160

commit:287a0b5
author:Dan Stillman
date:2017-04-15 10:57 (JST)

Update whitespace chars in cleanISBN/cleanISSN tests for Firefox 52+

commit:e397d12
author:Dan Stillman
date:2017-04-14 15:31 (JST)

Farewell, Mongolian Vowel Separator


Make sure styles are loaded before opening doc-prefs dialog

commit:de269b3
author:Adomas Venčkauskas
date:2017-04-14 20:30 (JST)

Remove dependency on zoteroIntegration.idl

commit:4900157
author:Adomas Venčkauskas
date:2017-04-14 18:43 (JST)

Move document plugin interface description into integrationTests

commit:0de22b1
author:Adomas Venčkauskas
date:2017-04-14 18:43 (JST)

Fix link opening in standalone note windows

commit:e1c183b
author:Dan Stillman
date:2017-04-13 17:54 (JST)

Reduce indentation in waitForWindow() support function

commit:9c91018
author:Dan Stillman
date:2017-04-13 17:28 (JST)

Update Zotero.Styles initialization to match translators

commit:18bb18b
author:Dan Stillman
date:2017-04-13 14:35 (JST)

Fix bibliographyTest breakage after d5cf33a798

commit:9b53570
author:Dan Stillman
date:2017-04-13 17:19 (JST)

d5cf33a798 adds a yield to bibliography.js, which runs in modal windows (e.g., Create Bib), but there’s a weird interaction between Bluebird and modal dialogs that can result in hangs – presumably something to do with things being queued on the event loop but the modal dialog preventing other code from running? This was breaking bibliographyTest, but it seemed to work fine for me in normal usage, waiting properly for a running styles initialization to finish. It’s possible this problem is limited to tests, but in the past, at least, I apparently decided that this was a general problem with yield in modal dialogs [1]. (See also: [2].) In any case, calling yield Zotero.Styles.init() from the Create Bib window was hanging the test, so for now do a synchronous check for style initialization to avoid it, and we should make sure that yield actually works in other contexts.

[1] https://github.com/zotero/zotero/commit/99dd1c069776 [2] https://github.com/zotero/zotero/commit/c2dd531cec4


NodeList doesn’t have forEach in Firefox 45

commit:ed3b18b
author:Dan Stillman
date:2017-04-13 14:21 (JST)

Don’t break Zotero

commit:b7aab8b
author:Dan Stillman
date:2017-04-13 13:21 (JST)

Fix test breakage after 5ff2a59f87

commit:6d18b46
author:Dan Stillman
date:2017-04-13 13:13 (JST)

And remove all instances of publicationsLibraryID


Move My Publications into My Library

commit:5ff2a59
author:Dan Stillman
date:2017-04-12 13:56 (JST)

Instead of My Publications being a separate library, have it be a special collection inside My Library. Top-level items can be dragged into it as before, and child items can be toggled off and on with a button in the item pane. Newly added child items won’t be shown by default.

For upgraders, items in the My Publications library will be moved into My Library, which might result in their being duplicated if the items weren’t removed from My Library. The client will then upload those new items into My Library.

The API endpoint will continue to show items in the separate My Publications library until My Publications items are added to My Library, so the profile page will continue to show them.


Remove obsolete quicksearch refresh in ItemTreeView::notify()

commit:e311279
author:Dan Stillman
date:2017-04-12 18:44 (JST)

Better debug output when setting .synced on an item

commit:3c3ff32
author:Dan Stillman
date:2017-04-12 18:41 (JST)

Remove unused laststoragesync response from test

commit:4da0c4c
author:Dan Stillman
date:2017-04-12 13:16 (JST)

Add .regularOnly and .expandAll flags to ItemTreeView

commit:b014068
author:Dan Stillman
date:2017-03-31 13:21 (JST)

Don’t wait for transaction when selecting item

commit:6c1ba0a
author:Dan Stillman
date:2017-03-31 12:08 (JST)

Add Document.addEditBibliography to integration.js

commit:7657c90
author:Adomas Venčkauskas
date:2017-04-11 22:16 (JST)

See zotero/zotero-word-for-windows-integration#28 for background


Merge pull request #1202 from adomasven/fix/doc-pref-window-unloaded-styles

commit:2a5dbaa
author:Adomas Ven
date:2017-04-12 17:52 (JST)

Fix document preferences dialog failing when styles unloaded.


Add tests for style from untrusted source prompt

commit:ea535bc
author:Adomas Venčkauskas
date:2017-04-12 17:40 (JST)

Prompt if style in document is not from official source

commit:3e69da7
author:Adomas Venčkauskas
date:2017-04-12 17:47 (JST)

Add integrationTests.js

commit:02c43c3
author:Adomas Venčkauskas
date:2017-04-06 20:19 (JST)

Contains a dummy doc plugin, which is useful for: - Testing integration.js functionality - Serving as succint documentation for development of new integration

plugins

Don’t show response text on HTTP error if empty

commit:747290b
author:Dan Stillman
date:2017-04-11 17:18 (JST)

429 and Retry-After support for API requests

commit:5d6478e
author:Dan Stillman
date:2017-04-11 17:17 (JST)

Fetch a style if it is not installed on document preferences load

commit:269a250
author:Adomas Venčkauskas
date:2017-03-31 20:27 (JST)

Fix document preferences dialog failing when styles unloaded.

commit:d5cf33a
author:Adomas Venčkauskas
date:2017-03-21 19:47 (JST)

Closes #1084


Add jm-sh builder

commit:70df696
author:Frank Bennett
date:2017-04-08 15:40 (JST)

Fixes for modules

commit:3f1f2af
author:Frank Bennett
date:2017-04-08 15:40 (JST)

Show UnexpectedStatusException response without prefix during sync

commit:64414e4
author:Dan Stillman
date:2017-04-08 11:45 (JST)

Always include server response in Zotero.HTTP.request() errors

commit:a64c680
author:Dan Stillman
date:2017-04-08 11:34 (JST)

Fix duplicated error message when logging UnexpectedStatusException

commit:3df66cc
author:Dan Stillman
date:2017-04-08 11:32 (JST)

Not sure what’s causing this. (Bluebird?)

Also add stack to custom HTTP exceptions.


Promise cleanup in Zotero.Attachment.importFromURL()

commit:c0a2ec8
author:Dan Stillman
date:2017-04-08 12:33 (JST)

Use new Zotero.Promise instead of defer() and coroutine() instead of chained promises


Fix breakage from 406f50a3

commit:4540edb
author:Dan Stillman
date:2017-04-08 12:11 (JST)

Address file import bugs

commit:5818935
author:Adomas Venčkauskas
date:2017-04-07 20:35 (JST)

I don’t know why why, but wbp.saveDocument() destroys the document object which is passed into it. This means that further access of the document is impossible and raises errors, which we were not handling properly and not returning on attachment saving.

I’ve added error handling and changed removed code which tries to access the document after the Zotero.Utilities.Internal.saveDocument() call.

Addresses https://forums.zotero.org/discussion/64745/5-0-beta-apparently-stuck-at-saving-to


Restore progress for attachments indication in connectors

commit:406f50a
author:Adomas Venčkauskas
date:2017-04-07 19:25 (JST)

78b1d2e regression


Mark local collection as unsynced if missing remotely in item request

commit:d8fed09
author:Dan Stillman
date:2017-04-07 13:57 (JST)

We should figure out when this happens, but in the meantime, recover from it if it does.


Update csl locales

commit:dffd293
author:Frank Bennett
date:2017-04-06 21:52 (JST)

Fix .gitmodules entry for csl locales

commit:4fc919c
author:Frank Bennett
date:2017-04-06 21:52 (JST)

Fix dragging in links on Linux

commit:172f36d
author:Dan Stillman
date:2017-04-06 03:24 (JST)

Set fieldMode on multi creators in modifyCreator()

commit:59eff24
author:fbennett
date:2017-04-03 14:58 (JST)

Locale updates from upstream Zotero

commit:9b11b25
author:fbennett
date:2017-04-03 14:04 (JST)

Merge changes from upstream Zotero

commit:2ba81ff
author:fbennett
date:2017-04-03 14:01 (JST)

Maybe fix noteeditor test failures for real

commit:c43823a
author:Dan Stillman
date:2017-04-02 03:29 (JST)

Allow setting note text with createDataObject(‘item’) test function

commit:7609ef3
author:Dan Stillman
date:2017-04-02 03:28 (JST)

Fix onInit() in styled textbox if already initialized

commit:4867fc7
author:Dan Stillman
date:2017-04-02 03:27 (JST)

Don’t show context menu on right-click on tag selector background

commit:4edcf58
author:Dan Stillman
date:2017-04-02 00:24 (JST)

Reload primary data after tag rename instead of updating .synced

commit:6174641
author:Dan Stillman
date:2017-04-01 16:13 (JST)

Follow-up to bb489a45c3 to mirror what Tags.removeFromLibrary() does


Upload modified items after tag rename

commit:bb489a4
author:Dan Stillman
date:2017-04-01 15:54 (JST)

The web library will probably still display the old tag in addition to the new one, at least until browser restart. We’ll have to deal with that separately.

Closes #1205


Update locales from Transifex

commit:9637770
author:Dan Stillman
date:2017-03-28 15:28 (JST)

Update submodules

commit:9bdb907
author:Dan Stillman
date:2017-03-28 15:28 (JST)

Avoid XML Parsing Error in Firefox console for ping requests

commit:cac0110
author:Dan Stillman
date:2017-03-28 15:17 (JST)

Increase timeout to hopefully prevent noteeditor tag test from failing

commit:09d4960
author:Dan Stillman
date:2017-03-28 09:44 (JST)

Remove instance of legacy shorthand function syntax

commit:7b7b268
author:Dan Stillman
date:2017-03-28 09:43 (JST)

Fix renaming and clearing of colored tags

commit:3a8357c
author:Dan Stillman
date:2017-03-28 09:42 (JST)

Drastically speed up tag selector refresh with many tags

commit:fe18633
author:Dan Stillman
date:2017-03-28 09:33 (JST)

When refreshing, if fewer than 100 tags to show, just create them from scratch instead of updating the full set. Otherwise, remove the full set from DOM and add it back in after updates to avoid reflows (from #1204).

There are various things that could be done to optimize this further (avoiding unnecessary sorting during full refreshes, calculating a hash of the full set and not updating it every time), but we should probably just replace it with @tnajdek’s React version first.

Closes #1204


Fix classic Add Citation dialog after 820755e15

commit:8edd4b0
author:Dan Stillman
date:2017-03-27 17:38 (JST)

Missing line from 499d4e3065

commit:bd28701
author:Dan Stillman
date:2017-03-27 15:12 (JST)

Handle missing deleted.txt in unpacked source directory

commit:499d4e3
author:Dan Stillman
date:2017-03-27 15:02 (JST)

Unpacked directories aren’t actually supported anymore, but fix obvious breakage if they were.


Remove fallback code for symlinked Standalone dev build

commit:4477e42
author:Dan Stillman
date:2017-03-27 15:07 (JST)

No longer possible


Ignore clicks in tag selector not on tags

commit:3a48439
author:Dan Stillman
date:2017-03-27 07:11 (JST)

Always invalidate items tree after sort

commit:d357382
author:Dan Stillman
date:2017-03-26 18:20 (JST)

Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0-dev

commit:0cd6442
author:fbennett
date:2017-03-25 21:57 (JST)

Fixes report printing. Closes #1179.

commit:bc4afb6
author:Adomas Venčkauskas
date:2017-03-25 00:51 (JST)

Page Setup seems to have moved into the print dialog in Firefox a while ago


Fix updating of tag selector after filtering the middle pane

commit:edb53c3
author:Dan Stillman
date:2017-03-24 18:20 (JST)

Adds a ‘refresh’ event to libraryTreeView


Rework libraryTreeView event handling

commit:820755e
author:Dan Stillman
date:2017-03-24 18:18 (JST)

Changes libraryTreeView::addEventListener(‘load’) and similar to libraryTreeView::onLoad.addListener(listener, once), etc. once is an optional boolean that, when true, causes the listener to fire once and then be removed. This is implicit for ‘load’.

‘load’ maintains its special behavior of running immediately if the treeview has already been loaded.

Also adds waitForLoad() and waitForSelect() functions that return promises on event completion, since most uses of those events were just resolving deferreds.


Move waitForTagSelector() into support.js

commit:1a4b712
author:Dan Stillman
date:2017-03-24 13:51 (JST)

Pass chunk size to data generator

commit:f4eb8ed
author:Dan Stillman
date:2017-03-21 18:05 (JST)

TODO: Add text fields for controlling number of items and chunk size

(Chunk size should be small for testing UI interactions and performance but large for generating lots of data.)


Fix error from empty strings in data generator

commit:d9b5fd7
author:Dan Stillman
date:2017-03-21 17:58 (JST)

Update word plugin status after installation. Closes #1200

commit:8bc5d37
author:Adomas Venčkauskas
date:2017-03-21 02:22 (JST)

Replace old-style object properties in word-processor-plugin-installer

commit:2d93b07
author:Adomas Venčkauskas
date:2017-03-17 21:27 (JST)

Adds a -debugger command-line flag to start the devtools server

commit:eaf8d36
author:Dan Stillman
date:2017-03-18 06:08 (JST)

Follow-up to https://github.com/zotero/zotero-standalone-build/commit/22cfe2404

The devtools must be included in the build by passing the -t flag to build.sh in zotero-standalone-build.

After starting Zotero with the flag, connect from a Firefox instance with remote debugging enabled by choosing “Connect…” from the Web Developer menu and connecting to port 6100.


Use data.detailedCookies in /connector/saveSnapshot

commit:dd921f3
author:Adomas Venčkauskas
date:2017-03-17 00:06 (JST)

Fix error showing some WebDAV verification errors

commit:a347389
author:Dan Stillman
date:2017-03-14 08:02 (JST)

Add loadPrefPane(paneName) support function

commit:640aaa1
author:Dan Stillman
date:2017-03-14 07:59 (JST)

E.g., loadPrefPane(‘sync’) to open the prefs and select the ‘zotero-pane-sync’ pane


Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0-dev

commit:f86debb
author:fbennett
date:2017-03-12 10:41 (JST)

Bump source version 5.0

commit:1fb3257
author:fbennett
date:2017-03-11 08:08 (JST)

Repairs for document cite extraction

commit:d337459
author:fbennett
date:2017-03-11 08:07 (JST)

Script to generate random item data

commit:b732a82
author:Dan Stillman
date:2017-03-09 17:45 (JST)

For building up a big library and testing UI interaction during writes

To use, load chrome://zotero/content/tools/data_generator.html in Firefox (for now).

Could be improved a bit to add other kinds of data (collections, child items, relations)


Clean up a few data layer lines

commit:f9ea0af
author:Dan Stillman
date:2017-03-09 17:12 (JST)

Fix (some) crashes switching collections while items are being added

commit:b1fc6ac
author:Dan Stillman
date:2017-03-09 17:04 (JST)

The items list is generated from the database (via search), but new items may have been added to the database but not yet been registered, causing unloaded-data errors during sorting. Avoid that by not showing unregistered items when generating the items list.

Additional protections are necessary – it’s still possible to get errors, and maybe a crash, if an item has been registered but not yet fully loaded – but this addresses the most common one.


Create temporary table for search without transaction

commit:1711ba4
author:Dan Stillman
date:2017-03-09 15:01 (JST)

Remove Promise.prototype.finally calls from translate.js not in ES6

commit:580cc32
author:Adomas Venčkauskas
date:2017-03-07 19:34 (JST)

We could monkey-patch a finally function in connectors as described in this gist https://gist.github.com/jish/e9bcd75e391a2b21206b , but it appears to silence propogation of unhandled rejections and it could later come back to bite us in the butt. Native and proper support for finally is, however, planned in ES7.


Update Collection::getChildItems() when erasing item

commit:e9fd7f2
author:Dan Stillman
date:2017-03-07 15:54 (JST)

Fixes #1188


Fix Quick Copy drag with export format

commit:dd5ae0f
author:Dan Stillman
date:2017-03-07 13:52 (JST)

Fix file sync error on Windows for old filenames containing colons

commit:9e59500
author:Dan Stillman
date:2017-03-07 12:04 (JST)

OS.Path.basename() stops at colons on Windows, so calling it on the full path produces unexpected results.


Add Juris-M logo source to repo

commit:18419a6
author:fbennett
date:2017-03-06 08:43 (JST)

Merge changes from upstream Zotero master

commit:6c3b56d
author:fbennett
date:2017-03-05 22:46 (JST)

Fix cross-library collection drag on Linux, probably

commit:59fb9d0
author:Dan Stillman
date:2017-03-05 06:38 (JST)

Check linked collections in both directions

commit:c180bce
author:Dan Stillman
date:2017-03-05 06:05 (JST)

Set ‘copy’ cursor feedback on cross-library collection drag

commit:d0d7aec
author:Dan Stillman
date:2017-03-04 18:17 (JST)

Fix dragging collections between libraries

commit:704e8ff
author:Dan Stillman
date:2017-03-04 18:17 (JST)

Remove errant HTML tag

commit:1b81004
author:Dan Stillman
date:2017-03-04 06:39 (JST)

Fix potential error dragging attachment with missing file

commit:9ea82bb
author:Dan Stillman
date:2017-03-04 06:39 (JST)

Asyncify various functions to fix cross-library drag-and-drop error

commit:fe9fc8b
author:Dan Stillman
date:2017-03-04 06:33 (JST)

When dragging an item to another library, we have to check if there’s a linked item in the target library, but items might not yet be laoded in the other library, so item.getLinkedItem() can fail with “Item [n] not yet loaded].

Fixing required asyncifying the follow functions:

  • Zotero.Item::getLinkedItem()
  • Zotero.Collection::getLinkedCollection()
  • Zotero.URI.getURIItem()
  • Zotero.URI.getURICollection()
  • Various integration functions

Bind function to context to preserve assignments inside event

commit:28033c7
author:fbennett
date:2017-03-03 23:27 (JST)

Remove stray diff comment line

commit:9008377
author:fbennett
date:2017-03-03 23:25 (JST)

Fix (still) broken debug reporting for connectors (regression ef0d9afe8)

commit:182b9a9
author:Adomas Venčkauskas
date:2017-03-03 22:02 (JST)

Fix various error propagation issues during translation

commit:7c25093
author:Dan Stillman
date:2017-03-03 18:09 (JST)

As noted in 27cb099c82, import translators should be rewritten to return a promise from doImport() and wait for promises from successive item.complete() calls. They should then be marked as minVersion: “5.0” to be handled properly by this new code.

(But this tries to account, albeit with somewhat worse behavior, for translators that haven’t been rewritten and sandboxes without Promise (which is currently the case with child sandboxes in the client).)

(Oh, and I haven’t tested this at all in the connectors.)


Update locales from upstream

commit:a96afad
author:fbennett
date:2017-03-03 13:03 (JST)

Merge changes from upstream Zotero

commit:dffcbd7
author:fbennett
date:2017-03-03 12:59 (JST)

Fix sequencing of citation updates

commit:faec11c
author:fbennett
date:2017-03-03 08:29 (JST)

Update citeproc-js to 1.1.157

commit:50c22b1
author:fbennett
date:2017-03-03 08:18 (JST)

Protect against crash when collection is removed during empty-trash

commit:48aeb99
author:fbennett
date:2017-03-03 07:38 (JST)

Firefox 52 compatibility

commit:7ccf781
author:Dan Stillman
date:2017-03-03 05:30 (JST)

Add debugging for display error reported in forums

commit:8812fd4
author:Dan Stillman
date:2017-03-03 05:29 (JST)

https://forums.zotero.org/discussion/64662/5-0-beta-no-items-displayed-in-center-pane


Don’t allow setting 0 for feed item TTL

commit:6539fc4
author:Adomas Venčkauskas
date:2017-03-03 00:53 (JST)

Update locales from Transifex

commit:3d0c7d3
author:Dan Stillman
date:2017-03-02 17:49 (JST)

Don’t restart until after clearing storage settings when changing user

commit:945dc28
author:Dan Stillman
date:2017-03-02 13:36 (JST)

Possible that this was working previously, but no particular reason to think that quitZotero() shouldn’t be synchronous.


If userID is set, migrate any item relations with local user key

commit:3a5490a
author:Dan Stillman
date:2017-03-02 15:31 (JST)

DB update to go along with 0d8643087a


Update relations using local user key when first setting sync user

commit:0d86430
author:Dan Stillman
date:2017-03-02 13:34 (JST)

In case items are merged before the first sync


Fix updating of notes list when child note is changed or moved to trash

commit:ba91a2e
author:Dan Stillman
date:2017-03-01 15:35 (JST)

Always show items-loading message switching collections in citation dialogs

commit:82b789e
author:Dan Stillman
date:2017-02-28 17:33 (JST)

Previously it only showed if library data hadn’t been loaded, but sorting can also take a little time when switching between collections.


Fix Edit Bibliography window

commit:737f54a
author:Dan Stillman
date:2017-02-28 17:33 (JST)

Fix translation error when firstName is null for fieldMode 1

commit:6c58389
author:Dan Stillman
date:2017-02-28 13:34 (JST)

Some translators (e.g., CrossRef) return firstName: null with fieldMode: 1, which was causing an error


Increase size of browser window during tests

commit:a35d903
author:Dan Stillman
date:2017-02-27 18:54 (JST)

Makes it easier to manually increase Zotero pane before a timeout while debugging (though the page should just be made bigger by default)


Fix potential incorrect placement of new subcollections

commit:d0a1ac9
author:Dan Stillman
date:2017-02-27 18:51 (JST)

For one particular complicated collection structure, new collections could be placed in the wrong place until a restart.


Additional test for updateSynced()

commit:18877a9
author:Dan Stillman
date:2017-02-27 17:11 (JST)

Addresses #1187


Merge branch ‘jurism-5.0-dev’ into jurism-5.0

commit:2dbf0e2
author:fbennett
date:2017-02-27 17:07 (JST)

Fix bug in updateSync.

commit:8a9950b
author:fbennett
date:2017-02-27 17:06 (JST)

Update jurisdictions.

commit:1100d56
author:fbennett
date:2017-02-27 17:06 (JST)

Merge pull request #1187 from fbennett/patch-1

commit:e7ef1b4
author:Dan Stillman
date:2017-02-27 17:00 (JST)

Probable typo in dataObject.js


Probable typo in dataObject.js

commit:6b2bf34
author:Frank Bennett
date:2017-02-27 16:36 (JST)

This line just crashed on me during a sync operation in Juris-M 5.0. It looks like a typo.


Fix startup error on Windows DB upgrades caused by b2b751e0a0

commit:fa680bb
author:Dan Stillman
date:2017-02-26 20:12 (JST)

Fix error when DB backup can’t be opened

commit:b2b751e
author:Dan Stillman
date:2017-02-26 08:09 (JST)

Update locales from upstream master

commit:09b025d
author:fbennett
date:2017-02-25 11:04 (JST)

Merge changes from upstream master

commit:e403a66
author:fbennett
date:2017-02-25 11:01 (JST)

Fix displayTitle for untitled legislation, avoid sync crash on missing collections (DUBIOUS)

commit:ae6eeb0
author:fbennett
date:2017-02-25 10:57 (JST)

Fix constraint failure in cachedLanguages.js

commit:857f652
author:fbennett
date:2017-02-25 10:55 (JST)

Align orderIndex to Zotero expectations in system.sql

commit:fc1432f
author:fbennett
date:2017-02-25 10:54 (JST)

Handle paginated results in Zotero.Sync.APIClient.getGroups()

commit:cb5e1fa
author:Dan Stillman
date:2017-02-25 08:41 (JST)

Add Zotero.Sync.APIClient.getPaginatedResults()

commit:a9dda10
author:Dan Stillman
date:2017-02-25 08:39 (JST)

Function that automatically follows Link headers and makes additional requests as necessary, feeding the XMLHTTPRequest object from each request to a reducer function.


Fix incorrect tests due to the bug fixed in b21729edd17

commit:5762610
author:Dan Stillman
date:2017-02-24 17:50 (JST)

Remove obsolete Zotero.Libraries.isFilesEditable test after 88184b341

commit:3ba2b40
author:Dan Stillman
date:2017-02-24 17:29 (JST)

Fix typo in debug line

commit:0a1629e
author:Dan Stillman
date:2017-02-24 16:32 (JST)

Add archived group handling to sync runner

commit:80a0826
author:Dan Stillman
date:2017-02-24 16:31 (JST)
  • Archive remotely missing that user chooses to keep
  • Ignore archived groups that don’t existing remotely
  • Unarchive groups that become available again

Add collections pane context-menu option to remove archived libraries

commit:2fe756c
author:Dan Stillman
date:2017-02-24 16:29 (JST)

Add ‘archived’ property to Zotero.Library objects

commit:9ac458e
author:Dan Stillman
date:2017-02-24 14:13 (JST)

Set when a user loses access to a library but chooses to keep it as a read-only library.


Setting a library’s ‘editable’ to false should do same for ‘filesEditable’

commit:88184b3
author:Dan Stillman
date:2017-02-24 14:10 (JST)

Check database values in Zotero.Library#editable tests

commit:74d1cc1
author:Dan Stillman
date:2017-02-24 14:09 (JST)

Fix Zotero.Sync.Data.Local._libraryHasUnsyncedFiles()

commit:b21729e
author:Dan Stillman
date:2017-02-24 16:21 (JST)

Always returned true


Fix error deleting selected library

commit:f7074a7
author:Dan Stillman
date:2017-02-24 15:34 (JST)

Fix renaming attachment from right-hand pane

commit:1633a73
author:Dan Stillman
date:2017-02-24 10:17 (JST)

Fix file sync error if local item version is greater than remote item

commit:9073239
author:Dan Stillman
date:2017-02-24 08:07 (JST)

This can happen because objects are uploaded in batches, but the version number from the last batch is used for all objects (since APIClient.uploadObjects() handles batching internally).


Show the right HTTP method in WebDAV errors

commit:6329e22
author:Dan Stillman
date:2017-02-24 05:21 (JST)

Could probably QI UnexpectedStatusException.channel to nsIHTTPChannel and get requestMethod, but this is easier.


Disable some incomplete locales (below 50% or so)

commit:bc940c2
author:Dan Stillman
date:2017-02-24 04:38 (JST)

https://groups.google.com/d/topic/zotero-dev/ygqCU5vYn3k/discussion


Fix word processor integration installation error

commit:01f18cb
author:Dan Stillman
date:2017-02-24 05:10 (JST)

Fix error importing from file (regression from 32bebeb1cd0)

commit:bb38c97
author:Dan Stillman
date:2017-02-23 11:46 (JST)

Use same directory for OS.File.moveAtomic() temp file

commit:383eac4
author:Dan Stillman
date:2017-02-23 09:53 (JST)

Using the main temp directory was causing writes to fail when storage was on another filesystem.


Fix importing from clipboard

commit:32bebeb
author:Dan Stillman
date:2017-02-22 19:22 (JST)

Since there’s no filename to show in the progress popup, show the translator label (e.g., “BibTeX”) instead.


Use OS.File.move() for data-dir migration on Windows, and make automatic

commit:0964277
author:Dan Stillman
date:2017-02-22 18:56 (JST)

Previously on Windows, where we don’t have /bin/mv, we were recursing into the data directory and copying files individually, which is very slow, so automatic migration was disabled. Instead, try moving directories with OS.File.move() with the noCopy flag. Moving directories is technically unsupported by OS.File, but probably only because of the possibility of a cross-volume copy (which is only implemented for some platforms), and using noCopy hopefully prevents that. If someone does have their data directory or storage directory on a different volume, the migration might be quite slow, but leaving a data directory behind in the Firefox profile directory (where it can be easily misplaced with a seemingly unrelated Firefox reset) is worse.


Fix dragging attachment onto item on Linux (since 1a49018bd)

commit:1ff1fab
author:Dan Stillman
date:2017-02-22 08:17 (JST)

Merge pull request #1180 from adomasven/fix/savePage-no-translator

commit:3c5912f
author:Dan Stillman
date:2017-02-22 06:40 (JST)

Default to first translator for /connector/savePage if not provided

commit:01df8f5
author:Adomas Venčkauskas
date:2017-02-21 21:26 (JST)

Don’t select sibling on attachment removal if attachment was unselected

commit:333675d
author:Dan Stillman
date:2017-02-21 15:21 (JST)

Fixes #1173


Fix “Item collection [n] not found” error after deleting collection

commit:60b2e16
author:Dan Stillman
date:2017-02-21 14:38 (JST)

Remove unused properties

commit:90603c3
author:Dan Stillman
date:2017-02-21 14:04 (JST)

Fix handling of old-style ‘condition’/’savedSearch’ conditions

commit:64d73cf
author:Dan Stillman
date:2017-02-21 14:02 (JST)

Strip library id prefix in addCondition() and _loadConditions(), so the internal code can always expect just a key.


Fix setting of libraryID in createDataObject() support function

commit:d32f234
author:Dan Stillman
date:2017-02-21 14:03 (JST)

When another property was also set, setting libraryID would fail.


Allow opening multiple URLs via View Online

commit:e465cf0
author:Dan Stillman
date:2017-02-21 08:49 (JST)

Don’t save full-text cache files for linked files to linked directory

commit:5c50bb0
author:Dan Stillman
date:2017-02-21 07:51 (JST)

Regression from 80f888f374. Not entirely sure what I was trying to fix there.


Revert “temporary” build param. Oops.

commit:5c6abff
author:fbennett
date:2017-02-20 15:25 (JST)

Fix failure of field updates in merge pane

commit:4c126d3
author:fbennett
date:2017-02-20 15:22 (JST)

Apply creator id mapping in multi upgrade only if generated by upgrade code in Zotero schema

commit:18198c0
author:fbennett
date:2017-02-20 15:21 (JST)

Temporary checkout of branch param

commit:face09c
author:fbennett
date:2017-02-20 10:31 (JST)

update chai

commit:e8ca529
author:fbennett
date:2017-02-20 10:24 (JST)

Update locales

commit:7c62763
author:fbennett
date:2017-02-20 10:21 (JST)

Merge from upstream master

commit:3bf7571
author:fbennett
date:2017-02-20 10:19 (JST)

Small bugfixes and rearrangements

commit:a1b47fc
author:fbennett
date:2017-02-20 10:10 (JST)

Add indexes to multilingual tables for use in delete operations.

commit:6174f91
author:fbennett
date:2017-02-19 13:02 (JST)

Remove stale methods

commit:7fd44bb
author:fbennett
date:2017-02-19 10:41 (JST)

Yield async DB read/write ops

commit:c716a28
author:fbennett
date:2017-02-19 10:41 (JST)

Fix old-style ‘collection’ condition for My Library in saved searches

commit:bb0fa73
author:Dan Stillman
date:2017-02-19 04:19 (JST)

Merge pull request #1172 from adomasven/fix/clean-authors

commit:07ea9da
author:Dan Stillman
date:2017-02-19 02:52 (JST)

Get a better last name if current guess starts with weird symbols


Move the common code for word plugin installer to main repo

commit:e8ac639
author:Adomas Venčkauskas
date:2017-02-12 05:52 (JST)

From https://github.com/zotero/zotero-word-for-mac-integration/blob/master/resource/installer_common.jsm

Removes some very old code to handle Gecko 2.1< Does not affect existing plugins/installers in any way, but sets us up to unifiy the installer once word plugins are updated.


Get a better last name if current guess starts with weird symbols

commit:bf1c52a
author:Adomas Venčkauskas
date:2017-02-12 00:56 (JST)

Add missing alt-field change memo method

commit:78d2609
author:fbennett
date:2017-02-18 12:48 (JST)

Bump system schema version

commit:d95379b
author:fbennett
date:2017-02-18 12:47 (JST)

Fix bugs in sync encoding

commit:cddc04e
author:fbennett
date:2017-02-17 17:25 (JST)

Remove Juris-M blob from toolbar

commit:690e3e7
author:fbennett
date:2017-02-17 17:24 (JST)

On 404 from ZFS upload, mark attachment item for upload

commit:058a4b1
author:Dan Stillman
date:2017-02-17 10:11 (JST)

This shouldn’t happen, but reported here:

https://forums.zotero.org/discussion/64386/5-0-beta-persistent-sync-errors

Possibly the same cause as this:

https://forums.zotero.org/discussion/64438/5-0-beta-persistent-sync-error


If parent item is missing remotely, mark as unsynced and add to queue

commit:34c90fd
author:Dan Stillman
date:2017-02-17 08:01 (JST)

This shouldn’t happen, but there’ve been some reports of it.


Fix format of object data added back to upload queue after failure

commit:cbed716
author:Dan Stillman
date:2017-02-17 07:59 (JST)

Include ‘skipNotifier’ in ‘skipAll’ when saving objects

commit:ddb7d31
author:Dan Stillman
date:2017-02-17 07:58 (JST)

Fix firstCreator for unsaved items

commit:bb665a5
author:Dan Stillman
date:2017-02-16 13:13 (JST)

Necessary when editing embedded citations that don’t exist in library


Update citeproc-js to 1.1.155

commit:9d8f804
author:fbennett
date:2017-02-16 10:28 (JST)

Mark trashed items as unsynced and update parents (including note list)

commit:3830aa1
author:Dan Stillman
date:2017-02-16 03:15 (JST)

Regression from 3a0e0cb0886


Update locales from Transifex

commit:41538eb
author:Dan Stillman
date:2017-02-16 03:13 (JST)

Fix bugs in jurisdiction default and set/display

commit:de87020
author:fbennett
date:2017-02-14 21:37 (JST)

Fix upgrade bug to dropped creator variants

commit:62d65b8
author:fbennett
date:2017-02-14 21:37 (JST)

More fixes for jurisdiction edit/display

commit:b1f9e90
author:fbennett
date:2017-02-14 19:33 (JST)

Increment multilingual schema

commit:0b3be8a
author:fbennett
date:2017-02-14 19:31 (JST)

Cherry-pick change from jurism branch

commit:604c5c7
author:fbennett
date:2017-02-14 19:31 (JST)

Fix jurisdiction display in item tree

commit:b1b661f
author:fbennett
date:2017-02-14 10:28 (JST)

Fix bug in top-level jurisdiction reverse lookup

commit:d6e8151
author:fbennett
date:2017-02-14 08:11 (JST)

Updating install.rdf to version 4.0.29.12m99beta1

commit:e83057a
author:fbennett
date:2017-02-11 21:47 (JST)

Increment patch level, reset beta level

commit:e586e36
author:fbennett
date:2017-02-11 21:46 (JST)

Updating install.rdf to version 4.0.29.12m96beta2

commit:4cd8276
author:fbennett
date:2017-02-11 21:33 (JST)

Updating install.rdf to version 4.0.29.12m96beta1

commit:f9e8621
author:fbennett
date:2017-02-11 21:29 (JST)

Fix subjurisdiction searches

commit:1255292
author:fbennett
date:2017-02-11 20:57 (JST)

Return a raw jurisdiction ID or name by default, not “default”

commit:a56c230
author:fbennett
date:2017-02-11 20:56 (JST)

Update to full set of jurisdiction data

commit:e6c8d6f
author:fbennett
date:2017-02-11 17:54 (JST)

Update citeproc-js to 1.1.154

commit:3f8eb7a
author:fbennett
date:2017-02-11 17:53 (JST)

Allow resizing of classic citation dialog.

commit:110f2a3
author:fbennett
date:2017-02-11 15:02 (JST)
Commit from pull request submitted by Karl Hegbloom:
https://github.com/Juris-M/zotero/pull/23

Fix glitch that crept in during merge

commit:f502cc5
author:fbennett
date:2017-02-11 14:41 (JST)

Update locales from upstream master

commit:9749482
author:fbennett
date:2017-02-11 13:50 (JST)

Update CSL styles

commit:dbf1431
author:fbennett
date:2017-02-11 13:45 (JST)

Merge from upstream master

commit:84f26a3
author:fbennett
date:2017-02-11 13:44 (JST)

Fix emptying from trash (broken in 7ede52355d)

commit:469d689
author:Dan Stillman
date:2017-02-11 04:11 (JST)

Zotero.Items.eraseTx() doesn’t exist – use Zotero.Items.erase() instead


Retain style properties when pasting content from Word/Office

commit:12735fa
author:Dan Stillman
date:2017-02-10 13:40 (JST)

Preload names of all parent jurisdictions on an item

commit:22618ec
author:fbennett
date:2017-02-10 12:19 (JST)

Update to jurisdictions to include Vietnam for testing

commit:f6fe0f6
author:fbennett
date:2017-02-10 10:58 (JST)

Set default jurisdiction

commit:cc59f36
author:fbennett
date:2017-02-10 10:57 (JST)

Update citeproc-js to 1.1.152

commit:266653a
author:fbennett
date:2017-02-10 10:57 (JST)

Change to preloadAbbreviations function signature

commit:72bfdbe
author:fbennett
date:2017-02-10 10:56 (JST)

Fix test failure after 27cb099c825

commit:0570c2e
author:Dan Stillman
date:2017-02-09 16:17 (JST)

Attachments are now saved before the connector server responds, because they’re no longer started out-of-band in saveItems(). This is necessary to prevent transaction badness during imports, but it may not be what we want for the connector, so we may want to revisit this after further testing.


Drastically speed up moving items to the trash

commit:3a0e0cb
author:Dan Stillman
date:2017-02-09 11:53 (JST)

E.g., moving 3,600 items to the trash now takes 4 seconds instead of 62

Instead of saving each item, update internal state and database directly (which is more brittle but worth it). Also avoid unnecessary sorting after removing an item from the items tree.


Update ProgressWindow constructor call after c00db272f

commit:58edb31
author:Dan Stillman
date:2017-02-09 11:23 (JST)

Don’t select items added via import

commit:ed047f0
author:Dan Stillman
date:2017-02-09 11:19 (JST)

Make sure ‘collections’ passed to Translate is an array

commit:a4572c9
author:Dan Stillman
date:2017-02-09 04:58 (JST)

Allow asynchronous item saving in import translators

commit:27cb099
author:Dan Stillman
date:2017-02-09 04:44 (JST)

This allows for imported items to be saved individually instead of being saved in a batch after processing the entire imported file (which for large imports would hang the UI, even if the actual saving was asynchronous). This also fixes the progress meter during asynchronous saves.

To take advantage of this, import translators will need to return a promise when available (using the native Promise object) from doImport() and wait for optional promises from item.complete().

The logic here can probably be streamlined further. (E.g., we might be able to say that item.complete() always returns a promise.) It’s complicated by the fact that, at the moment, Promise isn’t available in child sandboxes, though this can probably be fixed.

Tests forthcoming, but they require a translator that supports this, which needs to be committed separately.

View with -w for a cleaner diff.


Allow altering text in a ProgressWindow line in OO mode

commit:3e35764
author:Dan Stillman
date:2017-02-09 04:32 (JST)

And fix progress meter display


Fix additional file sync error with no remote stored hash

commit:12ad749
author:Dan Stillman
date:2017-02-09 04:12 (JST)

Follow-up to c9694e93b0


Fix handling of some old-style URLs in zotero:// protocol handler

commit:1ea80c4
author:Dan Stillman
date:2017-02-08 14:20 (JST)

Repairs for jurisdiction UI and data

commit:ea683d6
author:fbennett
date:2017-02-08 11:05 (JST)

Add text color buttons to notes, and move direction to context menu

commit:fe063fa
author:Dan Stillman
date:2017-02-04 05:31 (JST)

And reduce button spacing slightly to accommodate

Closes #1151


Update empty state of parent collection when deleting subcollection

commit:55e9a0e
author:Dan Stillman
date:2017-02-03 15:17 (JST)

Fix csledit

commit:a57ea28
author:Dan Stillman
date:2017-02-03 14:53 (JST)

Closes #1149

(There’s an additional change in #1149, but as far as I can tell it’s not necessary for csledit.xul.)


Remove temporary debugging buttons in prefs

commit:3a2fb29
author:Dan Stillman
date:2017-02-03 14:06 (JST)

Fix moving items between collections

commit:1a49018
author:Dan Stillman
date:2017-02-03 14:04 (JST)

mozSourceNode seems to no longer be set in dataTransfer objects during drags, so we now store it in Zotero.DragDrop.


Don’t unload object on save error if not new

commit:76bc61e
author:Dan Stillman
date:2017-02-03 12:34 (JST)

Return array copy in ItemFields.getItemTypeFields()/getTypeFieldsFromBase()

commit:79a07ca
author:Dan Stillman
date:2017-02-03 08:42 (JST)

Require DB transaction in Zotero.Collection.prototype.removeItems()

commit:7ede523
author:Dan Stillman
date:2017-02-03 08:39 (JST)

For consistency with Zotero.Collection.prototype.addItems()


Don’t select last item in list when item is removed from collection

commit:f98de97
author:Dan Stillman
date:2017-02-03 08:37 (JST)

Fix translation error reporting in connectors

commit:9ecfc31
author:Adomas Venčkauskas
date:2017-02-03 04:16 (JST)

Closes zotero/zotero-connectors#101


Update TinyMCE to 4.5.2

commit:0998c1d
author:Dan Stillman
date:2017-02-02 14:23 (JST)

Don’t localize “OpenURL”

commit:0b9b758
author:Dan Stillman
date:2017-02-02 07:07 (JST)

Use entity_encoding: ‘raw’ in notes

commit:bd8debb
author:Dan Stillman
date:2017-02-02 06:56 (JST)

This (and some other things) will help avoid changes in uploaded notes, which cause loss of cursor position and other problems after local notes are updated with the server version.

A side effect is that multiple spaces won’t be converted to &nbsp;, so anything consuming note content will have to use white-space: pre.

(Notes in reports appear to be substituting &nbsp; as necessary, though I’m not sure where that’s happening.)


Address debug reporting in connector (zotero/zotero-connectors#97)

commit:ef0d9af
author:Adomas Venčkauskas
date:2017-02-01 07:46 (JST)

Fix broken date class (regression 38b0fb2)

commit:21a7a49
author:Adomas Venčkauskas
date:2017-02-01 07:02 (JST)

Zotero.Promise.coroutine not supported in connector shared code (broken ef1ff8b)

commit:38b0fb2
author:Adomas Venčkauskas
date:2017-02-01 07:00 (JST)

Update translate error report with promisified info (broken c3dcaf9)

commit:c4d39ba
author:Adomas Venčkauskas
date:2017-02-01 06:15 (JST)

More report note fixes

commit:26eebcf
author:Dan Stillman
date:2017-02-01 03:56 (JST)

Restore handling of plaintext notes from before 835003dd6d3, and search for a wider set of HTML indicators to avoid showing markup when no <p> tags.


Don’t modify options object passed to DataObject.save()

commit:4871374
author:Dan Stillman
date:2017-01-31 06:07 (JST)

Parse note content in reports as HTML instead of XML

commit:835003d
author:Dan Stillman
date:2017-01-31 15:23 (JST)

And remove raw-markup fallback when not XML


Fix #1163, Unable to open zotero urls from tinymce

commit:ae47ae2
author:Dan Stillman
date:2017-01-31 04:01 (JST)

Fix mangled output from Zotero.Utilities.getAsyncInputStream()

commit:b073c3e
author:Dan Stillman
date:2017-01-31 03:33 (JST)

Proper fix (as opposed to 5236d01791f) for https://forums.zotero.org/discussion/64022/5-0-beta-generate-report-is-often-garbled


Ensure modified item stays visible

commit:10111db
author:Dan Stillman
date:2017-01-29 23:18 (JST)

There seems to be a bug here where, if the item is off-screen when modified, it doesn’t become visible, but it now does stay visible when it’s on-screen to begin with.


Fix 412 after choosing local file on file conflict

commit:48a81e3
author:Dan Stillman
date:2017-01-29 21:50 (JST)

Add option to Zotero.ProgressWindow to not close on click

commit:c00db27
author:Dan Stillman
date:2017-01-28 11:05 (JST)

ProgressWindow now takes an options object instead of a window (which is now an available option, along with ‘closeOnClick’)


Fix importing of files using relative paths

commit:4d56191
author:Dan Stillman
date:2017-01-28 10:51 (JST)

Update translators

commit:a33c53d
author:Dan Stillman
date:2017-01-28 07:46 (JST)

Make ZFS file syncing always enabled for publications library for now

commit:22d4603
author:Dan Stillman
date:2017-01-28 04:14 (JST)

At least until we have a better interface for setting library-specific sync settings

Previously, if My Library file syncing was disabled or set to WebDAV, My Publications files wouldn’t be uploaded.


Fix error in recursiveCollections mode with huge number of subcollections

commit:2797479
author:Dan Stillman
date:2017-01-28 02:00 (JST)

Fix truncated reports with multi-byte characters

commit:e6d7ae8
author:Dan Stillman
date:2017-01-27 12:32 (JST)

Fix misplaced line in e23452363b

commit:31ed9bd
author:Dan Stillman
date:2017-01-27 08:29 (JST)

Automatically use remote version when two items in trash are in conflict

commit:aec9b2a
author:Dan Stillman
date:2017-01-27 08:07 (JST)

Handle auto-hyphenated ISBN during item conflict

commit:e234523
author:Dan Stillman
date:2017-01-27 05:02 (JST)

Always keep the hyphenated version, and don’t consider it a visible conflict


Fix “Show in Library” in item context menu

commit:3a1bec1
author:Dan Stillman
date:2017-01-26 16:57 (JST)

Fix extended characters in reports (since 5236d01791)

commit:2553206
author:Dan Stillman
date:2017-01-26 15:52 (JST)

Fix error generating reports

commit:3415aae
author:Dan Stillman
date:2017-01-25 05:42 (JST)

9b247ebba7c follow-up


Don’t show incorrect instructions for adding Locate engines

commit:50b7dd3
author:Dan Stillman
date:2017-01-24 17:50 (JST)

Not currently possible in 5.0

https://github.com/zotero/zotero-connectors/issues/92


Update locales from Transifex

commit:1344219
author:Dan Stillman
date:2017-01-24 17:48 (JST)

Rename “Full Sync” to “Reset Data Sync History”, and don’t start sync

commit:cfa15a3
author:Dan Stillman
date:2017-01-24 17:38 (JST)

This allows generating debug output for full sync of a single library.

Also clarify some dialog text


Enable 45 ESR for Travis, since it’s still used on Windows

commit:134e77b
author:Dan Stillman
date:2017-01-24 16:53 (JST)

Update submodules

commit:c3ba734
author:Dan Stillman
date:2017-01-24 16:51 (JST)

Allow number or name for translator type in buildDummyTranslator()

commit:a43f9d1
author:Dan Stillman
date:2017-01-23 22:58 (JST)

This reverts c6b78da69d6, which changed it to expect numbers when I noticed the type being undefined in debug output, but apparently the only tests where the type actually mattered passed it as a name.

At some point we should just change all tests to pass as a name.


Fix item key search (broken by a01f2765e4)

commit:edb08e1
author:Dan Stillman
date:2017-01-23 22:46 (JST)

Fix quick search and quick format bar (broken in 9b247ebba7c)

commit:a01f276
author:Dan Stillman
date:2017-01-23 22:25 (JST)

As evidenced by majorly failing tests


Temporary prefs buttons to debug slow DB issue

commit:249f9c6
author:Dan Stillman
date:2017-01-23 21:20 (JST)

Fix translatorType in dummy translators in tests

commit:c6b78da
author:Dan Stillman
date:2017-01-23 21:02 (JST)

Fix push sync for group libraries

commit:41413b1
author:Dan Stillman
date:2017-01-23 20:45 (JST)

Make sure translator file ends with newline when saving

commit:cddc84f
author:Dan Stillman
date:2017-01-23 19:57 (JST)

Fixes https://github.com/zotero/scaffold/issues/37


Fix file upload error when remote attachment has no stored hash

commit:c9694e9
author:Dan Stillman
date:2017-01-23 05:30 (JST)

Disable script run time warning in tests

commit:90a3013
author:Dan Stillman
date:2017-01-21 20:37 (JST)

Fix item keys in report ids

commit:b3c28dc
author:Dan Stillman
date:2017-01-21 20:36 (JST)

Fix mangled large reports

commit:5236d01
author:Dan Stillman
date:2017-01-21 20:33 (JST)

https://forums.zotero.org/discussion/64022/5-0-beta-generate-report-is-often-garbled

Records are being truncated, though I’m not sure why. But just read the input stream into a string for now.


Fix error trying to generate report for many items

commit:9b247eb
author:Dan Stillman
date:2017-01-21 17:38 (JST)

When adding many search conditions (e.g., when matching many items with the key condition), the query can fail due to either the bound parameter limit or the expression tree size limit.

To avoid this, add support for an ‘inlineFilter’ property on search conditions when using the ‘is’ or ‘isNot’ operator. ‘inlineFilter’ is a function that returns a quoted value suitable for direct embedding in the SQL statement, or false if not valid. Multiple consecutive conditions for the same ‘inlineFilter’ field are combined into an IN (x, y, z) condition.


Merge new English strings

commit:dcd1da7
author:Dan Stillman
date:2017-01-20 07:21 (JST)

“Import”/”Import from Clipboard” shortcut key changes

commit:cc51600
author:Dan Stillman
date:2017-01-20 05:20 (JST)
  • Add Cmd/Ctrl-Shift-I for “Import…”
  • Cmd/Ctrl-Shift-V apparently pastes without formatting, so don’t override it. Instead, add a shortcut key to the menu option, defaulting to Cmd-Option-Shift-I/Ctrl-Alt-Shift-I
  • The I in both is now localizable

Fix attachment content search

commit:362e18c
author:Dan Stillman
date:2017-01-20 03:32 (JST)

And always convert ids from GROUP_CONCAT() to integers in search code.


Use Firefox 50.1.0 for Travis

commit:751ab9d
author:Dan Stillman
date:2017-01-20 02:38 (JST)

Fix #1157, Note content lost when typing during sync

commit:c95e422
author:Dan Stillman
date:2017-01-20 01:58 (JST)

Someday, I will say this is fixed and it actually will be fixed.


Update submodules

commit:e0d92ec
author:Dan Stillman
date:2017-01-19 19:48 (JST)

Skip a case of item selection during syncing

commit:318f665
author:Dan Stillman
date:2017-01-19 12:25 (JST)

Don’t allow deleting libraries other than feeds with Cmd/Ctrl-Delete

commit:57b4428
author:Dan Stillman
date:2017-01-17 21:12 (JST)

Fix a couple issues with bundled file timestamps

commit:b62139e
author:Dan Stillman
date:2017-01-18 11:48 (JST)

Fix test for invalid id passed to DataObjects.getAsync()

commit:2237c71
author:Dan Stillman
date:2017-01-17 18:18 (JST)

Limit depth to 1 when outputting data objects

commit:33deefb
author:Dan Stillman
date:2017-01-17 16:58 (JST)

This prevents descending into the global object cache that’s accessible from every data object.


Add Zotero.isClient

commit:1cf2585
author:Dan Stillman
date:2017-01-17 16:58 (JST)

To replace Zotero.isStandalone


Add maxDepth as the third argument to Zotero.debug()

commit:786f5ef
author:Dan Stillman
date:2017-01-17 16:31 (JST)

varDump(), which is used by Zotero.debug(), defaults to 5


Fix Zotero.Date methods within translator sandbox

commit:a017fe6
author:Dan Stillman
date:2017-01-17 16:23 (JST)

Only a few methods are imported, so some of the changes in 7bdcc17ed have to be reverted.


Fix more info link in update prompt

commit:b00d136
author:Dan Stillman
date:2017-01-16 16:56 (JST)

Merge pull request #1156 from gracile-fr/master

commit:8a759dc
author:Dan Stillman
date:2017-01-17 15:33 (JST)

Amend short form of French months (continuing #64)


Amend short form of French months (continuing #64)

commit:695cb95
author:gracile-fr
date:2017-01-16 23:54 (JST)

The Firefox French language pack contains some mistakes regarding the short form of months. As a consequence, French month parsing didn’t work.

Please note that these values aren’t even the correct abbreviations but only the three or four first letters of the correct abbreviations. See the French CSL locale for the correct abbreviations.


Fix error refreshing document with item replaced by merge

commit:aa78387
author:Dan Stillman
date:2017-01-16 06:47 (JST)

Update locales from Transifex

commit:3d83f5f
author:Dan Stillman
date:2017-01-16 05:45 (JST)

About pane updates

commit:e5ba761
author:Dan Stillman
date:2017-01-16 05:19 (JST)
  • Make version copyable
  • Include “What’s new” link to changelog
  • Update some links and descriptions

To-do:

  • Replace dev credits with a nice statement like in the Firefox About pane

Preload external abbreviations for quickCopy and bib export

commit:9d0be2b
author:fbennett
date:2017-01-15 23:40 (JST)

Tidy up logfile chatter

commit:d9514c8
author:fbennett
date:2017-01-15 23:38 (JST)

Update citeproc-js to 1.1.145

commit:fdc19d0
author:fbennett
date:2017-01-15 23:37 (JST)

Tidy up some install-time logfile chatter

commit:a6912c3
author:fbennett
date:2017-01-15 23:37 (JST)

Fix CSL Preview pane

commit:23f84d7
author:Dan Stillman
date:2017-01-15 16:46 (JST)

CSL Editor is being fixed in #1149


Fix debug output logging (broken by f44264cd4)

commit:008bcff
author:Dan Stillman
date:2017-01-15 08:39 (JST)

Compatibility fixes for Bluebird >=3.4.2

commit:3d569f1
author:Dan Stillman
date:2017-01-15 08:01 (JST)

Before 3.4.2, yield in a Bluebird coroutine() released Zalgo if an already-resolved promise (e.g., from Promise.resolve()) was yielded, continuing immediately instead of on the next turn of the event loop. We apparently relied on that broken behavior in a few places, particularly from Zotero.DB.waitForTransaction(). All the transaction-queueing stuff probably needs to be reevaluated in general, but for now, mirror the previous possibly ill-advised behavior by checking explicitly for a transaction before yielding on waitForTransaction() (as well as the result of a ‘load’ event from libraryTreeView).


Use coroutine() for Zotero.Schema::_updateSchema()

commit:7e30afb
author:Dan Stillman
date:2017-01-14 11:16 (JST)

Throw clearer error if invalid type is passed to File.getContentsAsync()

commit:56d9372
author:Dan Stillman
date:2017-01-13 20:51 (JST)

Fix passing file: URI to Zotero.File.getContentsAsync()

commit:f2440eb
author:Dan Stillman
date:2017-01-13 20:48 (JST)

Add HTML-based console viewer for easier real-time debug output

commit:f44264c
author:Dan Stillman
date:2017-01-15 07:03 (JST)

Since 1) debug output logging via the prefs isn’t necessarily possible for startup errors in Standalone, 2) real-time output is prohibitively slow and has a miniscule scrollback buffer on Windows unless you use a Cygwin or Git terminal, and 3) copying/pasting/emailing was annoying anyway, make -ZoteroDebug open a popup window that shows errors and debug output and allows submitting straight to the server with a Debug ID.

This should replace the existing debug output viewer as well, but that’s less of a priority.

-ZoteroDebugText or the debug.log pref can still be used to dump to the terminal.


Update Bluebird to 3.4.7

commit:9c0befc
author:Dan Stillman
date:2017-01-13 16:03 (JST)

Don’t connect to streaming server until UI is ready

commit:12de046
author:Dan Stillman
date:2017-01-13 15:42 (JST)

Fix startup error loading Zotero service

commit:bc03408
author:Dan Stillman
date:2017-01-13 16:36 (JST)

https://forums.zotero.org/discussion/63869/5-0-beta-standalone-blank-ui-upon-restart https://forums.zotero.org/discussion/63865/5-0-beta-library-wont-load

Adding include.js to hiddenWindow.xul in 66549f9e6d seems to have created a race condition in which the Zotero service would fail on the third startup after the JS cache was cleared (e.g., on a new version, -purgecaches, or other changes in the profile). So, don’t do that.

Hopefully this isn’t caused by other uses (e.g., in plugins) of include.js and was only happening because the hidden window is launched concurrently with standalone.xul on macOS.


Don’t focus note editor when pressing Shift-Tab on note in middle pane

commit:2011a61
author:Dan Stillman
date:2017-01-12 16:38 (JST)

Reverts redundant code from 7e39e4608 (#1136) and fixes the much earlier 9d7cc849 (#151)


Expand draggable area of splitters on macOS while preserving 1px width

commit:740795f
author:Dan Stillman
date:2017-01-12 16:16 (JST)

(Borrowing a technique from Thunderbird.)

This only affects the splitters in standard view. The splitter between the top and bottom panes in stacked view still has a 1px draggable area.

We can probably do a similar thing to slim down splitters on Windows, as planned in #367.


Fix opening preferences (broken in cbcfb6b92)

commit:66549f9
author:Dan Stillman
date:2017-01-11 20:23 (JST)

Move feeds below groups

commit:cf2318e
author:Dan Stillman
date:2017-01-11 13:53 (JST)

Fix missing Options menu on Windows/Linux

commit:cbcfb6b
author:Dan Stillman
date:2017-01-11 11:26 (JST)

Default to creatorType: “author” if missing

commit:c631bc4
author:Dan Stillman
date:2017-01-11 08:01 (JST)

Apparently in 4.0 we defaulted to ‘author’ if a creatorType wasn’t passed. To avoid lots of errors like the one fixed in https://github.com/zotero/translators/commit/dd0094893af003b8f545bfae1ec440fc4199c261, add a similar fallback for 5.0 and log a warning (though not with the translator name, unfortunately).


Update submodules

commit:97f5c41
author:Dan Stillman
date:2017-01-10 15:57 (JST)

Update locales from Transifex

commit:fb7592b
author:Dan Stillman
date:2017-01-09 18:53 (JST)

Fix #64, Non-English month parsing doesn’t work in Standalone

commit:ef1ff8b
author:Dan Stillman
date:2017-01-09 18:21 (JST)

Month values from the Firefox language packs are included in a JSON file used by Zotero.Date.getMonths(). getMonths(true) includes English months as well.

The JSON file should be bundled with the connectors as well, and Zotero.Date.init() should be updated to populate the month data from that.


Convert some private Zotero.Date methods to privileged

commit:7bdcc17
author:Dan Stillman
date:2017-01-09 18:20 (JST)

Update Edit menu strings in non-English locales

commit:9fbdc77
author:Dan Stillman
date:2017-01-07 19:32 (JST)

Remove localizations in standalone.dtd and replace with editMenuOverlay.dtd files from the Mozilla language packs

Also remove some other unused strings


Fix localization of Edit menu

commit:5dbe677
author:Dan Stillman
date:2017-01-07 15:01 (JST)

Merge pull request #1148

commit:7444e63
author:Dan Stillman
date:2017-01-09 14:11 (JST)

Remove tmp-

  • directories when attachment download fails. Closes #1128

Closes #1148


Remove tmp-

  • directories when attachment download fails. Closes #1128
commit:74d358b
author:Adomas Venčkauskas
date:2017-01-07 00:06 (JST)

Run generateBibliography of csledit as an iterator, add abbrev preload support

commit:1a64f0e
author:fbennett
date:2017-01-09 13:48 (JST)

Merge branch ‘jurism-5.0-dev’ into jurism-5.0

commit:d053824
author:fbennett
date:2017-01-09 13:34 (JST)

Let AbbrevsFilter manage itself

commit:8d3ec05
author:fbennett
date:2017-01-09 13:31 (JST)

Update processor to 1.1.144

commit:7427823
author:fbennett
date:2017-01-09 13:28 (JST)

Only set browser.dom.window.dump.enabled in client

commit:43dad62
author:Dan Stillman
date:2017-01-08 07:41 (JST)

Fix non-standard syntax

commit:abd3054
author:Tom Najdek
date:2017-01-06 23:37 (JST)

Use sorted array of visible styles in csledit

commit:2ac05b7
author:fbennett
date:2017-01-07 12:12 (JST)

Update locales from upstream master

commit:db66c57
author:fbennett
date:2017-01-07 11:43 (JST)

Merge changes from upstream master

commit:dbc4230
author:fbennett
date:2017-01-07 11:39 (JST)

Update submodules

commit:1b3dfe1
author:Dan Stillman
date:2017-01-06 17:43 (JST)

Update locales from Transifex

commit:eba7239
author:Dan Stillman
date:2017-01-06 17:42 (JST)

Remove use of deprecated Date.toLocaleFormat

commit:2682d01
author:Adomas Venčkauskas
date:2017-01-06 16:58 (JST)

Merge pull request #1144

commit:231a276
author:Dan Stillman
date:2017-01-05 13:40 (JST)

Preserve format tags and entities in bibliography editor

Closes #1144


Preserve formatting on Hide/Show editor

commit:4d8d4bc
author:fbennett
date:2017-01-05 09:57 (JST)

Accept variations in spacing, and single-quoted XML serialization

commit:2538e25
author:fbennett
date:2017-01-04 21:34 (JST)

Preserve format tags and entities in bibliography editor - Fixes errors in previous commits 55bfe54a and 9431e0de, to wit … - Apply unescapeHTML after RTF tag and entity conversions - Remove high-bit character escape from entity converter, and apply separately after remaining HTML entities are decoded by unescapeHTML

commit:2a2e5e4
author:fbennett
date:2017-01-04 11:08 (JST)

Allow showing the Tools -> Error Console menu option via a pref

commit:53d2aa4
author:Dan Stillman
date:2017-01-05 09:14 (JST)

If devtools.errorconsole.enabled is true, the option will be shown.


Set browser.dom.window.dump.enabled to true if debug output enabled

commit:56b6a0d
author:Dan Stillman
date:2017-01-05 07:28 (JST)

dump() works regardless within XPCOM (which is how Zotero.debug() works), but not on window objects without this pref


Allow setting global prefs from Zotero.Prefs.set()

commit:612066d
author:Dan Stillman
date:2017-01-05 07:28 (JST)

Pass true as third argument


Don’t leave document corrupted if error in doc prefs window

commit:42a72fe
author:Dan Stillman
date:2017-01-04 15:39 (JST)

And recover by showing the doc prefs window if it is corrupted (at least with an empty fieldType, which is what was happening previously)


Merge from upstream 5.0

commit:94c3754
author:fbennett
date:2017-01-04 06:28 (JST)

Increase DB timeout to 30 seconds

commit:4ff5323
author:Dan Stillman
date:2017-01-04 05:50 (JST)

Though it would be real nice to avoid situations where this might be necessary


Make itemPane white on linux

commit:1756b8d
author:Adomas Venčkauskas
date:2017-01-04 01:25 (JST)

Fix black tab borders on Standalone (regression 53d1bca36)

commit:ac959dd
author:Adomas Venčkauskas
date:2017-01-04 02:13 (JST)

It appears we do not have ThreeDHighlight in Standalone. Relevant bug https://bugzilla.mozilla.org/show_bug.cgi?id=1261068


Fixes a few UI styling issues for Ubuntu 16.10 (GTK 3.20)

commit:53d1bca
author:Adomas Venčkauskas
date:2017-01-04 00:51 (JST)
  • Tabs missing styling
  • Preferences: Notes font menulist dropmarker missing (left border still missing, could not find any CSS to help that out)
  • Preferences: Numberbox background gray

For the tabs styling issue see https://bugzilla.mozilla.org/show_bug.cgi?id=1306425


Remove lines in treeview separators

commit:98ab5ac
author:Dan Stillman
date:2017-01-03 20:14 (JST)

Not ideal – we can’t reduce the height of separators, so there’s too much padding between sections – but still better (and way better on Linux, where a thick black line was being drawn instead of the light dashes on macOS).


Fix hang on sync restart

commit:6096d1e
author:Dan Stillman
date:2017-01-03 18:40 (JST)

Use Zotero.DBConnection instance everywhere instead of Zotero.DB

commit:5d67656
author:Dan Stillman
date:2017-01-03 18:21 (JST)

Fixes #1141


Mark style load failures

commit:83692b4
author:fbennett
date:2017-01-03 10:19 (JST)

Fix pressing “-” and “+” buttons in Styles pane from keyboard

commit:5523dd5
author:Dan Stillman
date:2016-12-30 15:22 (JST)

Allow direct install from styles page in viewer

commit:0757109
author:Dan Stillman
date:2016-12-30 15:00 (JST)

When “Get Additional Styles…” is clicked, open a stripped-down version of the Zotero styles page in a window. When a style is clicked on, install it and close the window.

I’m going to say that this closes #767, but as Aurimas notes there, if you know the style you’re looking for, being able to just type the name in a dialog would be faster, so further improvements could be made. But as it stands, this is much better than clicking through to a browser (and hoping that it’s one with the new connector with style installation support).


Allow Cmd-R/Ctrl-R to reload page in basic viewer

commit:c21d6c9
author:Dan Stillman
date:2016-12-30 14:58 (JST)

Move ZoteroStandalone.openInViewer() to Zotero.openInViewer()

commit:fb7f969
author:Dan Stillman
date:2016-12-30 14:56 (JST)

Update some deprecated function calls

commit:a076edc
author:Dan Stillman
date:2016-12-30 05:39 (JST)

Push-based sync triggering

commit:2beb2c5
author:Dan Stillman
date:2016-12-30 11:24 (JST)

Immediate sync triggering on remote library change using WebSocket API. Currently kicks off a normal sync process for the modified library – actual object data isn’t pushed.

(This might not stay enabled for 5.0 Final.)


Fix New Item MRU list, which apparently has only ever updated on startup

commit:7fd3a8c
author:Dan Stillman
date:2016-12-29 21:01 (JST)

Reduce initial visible creators to 5-7 (from 10-15)

commit:8a9986d
author:Dan Stillman
date:2016-12-29 17:57 (JST)

Add option to Zotero.Utilities.ellipsize() to truncate at word boundary

commit:9ffab20
author:Dan Stillman
date:2016-12-28 13:54 (JST)

Fix right alignment of search bar

commit:516fedc
author:Dan Stillman
date:2016-12-28 03:52 (JST)

Item pane tweaks

commit:c0f40fa
author:Dan Stillman
date:2016-12-28 03:49 (JST)
  • Remove colons after labels
  • Non-bold labels
  • More padding at top of pane
  • Increase space between label and field

Hide Actions menu in Standalone

commit:82292ee
author:Dan Stillman
date:2016-12-28 02:38 (JST)

Leave it in place in Firefox for now for development


Fix dragging external files onto library root

commit:e282a56
author:Dan Stillman
date:2016-12-27 17:11 (JST)

Make Zotero.Translator shareable with connector

commit:b01487d
author:Adomas Venčkauskas
date:2016-12-29 00:25 (JST)

Update French locale from Transifex

commit:eeee937
author:Dan Stillman
date:2016-12-27 09:18 (JST)

Fix selecting item and scrolling into view when editing a citation

commit:4a765aa
author:Dan Stillman
date:2016-12-27 08:50 (JST)

Add collectionTreeView::selectItem()

commit:5100cd3
author:Dan Stillman
date:2016-12-27 08:44 (JST)

This moves most selection logic from ZoteroPane.selectItem() into collectionTreeView::selectItem() so that it can be used in the edit-citation dialog.

Unlike itemTreeView::selectItem(), which only selects within a given items tree, this function automatically switches to a library root if necessary. ZoteroPane.selectItem() remains and does a little bit extra (unminimizing Zotero, focusing the items pane) in addition to calling collectionTreeView::selectItem().


Fix file handling when Zotero is launched from close on Windows

commit:99152d7
author:Dan Stillman
date:2016-12-27 07:09 (JST)

When opening CSL, BibTeX, etc.


Object.values() polyfill for <Fx47 after 269e2f8b

commit:437c55b
author:Dan Stillman
date:2016-12-27 05:17 (JST)

Zotero for Windows is still built with Fx45, so we need a polyfill for Object.values().


Keep TinyMCE dialogs within frame

commit:044ecf2
author:Dan Stillman
date:2016-12-27 03:05 (JST)

This isn’t ideal, but it mostly works, and keeps the dialogs vertically (if not horizontally) moveable. It would be nice if the dialogs automatically flowed to the available width.

This could be turned off in standalone note windows above a certain width.


Fix newlines in note HTML files

commit:6ec2f9a
author:Dan Stillman
date:2016-12-27 01:27 (JST)

Prevent data loss if objects change locally during sync upload

commit:6d1946e
author:Dan Stillman
date:2016-12-25 07:55 (JST)

If an object was uploaded but was changed locally during the upload (e.g., the user typing in a note), the local changes would be lost when the remotely saved version was applied. Instead, watch for modifications to objects during the upload and don’t apply the remote versions of those objects or mark them as synced.


Widen style dropdown in note editor to accommodate other languages

commit:e75827b
author:Dan Stillman
date:2016-12-26 17:15 (JST)

Localize TinyMCE

commit:6c260bc
author:Dan Stillman
date:2016-12-26 17:12 (JST)

Automatically use a language pack for the current locale if one is available


Add a notifier event for sync start

commit:8af73f9
author:Dan Stillman
date:2016-12-25 08:01 (JST)

Fix error adding top-level attachments in collections

commit:0a2330b
author:Dan Stillman
date:2016-12-26 01:48 (JST)

Fix alignment of “Format” in export dialog

commit:653f26d
author:Dan Stillman
date:2016-12-24 01:07 (JST)

Increase default note font size to 12

commit:d7809d6
author:Dan Stillman
date:2016-12-26 13:11 (JST)

Upgrade to TinyMCE 4.5.1

commit:dc04a12
author:Dan Stillman
date:2016-12-26 13:03 (JST)
  • New flat theme (with padding tightened a bit from the default to fit in right-hand pane)
  • Adds search/replace within notes
  • Adds URL autolinking
  • Image pasting/dragging is now properly disallowed (though TinyMCE 4 has hooks that may allow us to actually support this by automatically creating attachments)
  • New blockquote style with color bar
  • Replaces custom context menu on link click with built-in version
To-do:
  • Fix display of pop-ups, which are now modal dialogs within the note frame instead of pop-up windows, to stay fully within the frame
  • Localize (more important now that there are tooltips)
  • Support image dragging
  • Update elements list for HTML5, for better drag-and-drop?
  • Move directionality control to context menu instead of taking up toolbar space?
  • Evaluate other plugins for potential inclusion
  • Show additional controls in separate note window?
  • Fix opacity of text in tooltips

Closes #451, closes #421


Fix “Reset File Sync History”

commit:ab959cd
author:Dan Stillman
date:2016-12-23 00:00 (JST)

Don’t start auto-sync until UI is ready

commit:cf686c5
author:Dan Stillman
date:2016-12-22 20:58 (JST)

Apply UI font size change immediately

commit:bd95012
author:Dan Stillman
date:2016-12-22 20:31 (JST)

And change “Changes take effect in new windows” to “Changes take effect after restart”

(The note font size still requires a restart, as do the shortcut keys in the Advaned pane.)


Add a friendlier GET request message for /connector/ping

commit:bd943ff
author:Adomas Venčkauskas
date:2016-12-22 20:14 (JST)

Show stack for more startup errors

commit:455f23d
author:Dan Stillman
date:2016-12-21 22:30 (JST)

Set API URL via pref for download-on-demand test

commit:a9a54ed
author:Dan Stillman
date:2016-12-21 22:23 (JST)

Merge pull request #1111

commit:36b6722
author:Dan Stillman
date:2016-12-21 22:07 (JST)

Remove occurrences of legacy/non-standard/non-strict js syntax

Closes #1111


Remove use of syntax where curly brackets are omitted in function defs

commit:d4dc86c
author:Tom Najdek
date:2016-10-16 04:20 (JST)

Remove non-standard syntax for conditional exception handling

commit:54a2126
author:Tom Najdek
date:2016-10-15 01:24 (JST)

Remove use of non-standard list comprehension syntax

commit:39bc539
author:Tom Najdek
date:2016-10-16 23:24 (JST)

Fix non-strict syntax for octal number literals

commit:03b1b75
author:Tom Najdek
date:2016-10-16 10:03 (JST)

Replace legacy syntax for each…in with for…of

commit:269e2f8
author:Tom Najdek
date:2016-10-18 21:20 (JST)

Closes #974, Unreachable code after return statement

commit:b445283
author:Dan Stillman
date:2016-12-21 21:48 (JST)

Limit Travis to Fx version used for Standalone

commit:9b1b360
author:Dan Stillman
date:2016-12-21 21:36 (JST)

Focus note editor when pressing Tab is pressed on note in middle pane

commit:7e39e46
author:Dan Stillman
date:2016-12-21 20:13 (JST)

Closes #1136


Make API server configurable with extensions.zotero.api.url

commit:084f5a7
author:Dan Stillman
date:2016-12-21 19:52 (JST)

Needless to say, use of this pref is unsupported.

Closes #901


Fix Travis failure after skipped test

commit:205bab7
author:Dan Stillman
date:2016-12-21 19:28 (JST)

Apparently after() is run even if a test is skipped


Remove tab mode

commit:3b6b6aa
author:Dan Stillman
date:2016-12-21 19:01 (JST)

Closes #1135


Disable connector switching

commit:405f41f
author:Dan Stillman
date:2016-12-21 18:42 (JST)

And so it begins…

Closes #1134


Fix connector translator caching from repo and standalone

commit:8e083c6
author:Adomas Venčkauskas
date:2016-12-19 18:38 (JST)

Better error logging for https://forums.zotero.org/discussion/63029/

commit:2f65c7d
author:Dan Stillman
date:2016-12-20 17:33 (JST)

Remove sync server URL

commit:0f89d4d
author:Dan Stillman
date:2016-12-20 04:39 (JST)

Fix for child attachments being saved if prefs off (from 8c2c097c6)

commit:c103595
author:Dan Stillman
date:2016-12-19 18:19 (JST)

Disable all recognizePDF tests in Travis

commit:4b602ed
author:Dan Stillman
date:2016-12-18 23:18 (JST)

Fix attachment handling during translation

commit:8c2c097
author:Dan Stillman
date:2016-12-18 23:05 (JST)

Synchronously determine whether attachment saving should be attempted and only start attachment progress if it can


Update locales from Transifex

commit:d19d90a
author:Dan Stillman
date:2016-12-17 23:00 (JST)

Tweak recognizePDF fix, add test coverage, and enable manual tests

commit:6994c63
author:Dan Stillman
date:2016-12-17 22:01 (JST)

Still disabled in Travis until we mock the remote services


Prompt to try manual data dir migration again if Firefox is open

commit:e34bf4d
author:Dan Stillman
date:2016-12-17 21:42 (JST)

Fix PDF metadata retrieval after 78b1d2ee35

commit:6b0e3ac
author:Dan Stillman
date:2016-12-17 20:17 (JST)

Add option to check for updates on Standalone startup error

commit:bba874a
author:Dan Stillman
date:2016-12-16 19:59 (JST)

I think we might have come to regret not having this.


Add -s flag to runtests.sh to start at given file

commit:238ab80
author:Dan Stillman
date:2016-12-16 18:21 (JST)

Useful for restarting after spurious errors when using -f

E.g., ./runtests.sh -s syncEngine


Update submodules

commit:b7daef6
author:Dan Stillman
date:2016-12-16 17:27 (JST)

Add menu option for opening Error Console in Standalone, commented out

commit:5950bfd
author:Dan Stillman
date:2016-12-16 17:23 (JST)

Not sure we want to expose this, particularly since there are tons of spurious warnings in current builds due to a chrome registration issue, but it can be handy for debugging some issues.


Fix CSL/file import when Standalone is closed

commit:2f50b9b
author:Dan Stillman
date:2016-12-16 17:18 (JST)

This is a bit iffy, since at least on macOS the passed file seems to come in as either -file or -url at different times, but this seems to work on macOS and Windows. Needs further testing with a packaged version on Windows.


Fix switching out of full mode when started in connector mode

commit:04941f2
author:Dan Stillman
date:2016-12-16 17:13 (JST)

Previously, if Standalone was open and Firefox was opened in connector mode, ZoteroOverlay.onLoad() was never run, which meant that, among other things, the before-reload handler that closed the Zotero pane when switching out of full mode was never added.


Fix upgrade prompt after incompatible DB in Standalone

commit:3d117c4
author:Dan Stillman
date:2016-12-15 19:25 (JST)

Since 693c0286e, probably


Remove debug line and tweak whitespace/style

commit:50df62a
author:Dan Stillman
date:2016-12-15 14:27 (JST)

Pass failure response to Connector.callMethod callbacks

commit:cff7448
author:Adomas Venčkauskas
date:2016-12-14 23:02 (JST)

Remove coroutine from translate.js not supported in connector

commit:deb8503
author:Adomas Venčkauskas
date:2016-12-14 22:28 (JST)

From 7fc352b9


Fix removed translator handling in connectors

commit:a853bb0
author:Adomas Venčkauskas
date:2016-12-14 21:15 (JST)

Generate new saved search names within libraries, not globally

commit:c5527a8
author:Dan Stillman
date:2016-12-14 17:37 (JST)

Remove test for moving existing target dir during data dir migration

commit:7447525
author:Dan Stillman
date:2016-12-14 17:36 (JST)

Functionality removed in 0be67dbda58


Fix related items box after 8a4c8d2be05

commit:2c9c057
author:Dan Stillman
date:2016-12-14 17:36 (JST)

Update locales from Transifex

commit:426c767
author:Dan Stillman
date:2016-12-14 16:22 (JST)

Don’t allow data dir migration via prefs if directory exists

commit:0be67db
author:Dan Stillman
date:2016-12-14 16:12 (JST)

And treat an existing non-empty directory as a failure during the migration, since it should now never happen

Also suggest manually moving on Windows if more than 100 attachments


Throw if invalid object id passed to Zotero.DataObjects::getAsync()

commit:58f554a
author:Dan Stillman
date:2016-12-14 16:02 (JST)

Classic citation dialog fixes

commit:8a4c8d2
author:Dan Stillman
date:2016-12-14 15:57 (JST)
  • Fix loading for libraries that haven’t yet been loaded (including if the Zotero pane hasn’t yet been opened)
  • Show a loading message over the items tree
  • Fix item selection when editing citation (except if library data hasn’t yet been loaded, but that doesn’t happen in Standalone)

Run processCitationCluster() in an iterator

commit:483555c
author:fbennett
date:2016-12-14 11:15 (JST)

A little typographical cleanup

commit:93cfc22
author:Dan Stillman
date:2016-12-14 10:34 (JST)

Remove extra space in string

commit:32ae3ee
author:Dan Stillman
date:2016-12-14 10:29 (JST)

Align advanced feed settings dropmarker on OSX

commit:ead9eaf
author:Adomas Venčkauskas
date:2016-12-14 01:11 (JST)

Don’t bother deleting from sync cache when deleting feed items

commit:5862aa5
author:Dan Stillman
date:2016-12-13 23:46 (JST)

Update Fx minVersion to 45

commit:e1f2dbb
author:Dan Stillman
date:2016-12-13 23:12 (JST)

Update locales from Transifex

commit:b940890
author:Dan Stillman
date:2016-12-13 23:12 (JST)

Saner feed database management (#1131)

commit:d6d4e4b
author:Adomas Ven
date:2016-12-13 23:07 (JST)
  • Mark feedItems read in a single batch SQL update
  • Automatically remove old feed items
  • User-facing preference globally and per-feed for feed item expiration

Fix “Add Item by Identifier” (broken by 78b1d2ee3)

commit:7fc352b
author:Dan Stillman
date:2016-12-13 19:23 (JST)

And make lookup tests run when not on Travis, though we should still mock the HTTP requests.


Maybe fix race condition when updating translators manually at startup

commit:69430d7
author:Dan Stillman
date:2016-12-13 15:25 (JST)

If you got the timing just right, you could wipe out all your translators (though standard ones would be reinstalled on restart). Hopefully that’s fixed?


Improves proxy support (#1129)

commit:747c11c
author:Adomas Ven
date:2016-12-12 21:29 (JST)

Improves proxy support

  • Automatically detect and dehyphenise https proxies which use EZProxy HttpsHyphens
  • Web translators now pass around Zotero.Proxy instances which can proxify/deproxify urls passed to translate.setLocation() before calling translate.getTranslators()/ translate.detect()`. The proxy passing is done within connector background/injected processes and between standalone and connectors.
  • Proxy protocol unified with connectors. Connectors can now pass proxies to /connector/save_items. The proxies will be used to resolve true item and attachment urls when saving.

Closes zotero/zotero#578, zotero/zotero#721

Relevant zotero/zotero#34, zotero/zotero#556


Fix failures on Travis due to broken isDir

commit:c2ebcc9
author:Dan Stillman
date:2016-12-12 20:57 (JST)

Updates locales from Transifex

commit:3f32523
author:Dan Stillman
date:2016-12-12 18:14 (JST)

Fix replacement of existing item storage directories

commit:80f888f
author:Dan Stillman
date:2016-12-12 17:26 (JST)
  • Make Zotero.Attachments.createDirectoryForItem() delete existing directory instead of moving it to orphaned-files; also now returns a string path instead of an nsIFile
  • Use above function during file sync instead of _deleteExistingAttachmentFiles(), which was partly broken
  • Fix throwing on errors when saving some attachment types

Show “Loading…” in Quick Copy drop-down before list is loaded

commit:60ed6d4
author:Dan Stillman
date:2016-12-12 16:05 (JST)

Styles and translators have to be loaded before the list is displayed, so there can be a delay if the prefs are opened right at startup.


Fix potential translator initialization problem after 04516af552

commit:425838e
author:Dan Stillman
date:2016-12-12 16:04 (JST)

Encode item objects for upload

commit:6ec550c
author:fbennett
date:2016-12-12 08:09 (JST)

Test for stray multi segment

commit:e9c3f91
author:fbennett
date:2016-12-12 08:09 (JST)

Do not throw error on object without multi segment

commit:a9fa3a6
author:fbennett
date:2016-12-12 08:07 (JST)

Test fixture for itemToCSLJSON with portableJSON toggle

commit:e53c040
author:fbennett
date:2016-12-12 06:33 (JST)

Expected result from itemToCSLJSON with portableJSON toggle

commit:9e98d15
author:fbennett
date:2016-12-12 06:32 (JST)

Stir in some multilingual test data

commit:d088e9d
author:fbennett
date:2016-12-12 06:32 (JST)

Explicit assignments from encodeMlzContent/decodeMlzContent

commit:113a327
author:fbennett
date:2016-12-12 06:31 (JST)

encodeMlzContent/decodeMlzContent without side-effects

commit:7171fe0
author:fbennett
date:2016-12-12 06:28 (JST)

Don’t include child items in imported-item count

commit:2ead95b
author:Dan Stillman
date:2016-12-11 16:59 (JST)

Fix test

commit:85776a9
author:Dan Stillman
date:2016-12-11 16:55 (JST)

Update locales from Transifex

commit:d781f9c
author:Dan Stillman
date:2016-12-11 16:29 (JST)

Select items after importing from clipboard

commit:4d77977
author:Dan Stillman
date:2016-12-09 20:12 (JST)

And wait for async switch to My Library if in a non-editable view


Scroll first selected row into view in itemTreeView::selectItems()

commit:bb246e5
author:Dan Stillman
date:2016-12-09 20:08 (JST)

Separate out the enhanced ensureRowIsVisible() logic from selectItem() and call it from selectItems() as well on the first item in the set.


Fix opacity of lines in progress popup when using addLines()

commit:142694c
author:Dan Stillman
date:2016-12-09 20:05 (JST)

Lines default to 50%, but addLines() doesn’t provide a mechanism for updating the opacity, so all the callers that used addLines() showed as gray. Instead, just default to 100% when using addLines().


Import translation improvements

commit:78b1d2e
author:Dan Stillman
date:2016-12-09 18:36 (JST)
  • Don’t block the UI with a progress meter during imports. Instead, show a popup in the bottom right when the import is done that shows how many items were saved.

  • Fix hang when importing some files

  • Fix various problems with asynchronous operations/transactions
    • Use the save queue for imports instead of creating concurrent transactions that can time out
    • Wait for the save to finish before returning from the translate() promise. All save modes now use the save queue, so code that handled the non-save-queue process can probably be removed.
    • Serialize child attachments instead of running them concurrently. This might make multi-attachment saves a little slower, since they can’t download at the same time, but it avoids problems with concurrent transactions. We might be able to improve this to allow concurrent downloads, or allow concurrent saves for a limited number of items (e.g., from web saving) if not for larger imports.
  • Change collection handling during import, since UI is now active - Select the root collection at the beginning of the import - Assign items and collections to the root during the import instead

    of at the end

    • Don’t select other collections
  • Change a few ItemSaver functions to use promises and remove unnecessary callbacks. (This includes some connector code that needs to be tested.)

  • Change some parentID variables in ItemSaver to parentItemID for clarity, since collections are now handled in more places

To-do:

  • Save items in smaller batches instead of doing all in the same transaction
  • Show progress meter in a bottom-right popup during the import

Localized plural form support for Zotero.getString()

commit:c61a9dc
author:Dan Stillman
date:2016-12-11 07:07 (JST)

Zotero.getString() now takes a third parameter, num (which should also appear in params) to use when determining which plural form of the string to use. Localized strings should include all forms in the order specified in [1], separated by semicolons.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_and_Plurals


Fix result strings

commit:70249a8
author:fbennett
date:2016-12-09 22:35 (JST)

Fix syntax error in JM test

commit:53034a5
author:fbennett
date:2016-12-09 22:35 (JST)

Remove duplicate code

commit:f26049d
author:fbennett
date:2016-12-09 22:34 (JST)

Add .collections support to Zotero.Attachments.linkFromURL()

commit:9836f33
author:Dan Stillman
date:2016-12-09 17:10 (JST)

Move ItemGetter test to correct section

commit:9fbd84b
author:Dan Stillman
date:2016-12-09 15:18 (JST)

Sort translators in import filepicker drop-down

commit:0e72ee3
author:Dan Stillman
date:2016-12-09 09:24 (JST)

Stop using Zotero.lazy() for Zotero.Translators.init()

commit:04516af
author:Dan Stillman
date:2016-12-09 09:17 (JST)

It makes things too complicated with some of the logic necessary for bundled file updating.


Encode MLZ data before generating patch

commit:d880ae2
author:fbennett
date:2016-12-09 08:51 (JST)

Skip multi segment in test

commit:923673d
author:fbennett
date:2016-12-09 08:50 (JST)

Modify a multilingual field in tests

commit:d8ebae3
author:fbennett
date:2016-12-09 08:49 (JST)

Fix multi-tag insert mode

commit:9872046
author:Dan Stillman
date:2016-12-08 20:57 (JST)

Octal literals invalid in strict mode, replacing with hexadecimal

commit:eaa7588
author:Adomas Venčkauskas
date:2016-12-08 20:27 (JST)

Relevant in connectors


Don’t update feeds after syncs during tests

commit:fbd21ba
author:Dan Stillman
date:2016-12-08 19:52 (JST)

This reverts commit 60befe52e4fec76ff7cbe6c169510661d443a971 and adds a better fix that leaves the notifier event in place. Feeds just don’t need to update after syncs during tests.


Remove database closed errors in sync tests

commit:60befe5
author:Adomas Venčkauskas
date:2016-12-08 19:16 (JST)

Fix renaming linked attachment files

commit:2b9ef26
author:Dan Stillman
date:2016-12-08 17:57 (JST)

Align runtests with Z5.0

commit:ced0472
author:fbennett
date:2016-12-07 14:48 (JST)

Bypass cache when requesting .prop file from WebDAV

commit:021f8e1
author:Dan Stillman
date:2016-12-06 22:39 (JST)

This might not be necessary, but it’s an attempt to troubleshoot https://forums.zotero.org/discussion/63439/attachments-not-syncing, which might be a caching issue.


Fix error exporting standalone notes

commit:73e1fd0
author:Dan Stillman
date:2016-12-06 22:17 (JST)

Exclude feeds from Quick Format searches

commit:99cd11e
author:Dan Stillman
date:2016-12-06 21:13 (JST)

Addresses #1126


Show more startup errors in Standalone, with stack

commit:1d45f3d
author:Dan Stillman
date:2016-12-06 20:12 (JST)

Fix reading settings from other-app profile

commit:5866a76
author:Dan Stillman
date:2016-12-06 19:20 (JST)

Don’t show migration message in a popup in Standalone

commit:c08354e
author:Dan Stillman
date:2016-12-06 19:09 (JST)

Apparently this was happening sometimes, though I’m not sure how.


Remove “do not interrupt” from migration message

commit:abff9e3
author:Dan Stillman
date:2016-12-06 17:46 (JST)

It would be good for people not to kill the process indiscriminately, but the migration will theoretically pick up where it left off, so it shouldn’t be too big a deal.


Account for encoding step in patch mode

commit:f2735a1
author:fbennett
date:2016-12-06 12:21 (JST)

Fix context menu auto-selection bug

commit:88096ac
author:Dan Stillman
date:2016-12-06 11:34 (JST)

A context-menu entry was being selected automatically when the click target was near the bottom of the screen.


Fix typo in JM test

commit:305b203
author:fbennett
date:2016-12-06 10:09 (JST)

Avoid dom nav fail w/no nextSibling (fixes itemPaneTest)

commit:d590227
author:fbennett
date:2016-12-06 09:10 (JST)

Remove cruft missed in previous merge operation

commit:afcb7ae
author:fbennett
date:2016-12-05 23:34 (JST)

Do a better job of displaying startup errors

commit:2d6a1b3
author:Dan Stillman
date:2016-12-05 19:17 (JST)

This helps ensure that the toolbar button opens an alert with the relevant error instead of opening the Zotero pane with an infinite progress meter.


Remove redundant _addToolbarIcon() calls at startup

commit:c54af7a
author:Dan Stillman
date:2016-12-05 19:17 (JST)

Fix item-not-loaded error resetting data in unloaded library

commit:d19732b
author:Dan Stillman
date:2016-12-05 19:05 (JST)

Fix User-Agent header handling for endpoints updated in b5bc18c7ed

commit:302efb0
author:Dan Stillman
date:2016-12-05 17:05 (JST)

Add new init(options) signature for server endpoints

commit:b5bc18c
author:Dan Stillman
date:2016-12-05 16:29 (JST)

An endpoint can now take a single object containing ‘method’, ‘pathname’, ‘query’, ‘headers’, and ‘data’ and return an integer, an array containing [statusCode, contentType, body], or a promise for either. This allows the handlers to use the HTTP method and headers and removes the need for callbacks when some handlers already use coroutine().

If init() returns a promise, it now has to use the new single-parameter signature (because the check is done with Function.length, and combining promises and callbacks doesn’t make sense anyway).


Update styles

commit:7c621aa
author:fbennett
date:2016-12-05 10:43 (JST)

Update translators

commit:122d9ba
author:fbennett
date:2016-12-05 10:43 (JST)

Juris-M locale changes

commit:792f140
author:fbennett
date:2016-12-05 10:42 (JST)

Juris-M monster checkin

commit:5cf4932
author:fbennett
date:2016-12-05 10:41 (JST)