5.0.52m40-HEAD¶
Frank Bennett <https://twitter.com/fgbjr>_
Tweak ISBN fixtures AGAIN, remove broken function call.
| commit: | 748738b |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-09 13:45 (JST) |
Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0
| commit: | 564fe73 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-09 06:19 (JST) |
Revert 43af7883 and successors
| commit: | d049496 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 17:38 (JST) |
- Patch rejected by upstream. Reverting to adopt upstream changes.
Fix duplicates view
| commit: | 25ff7c6 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 16:05 (JST) |
Align symlinks build script with upstream Zotero
| commit: | e1ea452 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 07:14 (JST) |
Test adjustments
| commit: | 5cd9548 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 06:19 (JST) |
Initialize only once in previewFn
| commit: | 07512a7 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 05:53 (JST) |
Bump version
| commit: | a36fda8 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 05:32 (JST) |
Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-5.0
| commit: | bacd3f1 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 05:31 (JST) |
Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0
| commit: | 9983211 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 05:07 (JST) |
Update citeproc-js to 1.1.237
| commit: | dd23456 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-08 05:05 (JST) |
There were several facets to this. This change companions with citeproc-js tag 1.1.236.
| commit: | 43af788 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-06 09:58 (JST) |
- When previewFn was run via the Classic dialog before updating citations [1], the citations array returned by getCiteprocLists was of zero length, but the function would process index positions (idx) based on the field position within the document. The preview operation would succeed, and could be canceled without error, but that left the processor initialized with an empty registry, and subsequent operations crashed on attempts to access unregistered citationIDs.
- Performing an implicit hard refresh in previewFn when an empty array is encountered cleared the issue above, but exposed a crashing bug in citeproc-js preview mode, which erroneously assumed that the previewed citation would always be present in the registry, which is not the case.
- Addressing the citation registry bug above exposed a further problem in
rendering context. There seem to have been two issues here, one in the
processor and one in Zotero.
- In the processor, it seems that previewing a citation under a citationID already in the registry erroneously caused the processor to trigger an ibid citation for the preview. I’m not clear on the details, but removing the citationID from the previewed citation and allowing citeproc-js to cut a fresh citationID for it seemed to remedy all but one “ibid” failure condition. That brings us to the last item in the journey.
- In Zotero, the values in the second array returned from getCiteprocLists (fieldToCitationIdxMapping) were set as numeric strings drawn from a walk over the keys in the citationsByIndex object. In previewFn, the index of the predecessor to the previewed citation is set by adding one to the array value. For the string value we were getting things like “0” -> “01” and “3” -> “31”. As a result, extra citationID tuples were included in citationsPre, many of which would be prior to the current citation note position, and were repeated in citationsPost. Processor behavior under those conditions is undefined, but in preview mode it seems to have been relatively harmless, apart from messing up the context of the preview. A consistent failure was to render the last citation in the document always as ibid in preview (because all citations, including the last, were included in citationsPre).
Merge pull request #54 from mvwestendorp/jurism-5.0
| commit: | 4a63bb0 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-06 07:19 (JST) |
Fix permission error for deployer submodule
Update citeproc-js to 1.1.234
| commit: | 571fd4a |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-04 13:11 (JST) |
Blink on language field if implicitly updated
| commit: | d978528 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-04 12:22 (JST) |
Be careful with popup in test
| commit: | 315a9ec |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-04 12:19 (JST) |
Add a second test of title lang -> language field
| commit: | 01cbda0 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-04 08:39 (JST) |
Test of title lang -> language field write
| commit: | 6b18195 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-03 23:15 (JST) |
Update citeproc-js to 1.1.233
| commit: | 9e336ec |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-03 16:27 (JST) |
Two bugfixes
- Write the title lang to the language field if empty, not the other way around.
- Fix tabbing bug in the jurisdiction field. Was attempting to set an empty field (permitted on newspaper and journal articles, and standards) to undefined, and that broke tabbing.
| commit: | 0c1e84c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-03 16:25 (JST) |
Read shortTitle or title-short, write title-short
| commit: | bf8710b |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-03 12:19 (JST) |
Used title-short in test fixtures
| commit: | b4b5c59 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-03 12:18 (JST) |
Bump version
| commit: | e6ab517 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 15:57 (JST) |
Update styles
| commit: | 17aa4a4 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 15:56 (JST) |
Extend timeout again for identifier tests.
| commit: | de8f1e6 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 15:54 (JST) |
Update repotime.txt
| commit: | fdd682b |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 15:53 (JST) |
Set Language field from title main language
| commit: | 21d1202 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 15:53 (JST) |
Update translators
| commit: | cad3d7f |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 13:53 (JST) |
Merge locale info from upstream Zotero
| commit: | 02506f2 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 13:22 (JST) |
Merge changes from upstream Zotero
| commit: | de71acf |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 13:19 (JST) |
Update citeproc-js to 1.1.232
| commit: | 4432707 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-02 12:52 (JST) |
Revert MLZ change to duplicates detection
| commit: | 133b4d9 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-01 15:42 (JST) |
Ålign dupes code line with upstream Zotero
| commit: | 7acfd49 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-04-01 15:28 (JST) |
Update citeproc.js to 1.1.229
| commit: | d790eb8 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 22:32 (JST) |
Merge from upstream Zotero
| commit: | 97710aa |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 16:17 (JST) |
Fix
| commit: | 4608648 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 16:05 (JST) |
Fix
| commit: | 512ad84 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 16:01 (JST) |
Show container title really
| commit: | 4a22dc4 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 15:51 (JST) |
Show container title in center pane if no title
| commit: | da762d0 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-31 15:44 (JST) |
Align mapping of podcast to broadcast with Zotero
| commit: | 94efaee |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-21 21:21 (JST) |
Fix a merge d’oh
| commit: | 4f79aaa |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-21 21:20 (JST) |
Update styles
| commit: | 422dad9 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-20 23:29 (JST) |
Update citeproc-js to 1.1.222
| commit: | ab98b91 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-20 23:28 (JST) |
Merge changes from upstream Zotero
| commit: | 81b751c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-20 23:28 (JST) |
Update translators
| commit: | 15a050c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-13 05:49 (JST) |
Update styles
| commit: | f6975ea |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-10 21:16 (JST) |
Merge changes from upstream Zotero
| commit: | ee54fa9 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-09 10:31 (JST) |
Bump repotime again
| commit: | fb3aef6 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-09 10:17 (JST) |
Update repotime
| commit: | da06880 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-09 09:25 (JST) |
Update citeproc-js to 1.1.220
| commit: | f9b33b4 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-09 09:25 (JST) |
Merge locales from upstream Zotero
| commit: | 3742739 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-05 07:23 (JST) |
Extend timeout in two tests
| commit: | 0d636ee |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-05 07:20 (JST) |
Merge changes from upstream Zotero
| commit: | 7fa0f6c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-05 07:20 (JST) |
Fix lagginess in creator editing
| commit: | 09039c9 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-04 23:49 (JST) |
itembox.xul: fix bug in creators, remove code that maybe clobbered input during sync.
| commit: | 62ca058 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-04 17:58 (JST) |
Assume all fields are set to LANG if LANG is preregistered and set in language field.
| commit: | fdce76e |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-03 05:40 (JST) |
Update styles
| commit: | 7875c72 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-03 03:39 (JST) |
Add pull script
| commit: | 4679fbb |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-02 18:27 (JST) |
Checkin of package info
| commit: | 250e50c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-02 12:15 (JST) |
Merge branch ‘master’ of https://github.com/zotero/zotero into jurism-6.0
| commit: | cbc3e24 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-02 10:37 (JST) |
Update chai and mocha
| commit: | 87efcdc |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-01 13:26 (JST) |
Merge branch ‘jurism-5.0’ of github.com:Juris-M/zotero into jurism-5.0
| commit: | 373ea2c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-01 13:05 (JST) |
Update citeproc-js to 1.1.218
| commit: | 5058014 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-01 13:03 (JST) |
Fix for citeproc
| commit: | 7240e5c |
|---|---|
| author: | Frank Bennett |
| date: | 2019-03-01 08:12 (JST) |
Update CSL styles and locales
| commit: | d4db7f2 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-28 20:11 (JST) |
Add juris-m.github.io to list of valid style sources
| commit: | b5899b1 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-28 13:17 (JST) |
Update citeproc-js to 1.1.217
| commit: | 7cb9484 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-28 10:00 (JST) |
Update package-lock.json
| commit: | 21e64ca |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-28 09:51 (JST) |
Update translators
| commit: | a2d2d56 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-28 09:28 (JST) |
Update translators
| commit: | 37f6406 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-27 22:51 (JST) |
Adjust test for multilingual
| commit: | 0172ae1 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-27 22:29 (JST) |
Locale update from upstream Zotero
| commit: | 959d6fe |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-27 21:34 (JST) |
Merge from upstream Zotero
| commit: | fde6c95 |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-27 21:31 (JST) |
Changes from upstream Zotero
| commit: | 27306cc |
|---|---|
| author: | Frank Bennett |
| date: | 2019-02-09 06:58 (JST) |
Update min plugin version
| commit: | 6d3200b |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-27 15:33 (JST) |
Fix test result string
| commit: | 8d26036 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-26 08:39 (JST) |
Mod test to expect two fields (not sure why, this could be a JM bug)
| commit: | 031cb56 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-26 08:38 (JST) |
Use async/await in test to avoid subsequent failure
| commit: | e84c559 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-26 08:37 (JST) |
Remove JM obscenity and other chatter from test runner
| commit: | 18bc9eb |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-26 08:30 (JST) |
Update locales from upstream Zotero
| commit: | 3bf0e0b |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 14:51 (JST) |
Update CSL locales
| commit: | 80c3198 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 14:45 (JST) |
Update package-lock.json
| commit: | d7d859f |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 14:43 (JST) |
Update styles
| commit: | cfa91c3 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 14:43 (JST) |
Update deployer
| commit: | b22e80c |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 14:38 (JST) |
Merge changes from upstream Zotero
| commit: | c8e4750 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 12:10 (JST) |
Update citeproc-js to 210
| commit: | e404a77 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 11:14 (JST) |
Require getDescendants for recursive search in search.js
| commit: | 951db59 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-11-25 11:13 (JST) |
Update translators, tweak lookup test, bump version to m40
| commit: | 543b7c5 |
|---|---|
| author: | Frank Bennett |
| date: | 2018-07-06 10:20 (JST) |
ssh to https circumvent permission error
| commit: | f869b45 |
|---|---|
| author: | Mathijs |
| date: | 2018-06-21 05:44 (JST) |